From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id DB05AA04A3; Tue, 16 Jun 2020 09:50:46 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 4FD3F1B3BB; Tue, 16 Jun 2020 09:50:46 +0200 (CEST) Received: from new3-smtp.messagingengine.com (new3-smtp.messagingengine.com [66.111.4.229]) by dpdk.org (Postfix) with ESMTP id C9FA7199BC for <dev@dpdk.org>; Tue, 16 Jun 2020 09:50:44 +0200 (CEST) Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailnew.nyi.internal (Postfix) with ESMTP id 0F3CF5801F6; Tue, 16 Jun 2020 03:50:43 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute7.internal (MEProxy); Tue, 16 Jun 2020 03:50:43 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm1; bh= MXY7o9eS3vUpCyQJG8RI7oY3iExcVYC6LJN3vQWpRlU=; b=i5PIXbIeUDQCPvL4 SAyaLDDid/7pz5VpFUMrkny/iylE8H5aPBlQhYfp95acI5EYNXt9OrCC5OAM8t5g SF9/MyfrcL/kCxqijGLh3HsDZTC2oVSahKETqFg7NXU2LbFx/qO4YJhXY16VweLj 4mdMTazuHlALBYTFZC4YUvfY0mRi6ZtFUPzu/cKlchzyceSoRA2yWqdb1phEYMyU VihCHEr/UlbtVwwWQo4HS+sX5SFuBDiEoXL2XXYnt6C4Z/5cQVFsSaAM7nsvNj+o C6w1WIAjofJPLnIkN5hrbeYdGTPhR6usLmEXeKZAS/2yEC1dMvI5KNtCCu7xmYLw wc276A== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=MXY7o9eS3vUpCyQJG8RI7oY3iExcVYC6LJN3vQWpR lU=; b=YDE3mlrkvfTzGxHiT4Z+wwxdZSf+I6u2QOAja8/P+Nnm5EQK8INpwZj3B cra4xRJxRAn4ztDmgSSkvzIid+vtwgZb+612Ki4gVkGj4QeCUJYopozaOfm8oQpB 5gdqeJJ4AmV6fPabfFy2O8Ay+gcnA7rzXpu2esV36jrVcc4brqzdcBDeAkrsu74y 08OE8Uw4ZyRiy5UgdNOwCGSU6WpHTGhb5/HROePRFh1fg8sOkPNqPrJpNa8sqO38 FnFuQLYmODfFwUoyI5plqhJD3mIWtBGMCNOtnAbq76L7uUL2Hu4rM99CCtbUJ/Tf wvju9BNIQM1qFWpYyjbrt4yvuhSCg== X-ME-Sender: <xms:0XnoXkR3m9vf2YwJ2sdzUbb7a4yk-CTOL6MTN7cW6OQuOIfMGBSCVw> X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduhedrudeiledguddviecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpedugefgvdefudfftdefgeelgffhueekgfffhfeujedtteeutdej ueeiiedvffegheenucfkphepjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrh fuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgr lhhonhdrnhgvth X-ME-Proxy: <xmx:0XnoXhz8_mCCFCyJaEIA-fDRLA2_pJb-iZQrodQQcJX6xvwC57tSuw> <xmx:0XnoXh3YQgzJtX9JODzZJPpuUlFgB08PTeYnj0urpOZlxXBN1KUSxA> <xmx:0XnoXoB-P-wIS0GQ-OD-ffoHEJwV7N1w7CGFjYPivWumoVARiFrQIg> <xmx:03noXljFz01GrJqB-IQVzHK6XIofRA6XwgyUk7hBEZPKMT3uycqvAQ> Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 4D9FD3060FE7; Tue, 16 Jun 2020 03:50:40 -0400 (EDT) From: Thomas Monjalon <thomas@monjalon.net> To: Tal Shnaiderman <talshn@mellanox.com> Cc: dev@dpdk.org, pallavi.kadam@intel.com, dmitry.kozliuk@gmail.com, david.marchand@redhat.com, olivier.matz@6wind.com, ranjit.menon@intel.com, navasile@linux.microsoft.com, fady@mellanox.com, harini.ramakrishnan@microsoft.com, ocardona@microsoft.com Date: Tue, 16 Jun 2020 09:50:38 +0200 Message-ID: <69231367.salAEKAJ0m@thomas> In-Reply-To: <20200601093818.5420-3-talshn@mellanox.com> References: <20200601093818.5420-1-talshn@mellanox.com> <20200601093818.5420-3-talshn@mellanox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH 2/4] eal: set byteorder in Windows to little endian X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> 01/06/2020 11:38, talshn@mellanox.com: > From: Tal Shnaiderman <talshn@mellanox.com> > > Set the endianness in Windows to RTE_LITTLE_ENDIAN as support > for Windows is limited to x86 architecture for now. > > Signed-off-by: Tal Shnaiderman <talshn@mellanox.com> > --- > --- a/lib/librte_eal/include/generic/rte_byteorder.h > +++ b/lib/librte_eal/include/generic/rte_byteorder.h > #ifdef RTE_EXEC_ENV_FREEBSD > #include <sys/endian.h> > -#else > +#elif defined RTE_EXEC_ENV_LINUX > #include <endian.h> > +#elif defined RTE_EXEC_ENV_WINDOWS && !defined RTE_BYTE_ORDER Why "&& !defined RTE_BYTE_ORDER" ? How can it be defined earlier? > +#define RTE_BYTE_ORDER RTE_LITTLE_ENDIAN > #endif