DPDK patches and discussions
 help / color / mirror / Atom feed
From: Maxime Coquelin <maxime.coquelin@redhat.com>
To: Matan Azrad <matan@mellanox.com>, dev@dpdk.org
Cc: Viacheslav Ovsiienko <viacheslavo@mellanox.com>, stable@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] vdpa/mlx5: fix PCI address comparison
Date: Mon, 4 May 2020 11:15:22 +0200	[thread overview]
Message-ID: <6924db77-e440-d7ab-4584-a514bd208712@redhat.com> (raw)
In-Reply-To: <1588576329-15792-1-git-send-email-matan@mellanox.com>



On 5/4/20 9:12 AM, Matan Azrad wrote:
> A regular memcmp function was used to compare between two objects of
> type `struct rte_pci_addr`.
> 
> Due to the alignment rules of compiler structure builders, some memory
> is not initiated in the structure even though all the fields were
> initiated.
> 
> Therefore, the comparison may fail even though the PCI addresses are
> identical and to cause false failure in probe.
> 
> Use the dedicated API to compare 2 PCI addresses.
> 
> Fixes: 75dd0ae91765 ("vdpa/mlx5: disable RoCE")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Matan Azrad <matan@mellanox.com>
> Tested-by: Noa Ezra <noae@mellanox.com>
> ---
>  drivers/vdpa/mlx5/mlx5_vdpa.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 

Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>

Thanks,
Maxime


  reply	other threads:[~2020-05-04  9:15 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-04  7:12 Matan Azrad
2020-05-04  9:15 ` Maxime Coquelin [this message]
2020-05-04 10:05 ` Maxime Coquelin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6924db77-e440-d7ab-4584-a514bd208712@redhat.com \
    --to=maxime.coquelin@redhat.com \
    --cc=dev@dpdk.org \
    --cc=matan@mellanox.com \
    --cc=stable@dpdk.org \
    --cc=viacheslavo@mellanox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).