DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: steeven lee <steeven@gmail.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] mk: fix examples build failure
Date: Mon, 08 Feb 2016 16:06:38 +0100	[thread overview]
Message-ID: <69285276.9idFayf1Xb@xps13> (raw)
In-Reply-To: <CADvXkJ4rowM8vE1BUzOWuSVU_CpZii+q5ydsLihNNo7Pgij4Tg@mail.gmail.com>

Hi,

2015-12-24 20:38, steeven lee:
> --- a/mk/internal/rte.extvars.mk
> +++ b/mk/internal/rte.extvars.mk
>  # RTE_SDK_BIN must point to .config, include/ and lib/.
> -RTE_SDK_BIN := $(RTE_SDK)/$(RTE_TARGET)
> +RTE_SDK_BIN := $(RTE_SDK)/build

RTE_TARGET is the right value here.
To make it work with "build/" please use RTE_TARGET=build when
building your example.

>  ifeq ($(wildcard $(RTE_SDK_BIN)/.config),)
> -$(error Cannot find .config in $(RTE_SDK))
> +$(error Cannot find .config in $(RTE_SDK_BIN))
>  endif

Yes you're right, the error message looks wrong.
Please, could you send a v2 patch for this fix?

> --- a/mk/rte.extsubdir.mk
> +++ b/mk/rte.extsubdir.mk
> @@ -46,7 +46,7 @@ $(DIRS-y):
>         @echo "== $@"
>         $(Q)$(MAKE) -C $(@) \
>                 M=$(CURDIR)/$(@)/Makefile \
> -               O=$(BASE_OUTPUT)/$(CUR_SUBDIR)/$(@)/$(RTE_TARGET) \
> +               O=$(BASE_OUTPUT)/$(CUR_SUBDIR)/build \
>                 BASE_OUTPUT=$(BASE_OUTPUT) \
>                 CUR_SUBDIR=$(CUR_SUBDIR)/$(@) \
>                 S=$(CURDIR)/$(@) \

I think this change is not needed.
Probably your command is incorrect. Please paste them here.
If the doc is incomplete, a patch would also be welcome. Thanks

  parent reply	other threads:[~2016-02-08 15:08 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-24 12:38 steeven lee
2015-12-27 18:19 ` Thomas Monjalon
2015-12-28  4:20 ` Qiu, Michael
2016-01-05 10:20   ` steeven lee
2015-12-28  4:53 ` Yuanhan Liu
2016-02-08 15:06 ` Thomas Monjalon [this message]
2016-03-02 15:52   ` [dpdk-dev] [PATCH] mk: fix error message Thomas Monjalon
2016-03-03 10:39     ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=69285276.9idFayf1Xb@xps13 \
    --to=thomas.monjalon@6wind.com \
    --cc=dev@dpdk.org \
    --cc=steeven@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).