From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from wout2-smtp.messagingengine.com (wout2-smtp.messagingengine.com [64.147.123.25]) by dpdk.org (Postfix) with ESMTP id D95AD1BBDC for ; Fri, 11 Jan 2019 23:13:16 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.west.internal (Postfix) with ESMTP id DB69B1583; Fri, 11 Jan 2019 17:13:15 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Fri, 11 Jan 2019 17:13:16 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=OYTOVlw5FFDCRLpHF0xuPtOdX56a7TBga1c3g7LzGTo=; b=qBMcWpgrjaI9 243+0EXWUQuQWDNe5Kfoc7DPNKwezpfE/JX/ZeoGsh43DeAzMjz/x4b9Mng9ZOxe TGWvztnfeDl3b0IwlVoLxO6+B8rywX0zq0jf2UgXOCOXK0LzzNar6pCiEv31eqfr wUn9FWmzB5V9G8rwT32JnYXBtMY7GpA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=OYTOVlw5FFDCRLpHF0xuPtOdX56a7TBga1c3g7LzG To=; b=yF3/P8woimo8Byv6tckkqzih/IVFutKccgDhBro0DYfC2w0ztNPq3x+A1 9uCu75u7ASVirzbgCocNnDtocyM8Aof9NT3dYrEQi4w1krl8VAU26nx3xc7jElFa jqmOxLXGkcWRdqPu3973ylHvhf+5jiVRWm5IEZPoLetNIeQOcSI1ZxVez6HXOejt vnmRwi1ybwMqv+ZRSuoN1BJ42uyPnZM3LaYahvxGDrVDsBhezybZ9jOYIAtrlKmG BCTyaEwWqLzxyuc8i6eZe5mhIZQTgqwsmwDV+oXy+nueh0O0+tWZ4p8t70HG4+4o 5XLADZYrnCB2TscMIA8Fd3/srZ8IQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedtledrfeehgdduiedtucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfquhhtnecuuegrihhlohhuthemucef tddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjughrpefhvffufffkjg hfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghsucfoohhnjhgrlhhonhcu oehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucffohhmrghinhepughpughkrd horhhgpdeifihinhgurdgtohhmnecukfhppeejjedrudefgedrvddtfedrudekgeenucfr rghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvthenuc evlhhushhtvghrufhiiigvpedt X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 94615100E4; Fri, 11 Jan 2019 17:13:14 -0500 (EST) From: Thomas Monjalon To: Ferruh Yigit Cc: dpdk-dev Date: Fri, 11 Jan 2019 23:13:13 +0100 Message-ID: <6939248.sCPUF7vAYb@xps> In-Reply-To: <9264cbd7-e96b-af26-b5d6-2217fdf6f351@intel.com> References: <1479772058-7112-1-git-send-email-thomas.monjalon@6wind.com> <5759d5d2-9ece-abbe-587f-b19443046b87@intel.com> <9264cbd7-e96b-af26-b5d6-2217fdf6f351@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] mk: remove make target for examples X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 11 Jan 2019 22:13:17 -0000 11/01/2019 23:01, Ferruh Yigit: > On 11/22/2016 11:49 AM, ferruh.yigit at intel.com (Ferruh Yigit) wrote: > > On 11/22/2016 9:38 AM, Thomas Monjalon wrote: > >> 2016-11-22 00:34, Ferruh Yigit: > >>> On 11/21/2016 11:47 PM, Thomas Monjalon wrote: > >>>> The command > >>>> make examples > >>>> works only if target directories have the exact name of configs. > >>>> > >>>> It is more flexible to use > >>>> make -C examples RTE_SDK=$(pwd) RTE_TARGET=build > >>>> > >>>> Signed-off-by: Thomas Monjalon > >>> > >>> Instead of removing examples & examples_clean targets, what do you think > >>> keeping them as wrapper to suggested usage, for backward compatibility. > >>> > >>> Something like: > >>> " > >>> BUILDING_RTE_SDK := > >>> export BUILDING_RTE_SDK > >>> > >>> # Build directory is given with O= > >>> O ?= $(RTE_SDK)/examples > >>> > >>> # Target for which examples should be built. > >>> T ?= build > >>> > >>> .PHONY: examples > >>> examples: > >>> @echo ================== Build examples for $(T) > >>> $(MAKE) -C examples O=$(abspath $(O)) RTE_TARGET=$(T); > >>> > >>> .PHONY: examples_clean > >>> examples_clean: > >>> @echo ================== Clean examples for $(T) > >>> $(MAKE) -C examples O=$(abspath $(O)) RTE_TARGET=$(T) clean; > >>> " > >> > >> What is the benefit of this makefile? Just remove -C ? > > > > To keep existing targets, in case somebody use them. > > > >> It is not compatible with the old behaviour, so I'm afraid it would be > >> confusing for no real benefit. > > > > Right, not fully compatible, but still can do: > > make examples / make examples_clean > > make examples T=x86_64-native-linuxapp-gcc > > > > Overall, if you believe keeping them is confusing, I am OK with it, just > > may need to update doc/build-sdk-quick.txt to fix "make help" output. > > Hi Thomas, > > There is no update on the patch for a long time, updating it as rejected, please > send an updated version if it is still relevant. > > For record, patch: https://patches.dpdk.org/patch/17174/ The goal was a clean-up. It won't be relevant anymore when the make-based build will be removed. So it's not relevant anymore. Let's focus on meson build.