From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM03-BY2-obe.outbound.protection.outlook.com (mail-by2nam03on0074.outbound.protection.outlook.com [104.47.42.74]) by dpdk.org (Postfix) with ESMTP id B56C75680 for ; Mon, 10 Oct 2016 07:15:29 +0200 (CEST) Received: from DM5PR03CA0016.namprd03.prod.outlook.com (10.175.104.26) by BY2PR0301MB2007.namprd03.prod.outlook.com (10.163.196.29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.659.11; Mon, 10 Oct 2016 05:15:27 +0000 Received: from BN1AFFO11FD019.protection.gbl (2a01:111:f400:7c10::123) by DM5PR03CA0016.outlook.office365.com (2603:10b6:3:118::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.649.16 via Frontend Transport; Mon, 10 Oct 2016 05:15:27 +0000 Authentication-Results: spf=fail (sender IP is 192.88.168.50) smtp.mailfrom=nxp.com; 6wind.com; dkim=none (message not signed) header.d=none;6wind.com; dmarc=fail action=none header.from=nxp.com; Received-SPF: Fail (protection.outlook.com: domain of nxp.com does not designate 192.88.168.50 as permitted sender) receiver=protection.outlook.com; client-ip=192.88.168.50; helo=tx30smr01.am.freescale.net; Received: from tx30smr01.am.freescale.net (192.88.168.50) by BN1AFFO11FD019.mail.protection.outlook.com (10.58.52.79) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.1.629.5 via Frontend Transport; Mon, 10 Oct 2016 05:15:27 +0000 Received: from [10.232.14.87] ([10.232.14.87]) by tx30smr01.am.freescale.net (8.14.3/8.14.0) with ESMTP id u9A5FOWa002020; Sun, 9 Oct 2016 22:15:25 -0700 To: Thomas Monjalon References: <1475949668-26829-1-git-send-email-shreyansh.jain@nxp.com> <184506162.Hjg7Xy8FWv@xps13> <4525292.xovB97rfbE@xps13> CC: "david.marchand@6wind.com" , , "nhorman@tuxdriver.com" From: Shreyansh Jain Message-ID: <694d60e1-ccf2-9501-e19f-d8b7417af5ef@nxp.com> Date: Mon, 10 Oct 2016 10:46:19 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-Matching-Connectors: 131205501276754594; (91ab9b29-cfa4-454e-5278-08d120cd25b8); () X-Forefront-Antispam-Report: CIP:192.88.168.50; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(6009001)(7916002)(2980300002)(1109001)(1110001)(339900001)(24454002)(199003)(377424004)(377454003)(189002)(6666003)(6916009)(2950100002)(586003)(85426001)(86362001)(81156014)(8676002)(104016004)(47776003)(92566002)(33646002)(81166006)(356003)(230700001)(7846002)(19580405001)(19580395003)(65956001)(65806001)(50466002)(36756003)(31696002)(11100500001)(305945005)(93886004)(106466001)(189998001)(23746002)(2906002)(87936001)(65826007)(4326007)(5660300001)(110136003)(68736007)(626004)(105606002)(83506001)(8936002)(97736004)(64126003)(76176999)(31686004)(54356999)(50986999)(4001350100001)(77096005); DIR:OUT; SFP:1101; SCL:1; SRVR:BY2PR0301MB2007; H:tx30smr01.am.freescale.net; FPR:; SPF:Fail; PTR:InfoDomainNonexistent; A:1; MX:1; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; BN1AFFO11FD019; 1:obEqrH0hsEUg+A7FayXgccpZ0YfaM9w9QiPjCzgz/rRd+G1flARieGE1qfHLh6bhki89VLT7FFJSTVUK9yEnqnissGk5e8rbZp22kGSw0djVzDmWQe3BF+8FOcZlETjH/9fCmtA4teZKGa5FI9AVlXsR6H/Ku8crfE/DCCNl+j7SwDUkbAj8308cPmUP1Xbi0/kaX1gabEUqZouYLmvUXWnRjDY0ssBi90BtB1kQTAcAwrOW4BnWyY4h6t/CaG6gVTsrAhoOV7RLsWooiM5UWcXxh/yxZYlI4oeOKTEKDVYDmYmWXnvMvyqqM2Bp9xL2gzmiUMV4RBOMYXP0XeJ/yPIdXyJQ/8qfA7D7m7qjnmR7ps5Weh9ZOIZiAjALxlTJlYQFbH5haTY2vGahsrhEYvvblHirLQxP0ts6zVq3EnavH/jf8dhY7eA8lLX+dcNj0I3ns0KQVVtX7oQ9zX6tqrs1zFKcBVmgCAaLg+VBM97vM4EiDPNsXsnikT6GqAFYJPTB+QKCDYtlW7uaDDcbUwLK6XdN6SKio82NkRyAhY48WJVUhEIF5k4JJxZ9Ckh5XZ0mzUJIHyR+BCLz6Ks/wQ== X-MS-Office365-Filtering-Correlation-Id: 43d75235-ce59-41ed-3141-08d3f0cc72a2 X-Microsoft-Exchange-Diagnostics: 1; BY2PR0301MB2007; 2:om7GXx1vKqyf9kuBoibRovMXb6ayafft/dlRKQax1t8MyR1tKzxAa9P3lI7MXWNy6SSjQ6XCj3860za3Hey6ZLP0xhgGVX2lfToRl5Mbkw7T2CRIlCC7/dIDCf1ssnKDOZ252Pqnehr9E+7Kg/lSmHSUbyEMgdFUQ/XOYUjNh+o0bxBrDfi/IasIrkUxTKF9mQi5TGqEW57oW9NVO3DByw==; 3:2L2s+9tvBCQUeYK66KDFSEMDsOKlSLGEWgFOitGCx+Bi3Pilg5yVPEWg+zAbcz1Mx91dDH4K+q40xjAEyh3TvUOHciR6dIOxlm0Grkb3Qs07HwtMIXoXnCyXS6oCbYdjQNGpkjF00nqyYJHPxeNTJO+6G3qywH03cV/OmdMfTLX50s3zWZDWvq6sZOOc95bHbP0FCdiN5Xh9oWeI2grapj9ZJCuSojiHFFJHqUtVXabqQL3mBFNgK2c6s63jmO4A; 25:bQRyu9vh8JGDRGw1ZL56Dt/dtAEUr0+LULViUpUtBqd3OYUuHQGUwLgHP2ahjdC9C0nKm9ZDXx7zpmyQD6D8SZYh3J/NemAIYMm1QvSIpn0L2gDY8cgUlcm0hx1EoE67Oj4nXuoVmrHD0SDX+MQZj6VU0j0/QDMaCkDvpVqqn73J2jKRxO9UsshwYwHATLE+TzEmSI1YDjOh5nmQJc4Y5jb0EJWZNwr98F9iRTaOA14A+FRAWXeFRN/PQfQlGcwNhaQg2DBDsJHp6myYoKr/uEqblDkTKM1MdND05M0vm/dFFr2BYkVHLe9A7ppQUaTfknj5XO+kFj85etGiozuhvYpOq8iulb5I3+4H0oSLlFckuyh4oPEhejQGiSPtkr7UXWoiinYQR/Ch9FtpIxnH4widP7sM5gPsiLnR602AirBzVbo8Joy3/Gxru5BJcxfa X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BY2PR0301MB2007; X-Microsoft-Exchange-Diagnostics: 1; BY2PR0301MB2007; 31:78h3kJSYxuFKXWcQJq4fIEg3V+j0zq59UcmQeBXZjAnkqCPOsVAGvDyOUKXL94LD0NIsdToy7rsul0QlvZ2fnFVeW0ai1wQLT4+/KIb4j5atCOIOSjcs3O6fJiW4ukT1Vx3HU99u3bx1lPfq6cm6qYz/apVYHfhcRIb3vNWgRBm71LTuvBh4mp0GsdTtfZmP3Kxt2tmyS3n6LxeAdeUEaI3z57PSoa+dEyvePSqQWV/06n6FCztsgHDM3/1bVApi; 4:1kpg6GPdVW0502nQfbIRnEr5dDE8FgwZ7YdEzd1fjolKJmxG3rfG4uvi09OZy8ZdBgEL1Zxsw0zQoxpFQk1I7q99smu/SgtSQq2879wxoKzlpRUEeclSQcSR63Qx/ZdoBDGMRcmrK/NPkJqO3A44ZGzrA2MQd+8E3lmSKjI2WOqpW2h8L9AvO35B8P2/XQDe71O7RP3tdVZ9LyvRg0cCY3UWA8gTUDQdrsMi1Ebjq9pORbIHqcuyRGFOqfHBT7gx61ofOl6OW4xHEJoK2BJBmQRylMrWiPOhxJz473lLMVy1uqr3ypuNV1HfwPgIPIdS3Ukc8zSQLmtD/YVCNojidwmd6bWWoSWjw0EN8o07A6HLmc5pfrTwqPIDgrpgg4N2ecqyXxCLGEE0ULyojI1Svcv9ssTSowWDUZh1+l+GXJG08x8waIRrpciZYCE1QrHQ06iR2TYRBF3HSBXHSCFtej9bRFN5sliieyrU24hl8rrA7dmlb+MoAxJTqs0rG8HadHgTnsMxlgEvoFPVgRn/Cw== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040176)(601004)(2401047)(13018025)(13023025)(13017025)(13015025)(13024025)(5005006)(8121501046)(3002001)(10201501046)(6055026); SRVR:BY2PR0301MB2007; BCL:0; PCL:0; RULEID:(400006); SRVR:BY2PR0301MB2007; X-Forefront-PRVS: 0091C8F1EB X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1; BY2PR0301MB2007; 23:rPxCTtNR8TPuj48WGI9SJNOxdqoYNqIgSAs?= =?Windows-1252?Q?fbGFf83K1s4wIGox0V1r3HkLJ9uF8YGoB2zR4gU0HuYdtjuFYk6OMjbl?= =?Windows-1252?Q?LhtbL/NJMV9gZ8v6+Pt+8+noxfjMDnPkHEyiZp3aOTDuJPdlnYyWhWR8?= =?Windows-1252?Q?Y9lv4B7oHPYGfAcoBPoiZTCamSUzpqm/d5GO1XTjfM2DCygdwPxkyvFZ?= =?Windows-1252?Q?LDE4iIdJmFoKzLTCfn/sNv1NH6HZdw+mzdocF2QD6goM7EwLPUXY2bR7?= =?Windows-1252?Q?vf8FzGCim0j17X80IMHZctZQhkOiLlGHI2xuWZPiHGfAu36o44FsdQAA?= =?Windows-1252?Q?A5XR7TgcRsnuIKLBFsF5TMxbi2kjVQMLVvJHlhCEslJE7mM+TQ9M5lLf?= =?Windows-1252?Q?f9hvAXGUP0BXPGfUGJzzZETHzTO/UNXeNHyhZCxq0TLkTKPP19FxOmf6?= =?Windows-1252?Q?IqABx3ovPG8+a2ICNSMHJYtJCiJ8S9MTqarQTCtdg+KWu2QC+/0sWse0?= =?Windows-1252?Q?aeMTcDWzaf79NJtLip0u3EWq6gzBIZvdZlLVEcXlYUpzZU7Oi3hynOL+?= =?Windows-1252?Q?Lc2LlWHS3DVjGu7BWTpPepikK3IrjNOBhKSaTapdolMPm7JRUUr8PggK?= =?Windows-1252?Q?5CuUcGEZyMNiicuF4iAJG2v0QhDUzSxY/kSNcQC4IRKEMFiMQa2AvQca?= =?Windows-1252?Q?KAhoZOIVmdmZelMdWkTjsj41QCvrILzjsnlFG9EJPviTgOtimJg8zmJC?= =?Windows-1252?Q?Gk8AMgBaSHGB7tdNyS6UdKB/MEy365OPJgmgSjyFccp8e/NsILQ6tIKE?= =?Windows-1252?Q?EJpgG8hw7vreadD4pORKIIthEqI1w8M5SopSXYRuQ9phOI8a/Vix1vND?= =?Windows-1252?Q?OEVmYRmNOyiS5nqBwjdyV+cM+1pKp6USRg0J2MhpnFa90mnDpOiF123u?= =?Windows-1252?Q?XZwIosksiuxE/GWm0Zf1N3GtV12S/JE66p5UYSsovPY4tbwRnPfmqFU4?= =?Windows-1252?Q?SQuTnOHlY8uacbIzQiH587K6rTB7u7s9kFtF/mjve8/5K2ojTpbV7sq7?= =?Windows-1252?Q?RkTeQv28QWRLxMZGZ07ICbmBsH+JSeSpnEBlJJya1LleKZ5ByWQmPsBG?= =?Windows-1252?Q?Bbb5ax858znltAyPzb7eJNeqAZcqUbukoQJ3eImmfXCozhm/THRczdid?= =?Windows-1252?Q?JmKQYahz/+ni97q/CdM07Obkgb+7MQsGwiOk2kzJo7aPc7LhxzjENplV?= =?Windows-1252?Q?C5kGJtZ89ZRYD1irg7Eas+lFYFkqbI8ELRJrLfzl4wiHO0MRtHrMNfzn?= =?Windows-1252?Q?i/+FBh2Uv+d93FaZCs60imV/D6htwCQY428aOqriARO5GxXm399jq+i8?= =?Windows-1252?Q?rxFcWa6x+Dp31kQkaHH+Z2/6m+uPpY15MD3u2xgE9yzvnn4KUieafGCz?= =?Windows-1252?Q?8gbHvuxoJbCNhEXnEzFoPp0rzwqsKyC6W/fusxjLRtRnUmVwTmm3eJFl?= =?Windows-1252?Q?AiE/Nb2VZrnCAYyANI1ntJWo3v2pZ?= X-Microsoft-Exchange-Diagnostics: 1; BY2PR0301MB2007; 6:eu6RxR8O7osouRIhBurUQJ7pazTogaYQE+3WDWewnwe3AAI7MYeq+Fd8gJI0Cg6C1MG+YDPGi6jJXHUBZ7n45G3r0xsDVn58VD4XRhSs12zFhI208mXN5gpa/hEYCuJOXD8DdhroMdkXsoeOF3fI5Wm+iZLs5Isz/9VYM50GFIuhCZUcXKTsXRPKpR/p17P+W9VDstz6BFspurFwVwxnHUeqx/8Pq1C94R97u+10R8MRVjgRLUPcQPLXsy+JN2D0jKLvfUdLoK28Z6nfctoxrB4gHETnib9fTjLYDv/92N3HLUL8Tf2tEAK4dupEfUp5; 5:Q40N/CPGIOH7yaLkn7F7iJjD3ZnwjsjV+6m7gpPxmA7f74KdNDtFZ2ZwAKsC9FeGjwzcRQQxtRBYWgSP6sS/o9seEUIw3fFSNyZ7Hh8/LUt5jvrf5jsE2UsrqHHfw7NSU29Ugoat/pW3DmcVEM984Q9A8Lx200/5VjaurPpb6esXpIkOyZCLvND+x0pg46Om; 24:LpxYwVxXA1RlJ1BTnzsa0c4Aha8S+z/GtD2rM4cu5h3iYA8aODLncjH65I+uqfWLpXcsx0tEPEvyNK7hG53NdWflDpyiO6gdmLaX0ZBsSSc= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; BY2PR0301MB2007; 7:41F06HrQYNj6pqLYHkvrYVJMbsK1FlxN+wqimnuruc8KD72xXun24rWxXaklvNeYNPqZr9hcLXsghA7FNCzQjWUJr4AM7x+pPYYExRX8iQ8kpTnClb9sD/rUhcW+Yg3y+cB1DVmf4t9+LYnQofGd9U4yBiiB6zmef2YyPyBpvlNvazKjmL7kTBNC+QF7hFb28lJ1srP5NapXZVShNKWIGIxAlP4WauleIYdUSQPjHvEJ/Zyr9QTyajMm7jUuqXEdDF4GaXg4F5JWUWQ5f7PIY6pRg6vkYjyMon8OVry6DklpCGHJblHC342N+bmJoMng7bKYK/XhWTpgqGOtBSQ4URhHcdK6QEbkXAdUsrFMfls= X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Oct 2016 05:15:27.2386 (UTC) X-MS-Exchange-CrossTenant-Id: 5afe0b00-7697-4969-b663-5eab37d5f47e X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e; Ip=[192.88.168.50]; Helo=[tx30smr01.am.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY2PR0301MB2007 Subject: Re: [dpdk-dev] [PATCH v2] drivers: prefix driver REGISTER macro with RTE PMD X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 10 Oct 2016 05:15:30 -0000 On Monday 10 October 2016 10:41 AM, Shreyansh Jain wrote: > On Monday 10 October 2016 01:20 AM, Thomas Monjalon wrote: >> 2016-10-09 15:12, Shreyansh Jain: >>> From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] >>>> 2016-10-08 23:35, Shreyansh Jain: >>>>> +PMDINFO_TO_O = if grep -E 'RTE_PMD_REGISTER_PCI\([0-9a-zA-Z,_\. >>>> ]+\)|RTE_PMD_REGISTER_VDEV\([0-9a-zA-Z,_\. ]+\)' $<;\ >>>>> + then \ >>>> >>>> I don't understand why you don't simply grep 'RTE_PMD_REGISTER_.*(' ? >>> >>> Because I want to make sure that the grep matches only the DRIVER >>> registration functions. >>> In case a new macro (or driver type) is added in future, this macro >>> can be updated. This way we can reduce the probability of a faulty >>> match. >>> >>> Is there a problem with closest possible match? >> >> It is just long and useless. A macro starting with RTE_PMD_REGISTER_ must >> be called from a PMD. What else? > > Long, yes. But I don't know why you state it as useless. Reducing > probability of a false positive is what it does. > > Anyways, I will send a v3 with "grep -Eq 'DRIVER_REGISTER_.*\(.*\)'". I meant "grep -q 'RTE_PMD_REGISTER_.*(.*)'". Minimal changes from existing. - Shreyansh