From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <kirill.rybalchenko@intel.com> Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 64A5B1B257 for <dev@dpdk.org>; Thu, 12 Oct 2017 13:41:55 +0200 (CEST) Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 12 Oct 2017 04:41:52 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.43,365,1503385200"; d="scan'208";a="137775214" Received: from irsmsx151.ger.corp.intel.com ([163.33.192.59]) by orsmga004.jf.intel.com with ESMTP; 12 Oct 2017 04:41:51 -0700 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.167]) by IRSMSX151.ger.corp.intel.com ([169.254.4.108]) with mapi id 14.03.0319.002; Thu, 12 Oct 2017 12:41:51 +0100 From: "Rybalchenko, Kirill" <kirill.rybalchenko@intel.com> To: Thomas Monjalon <thomas@monjalon.net> CC: "dev@dpdk.org" <dev@dpdk.org>, "Chilikin, Andrey" <andrey.chilikin@intel.com>, "Xing, Beilei" <beilei.xing@intel.com>, "Wu, Jingjing" <jingjing.wu@intel.com>, "Yigit, Ferruh" <ferruh.yigit@intel.com> Thread-Topic: [dpdk-dev] [PATCH v5 1/4] ethdev: add support for raw flow type for flow director Thread-Index: AQHTQgZzzJGCm3ePR0q0yB82MkOFSKLfKy8AgADuFvA= Date: Thu, 12 Oct 2017 11:41:50 +0000 Message-ID: <696B43C21188DF4F9C9091AAE4789B824E2A26F5@IRSMSX108.ger.corp.intel.com> References: <1507666412-15320-1-git-send-email-kirill.rybalchenko@intel.com> <1507667338-15742-1-git-send-email-kirill.rybalchenko@intel.com> <1507667338-15742-2-git-send-email-kirill.rybalchenko@intel.com> <8389257.54itpyZSoc@xps> In-Reply-To: <8389257.54itpyZSoc@xps> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZDVhN2M3N2UtOGRhMC00YTM3LTgxMmMtZjg3MWI0MjRkYjQ1IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6InhvVjhtb3FpSFp4ZVg3R3lVbU9TZ0NvUkdRSXpvSGUwcm1SWWhMZUlaa009In0= x-ctpclassification: CTP_IC dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v5 1/4] ethdev: add support for raw flow type for flow director X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <http://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <http://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Thu, 12 Oct 2017 11:41:57 -0000 Hi Thomas, The reason this feature is needed is to be able to program custom flow type= s using a template packet rather than building up a C struct to define the = protocol. This means that users don't have to work on the DPDK internals to= support new flow types that they may be using, but can instead add them dy= namically as part of their application. There are also several customers wh= o are looking for this feature as part of the 17.11 LTS release. This patchset has been out since August and these comments are very late, w= ith the first objections last week, which we tried to answer. This short no= tice doesn't allow us a reasonable amount of time to take them into account= . However, to address your primary concern, we can implement this using a i40= e private API, so that we are not tying users to FDIR APIs and thus not blo= cking the removal of the APIs in time. Ideally we would like to use rte_flow but it is based around the idea of de= scribing packet headers which is significantly different from the proposed = method using template packets. Longer term it may be possible to support th= is in rte_flow, we could propose this for discussion in the next release, a= nd if there is community interest/agreement we can add it. We will rework this, in the short term, as a private API, as suggested abov= e, and then propose an rte_flow API in the longer term. Let us know if you = have any concerns about this. Regards, Kirill. > -----Original Message----- > From: Thomas Monjalon [mailto:thomas@monjalon.net] > Sent: Wednesday 11 October 2017 23:27 > To: Rybalchenko, Kirill <kirill.rybalchenko@intel.com> > Cc: dev@dpdk.org; Chilikin, Andrey <andrey.chilikin@intel.com>; Xing, Bei= lei > <beilei.xing@intel.com>; Wu, Jingjing <jingjing.wu@intel.com>; Yigit, Fer= ruh > <ferruh.yigit@intel.com> > Subject: Re: [dpdk-dev] [PATCH v5 1/4] ethdev: add support for raw flow > type for flow director >=20 > Hi, >=20 > 10/10/2017 22:28, Kirill Rybalchenko: > > Add new structure rte_eth_raw_flow to the union rte_eth_fdir_flow to > > support filter for raw flow type. > > > > Signed-off-by: Kirill Rybalchenko <kirill.rybalchenko@intel.com> >=20 > This description does not explain why you add this new flow director type= . > It seems you are allowing a new feature to filter custom protocols. >=20 > As I replied on v2, you are implementing your new feature with a deprecat= ed > API (there is a deprecation notice without any deadline). > It is dangerous because this new use case will be settled on top of a fra= gile > foundation. And because of these new users, it will be harder to drop thi= s > API as announced. > It is also dangerous because you are not trying to implement your feature > with the new rte_flow API. So we cannot be sure that it will fit for ever= y use > cases. > If rte_flow is not good enough, we must improve it. >=20 > This is my suggestion: > 1/ Implement this interesting feature with rte_flow. > 2/ Switch every other use cases to rte_flow. > 3/ Let's agree on a date to drop the legacy flow director API. >=20 > So this is a NACK. > Please let's move forward.