From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id 667671B16B for ; Tue, 9 Jan 2018 16:16:41 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 09 Jan 2018 07:16:40 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.46,335,1511856000"; d="scan'208";a="17864246" Received: from irsmsx101.ger.corp.intel.com ([163.33.3.153]) by FMSMGA003.fm.intel.com with ESMTP; 09 Jan 2018 07:16:38 -0800 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.167]) by IRSMSX101.ger.corp.intel.com ([169.254.1.46]) with mapi id 14.03.0319.002; Tue, 9 Jan 2018 15:16:14 +0000 From: "Rybalchenko, Kirill" To: Adrien Mazarguil CC: "dev@dpdk.org" , "Wu, Jingjing" , "Xing, Beilei" , "johndale@cisco.com" , "neescoba@cisco.com" , "nelio.laranjeiro@6wind.com" , "yskoh@mellanox.com" , "Lu, Wenzhuo" , "Ananyev, Konstantin" , "Chilikin, Andrey" Thread-Topic: [PATCH] ethdev: increase flow type limit from 32 to 64 Thread-Index: AQHTZ3t0CyVfYr9MPEyxDBj4dGpSK6Mzf7UAgDhogPA= Date: Tue, 9 Jan 2018 15:16:13 +0000 Message-ID: <696B43C21188DF4F9C9091AAE4789B824E2B6786@IRSMSX108.ger.corp.intel.com> References: <1511785787-127452-1-git-send-email-kirill.rybalchenko@intel.com> <20171204174304.GK4062@6wind.com> In-Reply-To: <20171204174304.GK4062@6wind.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYjQ2OWE3ZDgtMzFmNi00YjE2LWI4MTAtNGI0ZTc3YTM1ODc5IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6IkhWUmxzM2pvT3c3TjUybjA1VFFZQjRjMm5ybEczQXk1R2FBK25KOFNDY1E9In0= x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] ethdev: increase flow type limit from 32 to 64 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 09 Jan 2018 15:16:42 -0000 > -----Original Message----- > From: Adrien Mazarguil [mailto:adrien.mazarguil@6wind.com] > Sent: Monday 4 December 2017 17:43 > To: Rybalchenko, Kirill > Cc: dev@dpdk.org; Wu, Jingjing ; Xing, Beilei > ; johndale@cisco.com; neescoba@cisco.com; > nelio.laranjeiro@6wind.com; yskoh@mellanox.com; Lu, Wenzhuo > ; Ananyev, Konstantin > ; Chilikin, Andrey > > Subject: Re: [PATCH] ethdev: increase flow type limit from 32 to 64 >=20 > Hi Kirill, >=20 > On Mon, Nov 27, 2017 at 12:29:47PM +0000, Kirill Rybalchenko wrote: > > Increase the internal limit for flow types from 32 to 64 to support > > future flow type extensions. > > Change type of variables from uint32_t[] to uint64_t[]: > > rte_eth_fdir_info.flow_types_mask > > rte_eth_hash_global_conf.sym_hash_enable_mask > > rte_eth_hash_global_conf.valid_bit_mask > > > > This modification affects the following components: > > net/i40e > > net/enic > > net/mlx5 > > net/ixgbe > > app/testpmd > > > > Signed-off-by: Kirill Rybalchenko >=20 > Can you elaborate a bit on the need for these changes? > Have you considered implementing those future extensions through > rte_flow instead? Hi Adrien, this is not a new feature but rather fix of existing limitation. In current implementation the symmetric hash mask and flow mask are represented by 32-bit variable, while hardware bitmask has 64 bits. Unfortunately, this modification changes ABI of the library as it changes s= ize of rte_eth_fdir_info structure. All related PMDs (listed above) had to be m= odified accordingly. =20 >=20 > -- > Adrien Mazarguil > 6WIND