From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id BF410728B for ; Wed, 14 Mar 2018 12:04:28 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 14 Mar 2018 04:04:26 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.47,470,1515484800"; d="scan'208";a="24561115" Received: from irsmsx152.ger.corp.intel.com ([163.33.192.66]) by orsmga007.jf.intel.com with ESMTP; 14 Mar 2018 04:04:25 -0700 Received: from irsmsx155.ger.corp.intel.com (163.33.192.3) by IRSMSX152.ger.corp.intel.com (163.33.192.66) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 14 Mar 2018 11:04:24 +0000 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.9]) by irsmsx155.ger.corp.intel.com ([169.254.14.21]) with mapi id 14.03.0319.002; Wed, 14 Mar 2018 11:04:24 +0000 From: "Rybalchenko, Kirill" To: wangyunjian , "dev@dpdk.org" CC: "caihe@huawei.com" Thread-Topic: [dpdk-dev] [PATCH v2] net/i40e: fix intr callback unregister by adding retry Thread-Index: AQHTupggnWceIYVXuEKe6NWHwFEaVKPPkcrg Date: Wed, 14 Mar 2018 11:04:24 +0000 Message-ID: <696B43C21188DF4F9C9091AAE4789B824E2D62F3@IRSMSX108.ger.corp.intel.com> References: <1520924004-15708-1-git-send-email-wangyunjian@huawei.com> In-Reply-To: <1520924004-15708-1-git-send-email-wangyunjian@huawei.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiY2NlZGI1OGYtNzk3OC00YTdkLWI5ZDAtODIwMzc3YzkzZmZlIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6ImszUFlRdjdRVG83Q1VCb3FUZ1VZQ2xONkd6Rjh5b1BqaEtUbVVYcG9vMUU9In0= x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2] net/i40e: fix intr callback unregister by adding retry X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 14 Mar 2018 11:04:29 -0000 Hi Yunjian, > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of wangyunjian > Sent: Tuesday 13 March 2018 06:53 > To: dev@dpdk.org > Cc: caihe@huawei.com; Yunjian Wang > Subject: [dpdk-dev] [PATCH v2] net/i40e: fix intr callback unregister by > adding retry >=20 > From: Yunjian Wang >=20 > The nic's interrupt source has some active callbacks, when the port hotpl= ug. > Add a retry to give more port's a chance to uninit before returning an er= ror. >=20 > Fixes: d42aaf30008b ("i40e: support port hotplug") >=20 > Signed-off-by: Yunjian Wang > --- > v2: > * Fix return value check > --- > drivers/net/i40e/i40e_ethdev.c | 16 ++++++++++++++-- > 1 file changed, 14 insertions(+), 2 deletions(-) >=20 > diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethde= v.c > index 508b417..0a29fdd 100644 > --- a/drivers/net/i40e/i40e_ethdev.c > +++ b/drivers/net/i40e/i40e_ethdev.c > @@ -1533,6 +1533,7 @@ void i40e_flex_payload_reg_set_default(struct > i40e_hw *hw) > struct rte_flow *p_flow; > int ret; > uint8_t aq_fail =3D 0; > + int retries =3D 0; >=20 > PMD_INIT_FUNC_TRACE(); >=20 > @@ -1575,8 +1576,19 @@ void i40e_flex_payload_reg_set_default(struct > i40e_hw *hw) > rte_intr_disable(intr_handle); >=20 > /* register callback func to eal lib */ It's not a part of your patch, but I believe it makes sense to fix this: /* unregister callback func from eal lib */ > - rte_intr_callback_unregister(intr_handle, > - i40e_dev_interrupt_handler, dev); > + do { > + ret =3D rte_intr_callback_unregister(intr_handle, > + i40e_dev_interrupt_handler, dev); > + if (ret >=3D 0) { > + break; > + } else if (ret !=3D -EAGAIN) { > + PMD_INIT_LOG(ERR, > + "intr callback unregister failed: %d", > + ret); > + return ret; > + } > + i40e_msec_delay(100); > + } while (retries++ < 5); >=20 > i40e_rm_ethtype_filter_list(pf); > i40e_rm_tunnel_filter_list(pf); > -- > 1.8.3.1 >=20