Re: [dpdk-dev] [PATCH v4 00/11] Rework API for RSA algorithm in asymmetric crypto

["Nowak, DamianX" <damianx.nowak@intel.com>]

> -----Original Message-----
> From: Kusztal, ArkadiuszX
> Sent: Wednesday, July 17, 2019 14:51
> To: dev@dpdk.org
> Cc: akhil.goyal@nxp.com; Trahe, Fiona <fiona.trahe@intel.com>;
> shallyv@marvell.com; Nowak, DamianX <damianx.nowak@intel.com>;
> Kusztal, ArkadiuszX <arkadiuszx.kusztal@intel.com>
> Subject: [PATCH v4 00/11] Rework API for RSA algorithm in asymmetric
> crypto
> 
> Split into smaller commits, in order from least disputable ones.
> Open things beside this:
> 1. Creating padding struct
> 2. Padding parameters (seedlen, optional label etc) 3. Leading zeroes
> questions.
> 4. Random number requirements.
> 5. Capabilities.
> 6. Verify signature field when none padding.
> 
> v4:
> - change API comments from length -> array allocation to avoid ambiguity
> 
> v3:
> - split into smaller patches
> - removed padding struct changes
> - rebased against patches from CRT patches from Ayuj Verma
> 
> v2:
> - Field for singature verification when padding none selected was added
> - Removed details from RFC
> - Simplified padding struct
> - Added padding none test case
> 
> This patchset depends on following patches:
> [1]
> test/crypto: move rsa enqueue/dequeue into separate functions
> (http://patchwork.dpdk.org/patch/56342/)
> [2]
> test/crypto: add tests for RSA key type CRT
> (http://patchwork.dpdk.org/patch/56343/)
> 
> Arek Kusztal (11):
>   cryptodev: change RSA API comments about primes
>   cryptodev: add cipher field to RSA op
>   crypto/openssl: add cipher field to openssl RSA implementation
>   test: add cipher field to RSA test
>   cryptodev: add information about message format when signing with RSA
>   cryptodev: remove RSA PKCS1 BT0 padding
>   openssl: remove RSA PKCS1_5 BT0 padding
>   test: remove RSA PKCS1_5 BT0 padding from test cases
>   cryptodev: add RSA padding none description
>   test: add pkcs1_5 padding simulation
>   test: add RSA PKCS1_5 padding case when no padding selected
> 
>  app/test/test_cryptodev_asym.c           | 53 ++++++++++++++++++++------
>  app/test/test_cryptodev_asym_util.h      | 54
> +++++++++++++++++++++++++++
>  drivers/crypto/openssl/rte_openssl_pmd.c | 12 +++---
>  lib/librte_cryptodev/rte_crypto_asym.h   | 64
> ++++++++++++++++++++++++--------
>  4 files changed, 149 insertions(+), 34 deletions(-)
> 
> --
> 2.1.0

Series-acked-by: Damian Nowak <damianx.nowak@intel.com>