From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 5C57D1B440; Mon, 22 Oct 2018 22:34:11 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id DD4D22206E; Mon, 22 Oct 2018 16:34:10 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Mon, 22 Oct 2018 16:34:10 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=G2a+seeanKl4UYsPBYPtfR+jr9Hp8tQixizIe8j0y6Q=; b=b2yc3njk9uJg q3oSidN8+qAqqatVIGqG9A0wU/O3wX+anrdrJStkFyTHBgJseWswMbCWuHQGLYsa SixKDl1LIkcjtsVLiIHIkilP5+PhabqpSkJX+LvGA5eJkpgo5e2cct0mr4Qb9nrV 61Bn6n9JFB1nb8CBVeY0xjevcula+40= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=G2a+seeanKl4UYsPBYPtfR+jr9Hp8tQixizIe8j0y 6Q=; b=sFf2QpunnuTwFB4v9zLERibxULh9EwlY9/Cj/4idBKL8SmNVqTjGWm3Xb e3A6VTvDSmsHn4UVYYolr+HYWePqr+gIeVY5rgcp775xbT5MaenynNkhJE3GRLiZ KYTfoBpY5FLjHAAyNQqwBuXiL32RUT6bNb5bfPVPOoBGcGZAkOvDx1ucu+gBPKFJ Z1PeU+Pa09N12BuEQByn0g0ZFI6Wufu0yd/T6DzDZFi9k6TZNbJToCoqTPn8BAUc i4VQXClJI23oEEC2BaE9/vF5GQL7ScAG4FgBMkqcPvaQduhAv21GjqzOW778ZMeB 1FFjycqaEWNhjKNU97DiQFi7+ptKA== X-ME-Sender: X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id F3F53102ED; Mon, 22 Oct 2018 16:34:09 -0400 (EDT) From: Thomas Monjalon To: Anatoly Burakov Cc: dev@dpdk.org, stable@dpdk.org Date: Mon, 22 Oct 2018 22:34:12 +0200 Message-ID: <6977287.CUEHYN7lHI@xps> In-Reply-To: <9183826f1b6f3bb3d80cdde12fbd59f07f4df348.1540212745.git.anatoly.burakov@intel.com> References: <9183826f1b6f3bb3d80cdde12fbd59f07f4df348.1540212745.git.anatoly.burakov@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] mem: fix resource leak X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 22 Oct 2018 20:34:11 -0000 22/10/2018 14:57, Anatoly Burakov: > Segment preallocation code allocates an array of structures on the > heap but does not free the memory afterwards. Fix it by freeing it > at the end of the function, and changing control flow to always go > through that code path. > > Fixes: 1dd342d0fdc4 ("mem: improve segment list preallocation") > > Coverity ID: 323524 > > Cc: stable@dpdk.org The right order for these tags is: Coverity issue: 323524 Fixes: 1dd342d0fdc4 ("mem: improve segment list preallocation") Cc: stable@dpdk.org > Signed-off-by: Anatoly Burakov > --- > > Notes: > Not sure if stable release script picks up fixes for commits intended > for stable releases? What do you mean? Is this patch for master? The process is to Cc: stable, then it is backported. The script check-git-log.sh helps you to correctly set Cc: stable tag.