* [dpdk-dev] [PATCH] net/bonding: set slave MAC addresses correctly
@ 2017-12-28 2:12 Chas Williams
2018-01-09 16:15 ` Doherty, Declan
0 siblings, 1 reply; 3+ messages in thread
From: Chas Williams @ 2017-12-28 2:12 UTC (permalink / raw)
To: dev; +Cc: declan.doherty, Chas Williams
From: Chas Williams <chas3@att.com>
Use rte_eth_dev_default_mac_addr_set() to change a slave MAC address.
mac_address_set() only updates the software copy and does nothing to
update the hardware.
Signed-off-by: Chas Williams <chas3@att.com>
---
drivers/net/bonding/rte_eth_bond_api.c | 2 +-
drivers/net/bonding/rte_eth_bond_pmd.c | 10 ++++++----
2 files changed, 7 insertions(+), 5 deletions(-)
diff --git a/drivers/net/bonding/rte_eth_bond_api.c b/drivers/net/bonding/rte_eth_bond_api.c
index 703bb39..532683b 100644
--- a/drivers/net/bonding/rte_eth_bond_api.c
+++ b/drivers/net/bonding/rte_eth_bond_api.c
@@ -453,7 +453,7 @@ __eth_bond_slave_remove_lock_free(uint16_t bonded_port_id,
&rte_eth_devices[bonded_port_id].data->port_id);
/* Restore original MAC address of slave device */
- mac_address_set(&rte_eth_devices[slave_port_id],
+ rte_eth_dev_default_mac_addr_set(slave_port_id,
&(internals->slaves[slave_idx].persisted_mac_addr));
slave_eth_dev = &rte_eth_devices[slave_port_id];
diff --git a/drivers/net/bonding/rte_eth_bond_pmd.c b/drivers/net/bonding/rte_eth_bond_pmd.c
index d1d3663..02688f7 100644
--- a/drivers/net/bonding/rte_eth_bond_pmd.c
+++ b/drivers/net/bonding/rte_eth_bond_pmd.c
@@ -1511,7 +1511,8 @@ mac_address_slaves_update(struct rte_eth_dev *bonded_eth_dev)
case BONDING_MODE_BALANCE:
case BONDING_MODE_BROADCAST:
for (i = 0; i < internals->slave_count; i++) {
- if (mac_address_set(&rte_eth_devices[internals->slaves[i].port_id],
+ if (rte_eth_dev_default_mac_addr_set(
+ internals->slaves[i].port_id,
bonded_eth_dev->data->mac_addrs)) {
RTE_BOND_LOG(ERR, "Failed to update port Id %d MAC address",
internals->slaves[i].port_id);
@@ -1529,15 +1530,16 @@ mac_address_slaves_update(struct rte_eth_dev *bonded_eth_dev)
for (i = 0; i < internals->slave_count; i++) {
if (internals->slaves[i].port_id ==
internals->current_primary_port) {
- if (mac_address_set(&rte_eth_devices[internals->primary_port],
+ if (rte_eth_dev_default_mac_addr_set(
+ internals->primary_port,
bonded_eth_dev->data->mac_addrs)) {
RTE_BOND_LOG(ERR, "Failed to update port Id %d MAC address",
internals->current_primary_port);
return -1;
}
} else {
- if (mac_address_set(
- &rte_eth_devices[internals->slaves[i].port_id],
+ if (rte_eth_dev_default_mac_addr_set(
+ internals->slaves[i].port_id,
&internals->slaves[i].persisted_mac_addr)) {
RTE_BOND_LOG(ERR, "Failed to update port Id %d MAC address",
internals->slaves[i].port_id);
--
2.9.5
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [PATCH] net/bonding: set slave MAC addresses correctly
2017-12-28 2:12 [dpdk-dev] [PATCH] net/bonding: set slave MAC addresses correctly Chas Williams
@ 2018-01-09 16:15 ` Doherty, Declan
2018-01-10 20:36 ` Ferruh Yigit
0 siblings, 1 reply; 3+ messages in thread
From: Doherty, Declan @ 2018-01-09 16:15 UTC (permalink / raw)
To: Chas Williams, dev; +Cc: Chas Williams, Ferruh Yigit
On 28/12/2017 2:12 AM, Chas Williams wrote:
> From: Chas Williams <chas3@att.com>
>
> Use rte_eth_dev_default_mac_addr_set() to change a slave MAC address.
> mac_address_set() only updates the software copy and does nothing to
> update the hardware.
>
> Signed-off-by: Chas Williams <chas3@att.com>
> ---
...
>
Acked-by: Declan Doherty <declan.doherty@intel.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [PATCH] net/bonding: set slave MAC addresses correctly
2018-01-09 16:15 ` Doherty, Declan
@ 2018-01-10 20:36 ` Ferruh Yigit
0 siblings, 0 replies; 3+ messages in thread
From: Ferruh Yigit @ 2018-01-10 20:36 UTC (permalink / raw)
To: Doherty, Declan, Chas Williams, dev; +Cc: Chas Williams
On 1/9/2018 4:15 PM, Doherty, Declan wrote:
> On 28/12/2017 2:12 AM, Chas Williams wrote:
>> From: Chas Williams <chas3@att.com>
>>
>> Use rte_eth_dev_default_mac_addr_set() to change a slave MAC address.
>> mac_address_set() only updates the software copy and does nothing to
>> update the hardware.
>>
>> Signed-off-by: Chas Williams <chas3@att.com>
> Acked-by: Declan Doherty <declan.doherty@intel.com>
Applied to dpdk-next-net/master, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-01-10 20:36 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-12-28 2:12 [dpdk-dev] [PATCH] net/bonding: set slave MAC addresses correctly Chas Williams
2018-01-09 16:15 ` Doherty, Declan
2018-01-10 20:36 ` Ferruh Yigit
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).