From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id D5F101B1A5 for ; Wed, 3 Jan 2018 09:17:38 +0100 (CET) Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 263308046A; Wed, 3 Jan 2018 08:17:38 +0000 (UTC) Received: from [10.36.112.30] (ovpn-112-30.ams2.redhat.com [10.36.112.30]) by smtp.corp.redhat.com (Postfix) with ESMTPS id BAB19619B4; Wed, 3 Jan 2018 08:17:34 +0000 (UTC) To: Stefan Hajnoczi Cc: dev@dpdk.org, Yuanhan Liu , Tetsuya Mukawa References: <20180102093136.28690-1-stefanha@redhat.com> <20180102181141.GC22252@stefanha-x1.localdomain> From: Maxime Coquelin Message-ID: <698ad293-18d8-30c6-eae7-df5e1bd2b64c@redhat.com> Date: Wed, 3 Jan 2018 09:17:32 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: <20180102181141.GC22252@stefanha-x1.localdomain> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.28]); Wed, 03 Jan 2018 08:17:38 +0000 (UTC) Subject: Re: [dpdk-dev] [PATCH v2 0/2] vhost: introduce rte_vhost_vring_call() X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 03 Jan 2018 08:17:39 -0000 On 01/02/2018 07:11 PM, Stefan Hajnoczi wrote: > On Tue, Jan 02, 2018 at 11:27:02AM +0100, Maxime Coquelin wrote: >> Hi Stefan, >> >> On 01/02/2018 10:31 AM, Stefan Hajnoczi wrote: >>> v2: >>> * Add internal vhost_vring_call() helper function [Maxime] >>> >>> These patches eliminate code duplication for vhost_virtqueue->callfd users by >>> introducing rte_vhost_vring_call() (public API) and vhost_vring_call() >>> (librte_vhost-internal API). >>> >>> Stefan Hajnoczi (2): >>> vhost: add vhost_vring_call() helper >>> vhost: introduce rte_vhost_vring_call() >>> >>> lib/librte_vhost/rte_vhost.h | 15 +++++++++++++++ >>> lib/librte_vhost/vhost.h | 12 ++++++++++++ >>> examples/vhost/virtio_net.c | 11 ++--------- >>> examples/vhost_scsi/vhost_scsi.c | 6 +++--- >>> lib/librte_vhost/vhost.c | 21 +++++++++++++++++++++ >>> lib/librte_vhost/virtio_net.c | 23 +++-------------------- >>> lib/librte_vhost/rte_vhost_version.map | 7 +++++++ >>> 7 files changed, 63 insertions(+), 32 deletions(-) >>> >> >> I just wonder whether tagging the new API as experimental is needed, >> but apart from that it looks good to me: >> >> Reviewed-by: Maxime Coquelin > > From 3.2. Managing ABI updates, General Guidelines: > > New APIs will be marked as experimental for at least one release to > allow any issues found by users of the new API to be fixed quickly. > > http://dpdk.org/doc/guides/contributing/versioning.html > > I'm new to DPDK so I followed this guideline strictly and expect the > maintainers to mark the API stable at some point in the future when they > are happy with it. Maybe this guideline isn't followed strictly for > librte_vhost? Thanks for the pointer, it seems it is not strictly followed for librte_vhost & other libs. Let's keep it experimental for the coming release. Maxime > Stefan >