From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 931C845CFB; Thu, 14 Nov 2024 01:55:41 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 83773402A1; Thu, 14 Nov 2024 01:55:41 +0100 (CET) Received: from szxga05-in.huawei.com (szxga05-in.huawei.com [45.249.212.191]) by mails.dpdk.org (Postfix) with ESMTP id 24FC54025F for ; Thu, 14 Nov 2024 01:55:38 +0100 (CET) Received: from mail.maildlp.com (unknown [172.19.162.112]) by szxga05-in.huawei.com (SkyGuard) with ESMTP id 4XphVK3hk7z1jycw; Thu, 14 Nov 2024 08:53:45 +0800 (CST) Received: from kwepemk500009.china.huawei.com (unknown [7.202.194.94]) by mail.maildlp.com (Postfix) with ESMTPS id 1D24B140257; Thu, 14 Nov 2024 08:55:36 +0800 (CST) Received: from [10.67.121.161] (10.67.121.161) by kwepemk500009.china.huawei.com (7.202.194.94) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.11; Thu, 14 Nov 2024 08:55:35 +0800 Message-ID: <69aafae6-021b-481d-9b35-b07469f00ad9@huawei.com> Date: Thu, 14 Nov 2024 08:55:35 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC 3/5] bus/uacce: remove memset before free To: Stephen Hemminger , References: <20241113185720.28706-1-stephen@networkplumber.org> <20241113185720.28706-4-stephen@networkplumber.org> Content-Language: en-US From: fengchengwen In-Reply-To: <20241113185720.28706-4-stephen@networkplumber.org> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.67.121.161] X-ClientProxiedBy: dggems702-chm.china.huawei.com (10.3.19.179) To kwepemk500009.china.huawei.com (7.202.194.94) X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 2024/11/14 2:56, Stephen Hemminger wrote: > Doing memset before free maybe removed by compiler, and > is flagged by security scanning tools as potential problem. > In this case the memset is unnecessary. > > Signed-off-by: Stephen Hemminger > --- > drivers/bus/uacce/uacce.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/bus/uacce/uacce.c b/drivers/bus/uacce/uacce.c > index c1529c38c0..35c1027245 100644 > --- a/drivers/bus/uacce/uacce.c > +++ b/drivers/bus/uacce/uacce.c > @@ -454,7 +454,6 @@ uacce_cleanup(void) > dev->device.driver = NULL; > > free: > - memset(dev, 0, sizeof(*dev)); It should replaced by TAILQ_REMOVE(&uacce_bus.device_list, dev, next); And I also find other bus have the same problem, later I will push one patchset. > free(dev); > } >