From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1F6244582E; Wed, 21 Aug 2024 11:39:37 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E06CE40E44; Wed, 21 Aug 2024 11:39:36 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.12]) by mails.dpdk.org (Postfix) with ESMTP id 468024003C for ; Wed, 21 Aug 2024 11:39:34 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1724233175; x=1755769175; h=message-id:date:subject:to:cc:references:from: in-reply-to:content-transfer-encoding:mime-version; bh=8wqY8iPKmVtvnLHqhiEvqgyBpHVILrzRdxekKaUdRaQ=; b=d44jbwADpZFp5KqOvMbpLaitzSDYCHpOksLQTNrAiXy72uhiOHtw77VB CE5VCCekgozdl4kqaCHKbcn8MBfOVoRTe3UBPx9WxaXsyDr29H/XlmiXL ixEQssQ2Z7fvRM6cxkBsex0w1tetf+7ILVGxhyCXJE2dKqqe1j6Ovur3Y AxUsqlv+fI7cwbfOotkHKz0Y+caragZPJsIwHiqQRJKmMHQTaFQxyJjPL AKrtxYcnwgX/NaTzrXJfRjyxgYZoXv4uwnyRzOJmqBxRXiFM6jTx9eqXr uLen6Ng2co4NBDjGqf65N+dD5rXTdaLa+jS7xNhXI2YnwBGLM/bb8Nsss g==; X-CSE-ConnectionGUID: MQHp9Ue8R52Vb+CBelbh+Q== X-CSE-MsgGUID: irv3B6lISw+oSdXSHJGN9Q== X-IronPort-AV: E=McAfee;i="6700,10204,11170"; a="26449651" X-IronPort-AV: E=Sophos;i="6.10,164,1719903600"; d="scan'208";a="26449651" Received: from fmviesa002.fm.intel.com ([10.60.135.142]) by fmvoesa106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Aug 2024 02:39:28 -0700 X-CSE-ConnectionGUID: MkGc7ZsZRv2jnHl6eBtr4Q== X-CSE-MsgGUID: I5zrghXkTCOKXtg0gcM5zw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.10,164,1719903600"; d="scan'208";a="84218748" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by fmviesa002.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 21 Aug 2024 02:39:28 -0700 Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Wed, 21 Aug 2024 02:39:27 -0700 Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Wed, 21 Aug 2024 02:39:27 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39 via Frontend Transport; Wed, 21 Aug 2024 02:39:27 -0700 Received: from NAM02-DM3-obe.outbound.protection.outlook.com (104.47.56.46) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Wed, 21 Aug 2024 02:39:26 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=X0q8pHhm3bPU+fB1DTF2ap9yIxAW2AwpgrYf8S/C5tuSdfGVWhicCgGFzAtWbDcwC0zsv+A28FkJC3wOuBcMa6MX1vr0scXQpX0+DXutuJ8YLY+/fmt2G6t9k1uDg0dfsijoo3LpsibREFJgYeEgSh9IaQxAnv+vM2XHATl18fRKYIlHMwuG7n6l8yAFBTo2V967E0+q1Bx+uacr72/sGVA24jAmF9mSdenfKYs/jtCzeiCl9eybYUi+xxSj9YTQAjLlifC7vZOvder5hHCzpELKsr6k0so5ndKjyWQRePVPRAhVg2DBL1UT0d6Ma8cwlMXC/ckrqV/qZ0tWhtshQA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=d/cdmjYbjJxuzppIO2y0a5DPpQGTBGQffCJ++IMl1Hc=; b=a9utambuFR7TXaluTJ5ylZiOG00WAIoF5IMbcfYnlRBjJnaJAmPtjHLuQxt579ptuEcPrMDaLScQVU1cjl0S7q6ue7+izIcUkodXn0Js+c6S7xBc68nbxGe5vZwemN7+pZKPlRLroQFmc8+/nBp5FnqPwdcgyy6+msDWbZNQgv5t7b/Izv0fsjXecAEjRlPrNGSADGAy1o91dv/cW3ThAb4XwyqwjR/SRdbKaCklh8FDp67eOnqyZ/0uovQ+wWSPMJzg+DqfA4sM4/Ab5Yd0gtKnidhOwfiX+HdAXWEOOSKuGSuOIK6hRml0uJaY2E9zMuegYqO/hsT5uMtmICNI6g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DM4PR11MB6502.namprd11.prod.outlook.com (2603:10b6:8:89::7) by IA0PR11MB7742.namprd11.prod.outlook.com (2603:10b6:208:403::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7875.21; Wed, 21 Aug 2024 09:39:20 +0000 Received: from DM4PR11MB6502.namprd11.prod.outlook.com ([fe80::21e4:2d98:c498:2d7a]) by DM4PR11MB6502.namprd11.prod.outlook.com ([fe80::21e4:2d98:c498:2d7a%4]) with mapi id 15.20.7897.014; Wed, 21 Aug 2024 09:39:19 +0000 Message-ID: <69b1214c-72b9-41fc-a06b-9fbf5d7f974a@intel.com> Date: Wed, 21 Aug 2024 11:39:12 +0200 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 3/4] usertools/dpdk-hugepages.py: update coding style To: Robin Jarry , CC: , Stephen Hemminger References: Content-Language: en-US From: "Burakov, Anatoly" In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: DUZPR01CA0276.eurprd01.prod.exchangelabs.com (2603:10a6:10:4b9::25) To DM4PR11MB6502.namprd11.prod.outlook.com (2603:10b6:8:89::7) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM4PR11MB6502:EE_|IA0PR11MB7742:EE_ X-MS-Office365-Filtering-Correlation-Id: 1295f017-5923-4dfa-3c55-08dcc1c52121 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|376014|366016; X-Microsoft-Antispam-Message-Info: =?utf-8?B?RHBZcmIxN3dISXdpbkJna0ZiR0VETXdsOElaamhIVDc5L0RGU3pSSVJ2aVhq?= =?utf-8?B?TmhUTDY1aVowMEVTeHZ5NVNRaHA0YTg4aDdyNkVYV2ZXUHBKZDN4Q0JrWk0w?= =?utf-8?B?bTdUTVY4ellSVU84Y0syRTBYOU5hMG5vdERTRC9jdlpvZW1sNDV4VGpBSmdz?= =?utf-8?B?RTMvSHVUb2ptNG9BbUFXSnZLaU9vLzJiVmJjYnRyWUUwOUc0YmtOQ3F4WXhL?= =?utf-8?B?dE9Ja2hPU0tEL3VrbWYvVTN3dGlsaWM2THZpS0xyVndFYUxoS2FnMm50RFdp?= =?utf-8?B?N0ZmYnFGZUx2T2FIc0RUWkZlS3NsYTY0TEUvMy9GOUtVeHBDZHNERVFkZkdm?= =?utf-8?B?OGhKWnBDclh6SDB6Um1WR2c2VEFXdDJvUzIxUTFKaDcxZ2E0dm5ELzhPSUtH?= =?utf-8?B?dDZBeHVuN3Y5VmFsQS9NTjNXUzVpLzRqcTh6VGZ0OFhCbTY1UGZjSUhTOWlr?= =?utf-8?B?K3g1cWdGbkpTb3ByMVdIQXJVTTJDekdZYkI2Q1N4VzZYU2hRc01LaUJLRUIw?= =?utf-8?B?ZE83N3FtT3NabG9MRUc1ZldqdEJKejdWQldUVUo5VWd4cnlqTEUxY1Ezc003?= =?utf-8?B?ZkkxaTdUSHpLY084N3VqN3BBRVFhYitzQS9XMXFCN0w4Zk82N2hEanNZcHRL?= =?utf-8?B?SkRCSS9iQURtUENUYnBVbUo2dW5tMWJyZTRHZVp4S2FrTEV3Y0VNUENtb0Vy?= =?utf-8?B?bWZIdjA3TTAwbjBwbUVkMGxXQVgzOFJoMGdzYnhNREZjaFRmVC91ejJIaDJW?= =?utf-8?B?Z2o0amZBeGpSWmpSdUl4OS8rQWFodS9iRHRhbkRnVm4wUU9uek9hMzNvMms2?= =?utf-8?B?N3gzNEd5MmQxTnhPNzFCLzdva3NpYS9BV3RCQ1lwVnJJY2JLWlNRWUlOeVNp?= =?utf-8?B?bUg2em5yT1lyM21JVkEvQjJFNDhQL2hINDRLUGFBeHQveHczOE5uTVJ1azhq?= =?utf-8?B?bTZJVmxzZUFmM0thR01aTS9pa0tYZmZoVU9ybElQck1hZi9rWUpDc0dMUWNZ?= =?utf-8?B?Vm41T25INGg4dEtpUmo0MXBFV3pWbnNVZyszK2hMSmRvYndjRTBvN1k1dmZv?= =?utf-8?B?UFRWNG5yYUtkVDFYS2YyaGlJVFl2ZjdtbTFRRmhTNEhoak5leUxVRlFleGVI?= =?utf-8?B?dGVKVWVVRWswaHJiWlI2UDlWRmNKTGlGTXk3SER2R0N1R2pYRHJBQnhVQmlp?= =?utf-8?B?MG5ObmFLWFRvbnJwa21UTlZ5UGVYNzRqbS9Ka1MwL2l4c1JzeXFxdW5OZHVO?= =?utf-8?B?aStuRFN1Q1pwODZubzl3MWQ1MkFsbi8xMmI4d1dMYjdTcHFDRm1xYW9xUEdE?= =?utf-8?B?aWJZS1R0bSt6TWtBRWxaVzVwa05FQlpQQS9DanAzYVRrbVNzVmFDYzByV3Ro?= =?utf-8?B?YnZGOERDZ2FFbDZ2TU1reG1PTjRLd2p4dGU3N1IrM2NwVmQ3SFdCd1RxbC9R?= =?utf-8?B?RHg1Snc1b0l1THJNbWFpZzNVWFRrRFRFTkdXclJJU0JBeFltNjVXb2NORzBU?= =?utf-8?B?dVNOcERtby9oa1dTZ1FMaHJpTm5xcUgxRVI3enpna1lERWJ1cllvZEY3ZHdF?= =?utf-8?B?YXA1KzY2aVVCSGZZeGJ5eWROWVBZNzBQV29XQUlDZmhUMkpQdkZ1SXZKajlw?= =?utf-8?B?T1pVWFRnVkgzcDBOdXkyNTRMU2dRS3AzVzRHc0NDU21wV0t5eFZ1enp5c0FW?= =?utf-8?B?Z290TFBCbE1RQSsyakdlM2s2eVBydW0yNzMxejltT0MvcXBoMlZUcTVoc21S?= =?utf-8?B?cVpRU3ZHNi9OYVg4QzRIUU42NGlHUVNuSjlPSy9FSkFhd3J0dlkyTnVVTHdQ?= =?utf-8?B?VU9scE5maC9CQmwxYUZnQT09?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM4PR11MB6502.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(1800799024)(376014)(366016); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VHl6QUJkUHMvVmhpbFNIMWxjaXNid3oyQVhUSkl5U3pRU1FUVXhMVTBIeit6?= =?utf-8?B?SGYvQmkram9xR2VRdkZDQTNpZGtsMHJpa0RuTG9kSUdjaFNGL1pLMG5nUHRK?= =?utf-8?B?a01BTUNuemZocjJJR0VJZWZJa0xRWnVYVlNoMlVzby9zMVR4dzcrUVozeGxp?= =?utf-8?B?eDE3VDM0bXFWVHh1YXQ3N0lYTExLZEN2UDNvQnNRS1dGNmpvNFk5ZUNMM0hh?= =?utf-8?B?VFlkVVpmWGRkd3E4UjBsQlptc3Y0RkRtSnNEMnpZc2M3bHE5NTl0dmxIWjVa?= =?utf-8?B?UzVrcHJhUTR6NU96WWh3M1llcUVuYjBFL0VxbHJabjhIOVhpRzhnMDhQSnNB?= =?utf-8?B?OEtPaVJ4UUkxM1J2WFJ6SU83Ym45N0Q5ZHIwY2NLTWp4YldPWk1QQ3l6K2V0?= =?utf-8?B?RUlUa1ZJWXRFMFVHNHUxcEhNc0YvQWkxaWJ3UHVEL1hMLzBUKzZ1SWZaYVdj?= =?utf-8?B?Tit5U1I5RjhweXY3Q2Q4aW8rOEczandtb2FCQUxqTnVRQWJpcXh4a1NTb2ZI?= =?utf-8?B?N2FTOWNZckc3Uy94eWFYaHNSak9tS1k5cW5qUlhVcDBFbDNMakpRaXpqRm1z?= =?utf-8?B?aWdvSUtPUlNmenIvN1VMUUtxMTlpVklIMUtCSk1sdGFwM3kxMk1jUUxmYUdH?= =?utf-8?B?bzhYbGhzWUVJTXIyaE9LTUFVeFdDd2xqMk9tRHhPUDM2SEY1dmlIa3YvRTFG?= =?utf-8?B?MWt0eUtXNitTMkZXMUNkOU4raUlicm9jSm52SEZwbW1haG5NWmt5bHNqcWdI?= =?utf-8?B?cS90c1ZjK1hEZ2ZueE5vVm03QTA2VzZuTmFTZVdrL0RjeUtNK2dvSUdSYjEr?= =?utf-8?B?eDk2bXBnbmlSeEh4NVhhQUZweVRqYi84Z3Y5bEN5UzVNM05tbXpUSGZUMnZw?= =?utf-8?B?S3A3MUdRcFIzakxSUXNiNi8wV2RXK2RxU29uR0JHRit3aUl1dnZQUCtIYmJI?= =?utf-8?B?dFVMdUplRkhMZjlKci9mYXIvL2RMRE85NnVRN3g5T01jeGt6aXg3TzRLY2hs?= =?utf-8?B?dW95dHl2c1oyUlpaOE9VMmJSYnk4T0lrV3BTTktLSlM4VFc3R2VUYXl5Rk54?= =?utf-8?B?NkQ1L2Q4RFF6T29QWmZIMTBubHM3REc1WnhQY2VnNzhwQWRnVjR6SUU4eFlW?= =?utf-8?B?NUVPZlJ3V0E0cEFBeUtJK1hwRkNNYjFXTGFnY1F5OXZCcndHcTFvYzJHWU1m?= =?utf-8?B?ZGp3RVUvekRXV1JFVVR4STFNckVyRGlkUFBzeWpJelZzVEEzRFpsK1BXcGdo?= =?utf-8?B?K28zeW9Ea2swZ2VkMlhSemE4WmNSSXNkTVVGUlVMNnIrZUFLa0lYeHZCbTZB?= =?utf-8?B?VnMvb09VNTh4Y1ZSeEU2TW9rV0p0anlsQ0dXZVdKQ2JMbllBYjBmYUw4MFZv?= =?utf-8?B?RnZ0dVVIT3NkQ3FYeGFkVmQyVDBuWmJtNUJGZ0NUb1FpUkVMWXRpU1Vob1B2?= =?utf-8?B?QjB3OGlWVk1WbUt1SjNjZXYxRlhzRlhFUzJoSmxVUUZHOHBJT2xqR1QzNlJD?= =?utf-8?B?VjN5M3BkQkc3UU5VamxXc0p2WkNRbks4aWlSWGlCaUlIYjdFcmd2bmlSMC9S?= =?utf-8?B?R3VaV1AzVnZtQXkvK09hWmFvYVhXa1BWdlM5RGJzMllsN0dTWnd6cUVyL1lk?= =?utf-8?B?aTVuNFpPOTRic2xHeEd5TnpvS0M4azJyckFEeXRWVW5LdksvcDdnUFZ5VHRh?= =?utf-8?B?dGVxY1h3NmJQOWgxQUt1a3NrRzhSM0M1ZkpUUTc3SWtVdWxLQWpKS0RWdVA5?= =?utf-8?B?WGkvaExtY2tvYXZXL2gvWXhRbENIYlA1aW5HZVFHV3oyZ0FTMU9iZCtHZTlC?= =?utf-8?B?bXBtU0pEczd1N3NubDd5RkNaZ1JyMGpTL0dIbEVYNG9kZ2I0WFhDQlhmSHVh?= =?utf-8?B?WndJWkl5VmlTd0ZnRWJqazA2c0FJR2tQbWRSMzR1Rmt5UmlWVFBNQnQ1K1Ez?= =?utf-8?B?NTBPMXRTNjBGVk9kTTZWWVlCNXZiZzZTeDhHZjJyREd1SkFJMHRhWW82WjhI?= =?utf-8?B?OG5Ob0d0TElYR3VpcVVKVFBkVTkzOGpKRWMzbUdoOFVHaDltTUVTR2tya1lL?= =?utf-8?B?T3hUbjVDYVpQZUp1c3phc2tBOUh5dkphR2VWTmltR2FWaGRxN2Q3UUhzL3R3?= =?utf-8?B?L0ZSWk9CWGZQWjBDeFBpd0lPdWpURHR5d0FUbGQwTzR0b1MvUjFzcTkyVUFG?= =?utf-8?B?NVE9PQ==?= X-MS-Exchange-CrossTenant-Network-Message-Id: 1295f017-5923-4dfa-3c55-08dcc1c52121 X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB6502.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Aug 2024 09:39:19.0696 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: J512BHX9vLf3IJ2CyFNhvmTf1sEM53sib7eXpZ3QsX3Dm+l+MAoEdKN9Pjw4bMRFHRo73h66Gan7zkIgdhC231zTJtn/YC6Ya/hYvP60g7s= X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA0PR11MB7742 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 8/21/2024 11:26 AM, Robin Jarry wrote: > Anatoly Burakov, Aug 21, 2024 at 11:22: >> Update coding style: >> >> - Make the code PEP-484 compliant >> - Add more comments, improve readability, use f-strings everywhere >> - Address all Python static analysis (e.g. mypy, pylint) warnings >> - Format code with Ruff >> - Improve error handling >> - Refactor printing and sysfs/procfs access functions >> - Sort output by NUMA node >> >> Signed-off-by: Anatoly Burakov >> Acked-by: Stephen Hemminger >> --- >> >> Notes: >>     v3 -> v4: >>       - Format code with Ruff, line width 79 to avoid flake8 warnings >>         (Flake8 is by default configured with line width 79 on my system) > > Please keep the default ruff/black settings. And when formatting with > these tools, flake8 is mostly useless. > > If you want to check your code for defects, you are probably best with > `ruff check` which combines the features of multiple python linters and > runs much faster. OK, I'll reformat with default settings then! v5 incoming > > >>     v2 -> v3: >>       - Rewrite of the script as suggested by reviewers >>     v1 -> v2: >>       - Added commit that sorted output by NUMA node > -- Thanks, Anatoly