From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 48DDDA0C4E; Tue, 2 Nov 2021 11:43:56 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2F19640689; Tue, 2 Nov 2021 11:43:56 +0100 (CET) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by mails.dpdk.org (Postfix) with ESMTP id BC3094003F for ; Tue, 2 Nov 2021 11:43:54 +0100 (CET) X-IronPort-AV: E=McAfee;i="6200,9189,10155"; a="228679799" X-IronPort-AV: E=Sophos;i="5.87,202,1631602800"; d="scan'208";a="228679799" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Nov 2021 03:28:11 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.87,202,1631602800"; d="scan'208";a="489042790" Received: from orsmsx606.amr.corp.intel.com ([10.22.229.19]) by orsmga007.jf.intel.com with ESMTP; 02 Nov 2021 03:28:10 -0700 Received: from orsmsx606.amr.corp.intel.com (10.22.229.19) by ORSMSX606.amr.corp.intel.com (10.22.229.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Tue, 2 Nov 2021 03:28:10 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx606.amr.corp.intel.com (10.22.229.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Tue, 2 Nov 2021 03:28:10 -0700 Received: from NAM02-SN1-obe.outbound.protection.outlook.com (104.47.57.49) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Tue, 2 Nov 2021 03:28:10 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JP3VcA4kr5lhL+Jmgy/hNkTUIXMtc6stkLOo+bbRY5XT9cvxQ6PTtMFQafRWZiOGapJ8bVYdCzdwFseymCYEqctzqnLugbWgHRaGFTY5dwOMwp96CX+XnqdQ+BCEaecOPTyK0MjGrq0gaoTBjR6AtesD+zm6KIobBtJpRZ9kOQ70c0UxR7ecEulArEeE9kZ+5qubDf9ii27UOaPzLO2QLtgfe/FtqyWlAB3hJEaJRIQ1MXB6njQFaijLeZTYLxVLih6GyUYXGpN6vlist/Y9HxUYkYMjSbg7Y+cxgNyIfUclmY2i42aQRUEiFhNq/cUhl6HkKe5owUlerr+QRai3WQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=7qIL/KLSy52ctSppNEU5gV51RVUhjWVJ5s4qs548TcY=; b=nXhLOczb3IbFlsVdk28ehxmU0j7E+7DDt0bf2DyoOn8J1SQAJCqA/Gl6/AsGRoxto5knjnjeVJ8IcgTbw7rBnhVycKK1ulqH7ZrxVG/1I4+AphA39K4zMqXIpC+zWutpkp/V417k9N78DBc8mpW/QRlOYxoN5Rg/u+zlm/xKDFI79lci0ayJiLPNwJxOByAZY8YEJ8dtjjUsuPcGP4J95iUxAnAZaQCkDpzZEXE0s0RwN8MYiyDuLTkhjOV5TYD5e/L7DI3H4Tf0rYdNehfFY6jt8mNzCW2hsX7GClMoR3Gab8mc3l33HxokxwovWCc51q46J2jyiJlgjLb6NxHC3w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=7qIL/KLSy52ctSppNEU5gV51RVUhjWVJ5s4qs548TcY=; b=pN0vxGuQpigd9AD4neWruV0QE8X07Ru6psPWp5+JkfvSJyyb85eGt6i/UueX7/oeHZbIoEYIh6kVqL9vCTRsRlhPMjuJizq9k3cgZMPdLXbmeqeLRV7vJ/RV11bOmp1464z8aAHkJ1C44WJRdk36e9iwiNLttMYFCClgJIMeko0= Authentication-Results: gmail.com; dkim=none (message not signed) header.d=none;gmail.com; dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by PH0PR11MB5046.namprd11.prod.outlook.com (2603:10b6:510:3b::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4649.14; Tue, 2 Nov 2021 10:28:09 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::bd7d:29be:3342:632c]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::bd7d:29be:3342:632c%5]) with mapi id 15.20.4649.020; Tue, 2 Nov 2021 10:28:09 +0000 Message-ID: <69b20079-c079-1d7b-a850-70de757c1343@intel.com> Date: Tue, 2 Nov 2021 10:28:02 +0000 Content-Language: en-US To: Jerin Jacob CC: Tomasz Duszynski , dpdk-dev , "Jerin Jacob" , Harman Kalra , "Nithin Dabilpuram" , Kiran Kumar K , Sunil Kumar Kori , Satha Rao , Jakub Palider References: <20211005074620.2224968-1-tduszynski@marvell.com> <20211022115625.1956708-1-tduszynski@marvell.com> <4832f0a8-67a4-ec48-30b6-01aa7d80ab1a@intel.com> From: Ferruh Yigit X-User: ferruhy In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: DU2PR04CA0071.eurprd04.prod.outlook.com (2603:10a6:10:232::16) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 Received: from [192.168.0.206] (37.228.236.146) by DU2PR04CA0071.eurprd04.prod.outlook.com (2603:10a6:10:232::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4649.14 via Frontend Transport; Tue, 2 Nov 2021 10:28:06 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 65b998be-f92f-4ca7-5e5b-08d99deb7707 X-MS-TrafficTypeDiagnostic: PH0PR11MB5046: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:7691; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: MXfQBluRdekpeqWY+b/VBj18OD8E+0jqKb+uuotd2SO9iXR9gTDkDrUnw73yp1sqBtpN+L4mxWs2V3U/b/ug4fIVVbvyODmZd2/7Ts/5uvmEp7VeMnlR2fJh3zV6MD18S2KP6rb/bEjzA5JY9iw5nO6znIMxUQ+pck6uRftcHtlvMdizljOt5K95BYARQmvySATanPsGsKMF8ZfmscYut6zgJArL5jaV/51YMkErKH82RD6wbQtRlY+eZE3PO3nfLaYwzBpreZW4eK+GMNYyf6bK+TEaB9vvA8TmXkKAyaUEoGJU1H9Mhxo4qo7BIvCaUaSmhdrR60kUz4y77QaiMCVEmaDv12xw+wwNpIlBMa8AOCqgbv4tz8u3aJTM1uFCy4St8xMo6xNtYuHTEaFClf0RM4rDSDDehiYZ0h8JxW517aT/SfFBtMHBnvA6YgsyFedOW0KRy2OTubQ8SiaWPhAwJbgr4Kt2jfGe0Mp2m//F3I8tZFsmFBlKw4HLKcFb5H9y9nWLi8tpMR0wS2CaS6WJVqnbR2qTnQhn7tKkChhEfFXnDD0u8b3/XvYD8thq/fHw/IGZJpjO5G2DS0eF+YXSOpRsKzgADjsxdDBF3rH25EuReiOuYXX1Ad2rnh6UTrWD6slHor7DGqo/7TOlRmmFV9wHmuLccs7yUWj+R/VbmwZv86/iyJEAPaCsWZORT5ZTW0D2dj7ShUeWWMNcNQ== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(44832011)(38100700002)(83380400001)(8936002)(186003)(82960400001)(956004)(2616005)(8676002)(6486002)(6916009)(53546011)(66946007)(31696002)(508600001)(5660300002)(26005)(316002)(16576012)(66476007)(66556008)(4326008)(31686004)(6666004)(7416002)(54906003)(36756003)(2906002)(86362001)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UWdkOUdOWGhSOGN5SDhQZGNyNzdSVFRjeHRtWGRHNjYzaVNhU3JILzhPZDRl?= =?utf-8?B?Y1VRZm1WTkZBNlZERUdQSzc1US9Ka1VqQlJ2R1RwbUtSeG5KbDBhMEczM21H?= =?utf-8?B?VlVzNWE4MS9maEhxek5YeUZzdHdzaGY0ekF2NU03OC93UDhCOUJubEJDQ2Y5?= =?utf-8?B?Q2FWY3gwSHRJZ0V5K0dyQ3Aya0ZuZUVHVCtDK2ZIOHpZUnBXd2JlcWwvUHhV?= =?utf-8?B?TjNZdlh4dkw0WTc2K2w2NWJWa3lqeDRrLzh4UHduUXhOeDh5QjMrVDJJUFZi?= =?utf-8?B?K1F1R212dmVIcHRjcXl1THp0SCtOTHFzM01pWUc0bHNWS2dQK1lRc0EyY0FZ?= =?utf-8?B?UEJubkxrcUxaWVNQVU05OWNkWGl0VDZacFdYbkNMY1BvdmlTU201R2E3Z3lq?= =?utf-8?B?NU53MFdJSUN4RGw4RkdkYmF3b254WTNaQ2lacWpQaXA3NVB0S09hZ0pQREtQ?= =?utf-8?B?N0J4bWFjVk92KzR4ODBWTk1rNFp6dXhRMDY5czJwUmZ3QWZNUGFhaEtydkds?= =?utf-8?B?VmlXUU5MeS9FUnRqRUZ6MXBGNlJFR0xFRDd1bkRlOERXSytZeGJZRkFoeW9Y?= =?utf-8?B?bVVISGJNcm9jMXlpLzNRTmRrTlpkOEZCdGxHRTBiby9JK0k4WVhKMnZRd0Rz?= =?utf-8?B?N1pKcFY3emdsZnQxU2hYcGptR3RaUXh1MnNlc3ViTzgyTUVLS0p0MEtZaUdk?= =?utf-8?B?d2ZOZHBIRGxpc3lIRkhrTFJuUGxCU1FSclJxVGM4blZ3VEwwMWFDNUxSc1F3?= =?utf-8?B?SE5CeENMb3NBMjBTR0J1dnRJQk53aTJNNldFREFwVGlOVzRwNERsaERkUW80?= =?utf-8?B?L2RrTmh5czgyV0g2bEtkamNMKy80bDNaNG51czFuWG05cE9mS3dnRHFnemh0?= =?utf-8?B?OVUyeGVBYzRQL2RUaTJ4QjZLdG1zb0R5a21xT1RPVGE0bk43dk9kL2MzbGIv?= =?utf-8?B?bi85R3NRd2l4U1ZuWTZFM1MxME1hNlBuU1E1NHdqU1RPU3c1MmwyajJGdS8x?= =?utf-8?B?ek1zSzFqVTYwL1hROUN0QklPOWhtalRJdys2WVFGalFHVG1rdHIyL0ZUeHFy?= =?utf-8?B?MTBHelJHSHRDd0dRanNESTNJRDR0U3AwZnV5Q2ZBV1QvNEE2T1FxMzdOcEcr?= =?utf-8?B?SS8wUVBjQkt3aTVKb2tBTll2Qk9pOVBXZ2tvTkR4dHhITGNnbkR3UkdKWFVD?= =?utf-8?B?aWwzNFQ2b2NEMVBIWklSRlo0OHZleHp6VmNKOW9td0xHUk5jWml0RUp1bjNB?= =?utf-8?B?Q1N5YWw1V3dhUmF3U2tnNFRsU0NIK0cwNVlxWUNLYzJsa1k0ZmlXeCtIZTVL?= =?utf-8?B?alc0N1loQTBrbHExMU5oNGdEclcvVkMrbmN1aUwwcWp4SnlhOGVUZGd4bXJz?= =?utf-8?B?SDZ1U3hpUVdiOTd0Wi9CVWdOMXE1TVZCdUdWZzA2MUlzUjE1VmNFUGU2Z204?= =?utf-8?B?dFZDYWsxL085UmtyS0w4cjRjVHJZU3VUUzkwUGxjVWtpY2dJb2xObDJiZCtF?= =?utf-8?B?aFYxN3E1bFNTZTViVHhZRlYzUVBPcFY4cDN4OE8wRituWk9FcXRZTVN0THc5?= =?utf-8?B?eXg4ei9mTmd3aTZZclViR3ZXZDNSRk0wWE9hNnlxKzlPQjFDMWl1OEZLTHhp?= =?utf-8?B?L0NyZk5pUVgzckdyNjNsbm1qbkxndDRUR1dDeUlFWllTYkpBTHRqeGtXNTBY?= =?utf-8?B?K09hMThyZWpYTlFHV3VRcy9GZWd3M25zek51WnE0aVZrSHA5NE1Fc0hyOHZq?= =?utf-8?B?VElqaWFOQnRTcUo2VHV5eEY1byt0YTJLaTVUYk10M3E0NmFjUVRpWW9IQ3NM?= =?utf-8?B?WlJnbG9rRDdxcVlzaEhKZlJKNnZhVngySWF6Z3B5S0NmaW1KcGlxSnkzdVho?= =?utf-8?B?YTY0OHJ1UWYxaGZ3OEk5c2c4ckdyV1cxSDJLSjl3MXRwRDYrRWNuUG5YVEJC?= =?utf-8?B?ZjBHYmpJUnlrR25INVVzN3BzdE9KWnF4L0dZTzVNSHB0aFNDOXhCM3U3TGJG?= =?utf-8?B?Z2pmbGE4RWxkUXY0YnBoWWJyOFFNak1EQVMrQTVsYkFRaHNHT0I5RDk4aTV3?= =?utf-8?B?b3IxenZwNFhna3B4ZHJqSlo0VzNvMS9Pc1dxODFMaGh5bGU3YzgzZGZ2QUgx?= =?utf-8?B?RmkxclI4aVlGQXIrdU1TUitKcXBJL1FLdmNoVGU2RXEvSkd1MkFmdmkrVytz?= =?utf-8?Q?nDuliOMXGwzpotvivVS7U2c=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 65b998be-f92f-4ca7-5e5b-08d99deb7707 X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Nov 2021 10:28:09.2330 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: +60j7cd5vbdzS0cobh5pqNpDL8rM0rBOBI1ymTklyyVRQvFwlwOHG7UPMYJJ47KxDv0xAUMEMhIAAaHM7snlng== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB5046 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v2] common/cnxk: support BPHY telemetry X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 11/2/2021 4:32 AM, Jerin Jacob wrote: > On Mon, Nov 1, 2021 at 8:32 PM Ferruh Yigit wrote: >> >> On 10/22/2021 12:56 PM, Tomasz Duszynski wrote: >>> Add initial support for baseband telemetry. >>> >>> Signed-off-by: Tomasz Duszynski >>> --- >>> v2: >>> - make bphy telemetry available only on platforms supporting baseband >>> - use platform types where possible >>> - remove unused header >>> >>> drivers/common/cnxk/cnxk_telemetry_bphy.c | 52 +++++++++++++++++++++++ >> >> Since the telemetry support is for 'raw/cnxk_bphy', why it is implemented >> in common code, instead of driver? > > It can be raw/cnxk_bphy, thought of keeping it in common due to > 1) To reuse it for another common code consumer Is it reusable, since the code is to get telemetry data from raw device? > 2) roc_bphy_sso_pf_func_get() and roc_bphy_npa_pf_func_get() manged by > common code. aka there is no reverse dependency on the raw driver framework > in common code. If telemetry code moved to raw driver, dependency will be from driver to common code, which is correct dependency order I think. It just looks wrong to have rawdev related telemetry function in the common code, but I may be missing details, trying to understand. thanks, ferruh