From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7506545EDB; Wed, 18 Dec 2024 12:18:06 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 577E340E32; Wed, 18 Dec 2024 12:18:06 +0100 (CET) Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.10]) by mails.dpdk.org (Postfix) with ESMTP id B0CDD4066E for ; Wed, 18 Dec 2024 12:18:04 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1734520685; x=1766056685; h=message-id:date:subject:to:cc:references:from: in-reply-to:content-transfer-encoding:mime-version; bh=Lqx0rzl7L/XUlz7r5a154v+VoO0xBNXxF0UCKZA4AY0=; b=PjFODu1gY5nYlk1q0vNac7Cp+qoYTYe8bILWHJbRVExCXJKSLUnR3EtO 5piRnx0nyN85UE5XGPQZQmlmk9ztWrPnqK7igX18EgZ0Tvnmz09MWb/QB 3h4OxkWF6SOfg7WtZyXeM++TlvhKNwqkicUWqJLFLXRMgqLIT9JmkYYg1 uujJdGflUU7h1yB7FjiW9UaVyS7bbq6w1A41lJmh7qTERYYW8JinlK9hr HjuplzyEn3aIipLqm78RTRCDD5kdTlPVhKtR9RSXvA2qfG1W+q3sLH9CJ SkyIWMRmu3iRjFX1fnV+LwsWhgr8EqfCNvUVIUVMc+t3fjCwzno37+wXk g==; X-CSE-ConnectionGUID: JM5+p7/rRfKCqN6/A5TF6Q== X-CSE-MsgGUID: DAfL9PL/TlWUvq8VNsJVyQ== X-IronPort-AV: E=McAfee;i="6700,10204,11289"; a="52399430" X-IronPort-AV: E=Sophos;i="6.12,244,1728975600"; d="scan'208";a="52399430" Received: from fmviesa005.fm.intel.com ([10.60.135.145]) by orvoesa102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Dec 2024 03:18:03 -0800 X-CSE-ConnectionGUID: rP2n0zLtTRyi71Somk7AuQ== X-CSE-MsgGUID: GWDq2X5oTO2JvHyBStfI3w== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.12,224,1728975600"; d="scan'208";a="102446334" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by fmviesa005.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 18 Dec 2024 03:18:01 -0800 Received: from orsmsx601.amr.corp.intel.com (10.22.229.14) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.44; Wed, 18 Dec 2024 03:17:59 -0800 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.44 via Frontend Transport; Wed, 18 Dec 2024 03:17:59 -0800 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.48) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.44; Wed, 18 Dec 2024 03:17:55 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=qkHz1wXI1RDCS4+5MVBYb0fACytAn+/H8QXVM0R3QBfhD/P0JAvrcYd/P3R+08UGT9g6Jb/ZKsla+SRR3YZYRjyP2I0zwOy241yqQE5wGmv0TAfl4iijbnwFn1KsQ04bOMEKldA3fD9Nabe6sg/isOYGEYKL3nOQVEY0gOZN4mSZ4G+gTXYtrqfFFl9OdmJSPvTmoOt2w62lq5EKKQr4cftUOLIcZ79ALyKCco9AAm+mOcO+oKzB+WjF/Oi92U6/xdOEUfRYcHaEhYYqS6d8P0GDnPcmLJG5qqIB91a5E0aEFukqqzROVhcLmBfmvoh/HUb+GLup+wEkXB3vNxzewA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=9a6t0dlNID+FemZQI1LnBmbG/q3PC9W/XAZFn0uShiI=; b=YeCFzyEDKVWXNMtAuZGovqE+m25X16slp8lj0YEC9vsN3jtVQOoJj8208xImaxXAc8bOx9GxcqeKihlt+5kiVhF5xRRHv0lonPS+Rj2Ts2SCmJYlJMscTkztR8Oq9uZGsGeVvBVa+JPfddqowS43NM4L2+GzrzS1AkUWUqXStrxfv08vhbPwY45U98aelvhUl1iNQoZi9R2JkUtX10Xs927/RLZ65DzdIBBgCgEiI/lfpI9iIztgWnD+MCNhDJCTnP81NT3p477UqImIGtvd1Smrqteyh+fukL/qOMN/AkMqsH2oIOCtPlM+pdGfvJt9n3BtFX4wuTv+td7jajwtmA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DM4PR11MB6502.namprd11.prod.outlook.com (2603:10b6:8:89::7) by CY8PR11MB6915.namprd11.prod.outlook.com (2603:10b6:930:59::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8272.13; Wed, 18 Dec 2024 11:17:21 +0000 Received: from DM4PR11MB6502.namprd11.prod.outlook.com ([fe80::21e4:2d98:c498:2d7a]) by DM4PR11MB6502.namprd11.prod.outlook.com ([fe80::21e4:2d98:c498:2d7a%3]) with mapi id 15.20.8251.015; Wed, 18 Dec 2024 11:17:21 +0000 Message-ID: <69c01586-01cf-423a-9565-dee2b41951cd@intel.com> Date: Wed, 18 Dec 2024 12:17:12 +0100 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 4/5] power: reduce memory footprint of per-lcore state To: David Marchand , CC: , , , David Hunt , Sivaprasad Tummala , Chengwen Feng , Stephen Hemminger , Konstantin Ananyev , =?UTF-8?Q?Morten_Br=C3=B8rup?= References: <20241205175754.1673888-1-david.marchand@redhat.com> <20241217085954.3310414-1-david.marchand@redhat.com> <20241217085954.3310414-5-david.marchand@redhat.com> Content-Language: en-US From: "Burakov, Anatoly" In-Reply-To: <20241217085954.3310414-5-david.marchand@redhat.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: DUZPR01CA0291.eurprd01.prod.exchangelabs.com (2603:10a6:10:4b7::9) To DM4PR11MB6502.namprd11.prod.outlook.com (2603:10b6:8:89::7) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM4PR11MB6502:EE_|CY8PR11MB6915:EE_ X-MS-Office365-Filtering-Correlation-Id: 10147d86-69c4-47b6-f2c7-08dd1f558a56 X-LD-Processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|1800799024|376014|7416014|366016|7053199007; X-Microsoft-Antispam-Message-Info: =?utf-8?B?ak04emlUQTBpVFAyMXdmQjBLNExtMlhuYmE4ZUJJRWNlOGRXVzVnVGpNOEN1?= =?utf-8?B?Rk8zVHV6S0owZ25LQjNHY09tRS9xNFZvZktTeFQ3NSsyV0M4Nk1CWStkTy9L?= =?utf-8?B?bHhIOTJvM2tyVXlyUndHeXF2Z1NMeHVUdDFFNkdhdUFJM3FOVFZMUU9VYklx?= =?utf-8?B?Skt6ZngwTEJoRGlDVlZMUFo1MUpzTytVMWt1Sk9pM2ZrVVNzUjQ3ZHY0a0hL?= =?utf-8?B?Z0RKSEtIZ3hvK293aWxscUM5SVFaNmJzbzNoSCs2QzNHWGFpNmJRMnZnRXlP?= =?utf-8?B?Mzg1Wk01b0txaWdqZ25sR1A5LzFYdzFBakN3QlI4OWdhcFpsdGtsZVIzM0pm?= =?utf-8?B?UUlCY1JFeldGRDJLRGkzZ2JGV1pLNWtnRE1saDZtbjZiUW0zSmVqbWh0SjRo?= =?utf-8?B?dEJzSjRYM1MraVFoTk5uWk1jTUxWU2VFYkRleEhyZFpBZ2Yva20yUG9yQ2VY?= =?utf-8?B?eHNqdmFqUVpjcENkVE5FRmRHbGYwQ1FMeWZJRjQwZ3BCNFlRZXdTNlpHMTBW?= =?utf-8?B?dUo2SDRWVTdnckpwdUZjWUh3aWxJdHFNS28zMTk2dWI5Q3lUOVUrc1hkQTJK?= =?utf-8?B?RlFpalhFMElEYk9pTG1hVU1kRW5TcmlheVY5bUt3eEFROGFMU2Y2THorY0M4?= =?utf-8?B?NmxLRWZsdWpvVi9maytRemloREZUaHd6V3lib1RoMXBvczNzVU1MSzNlWmVV?= =?utf-8?B?Nm9zNW8yd1ExRTNnd0x4bCtFeXJPQlJ3OEtHZTdLQlFEWVhJU3kxVUxGTWI4?= =?utf-8?B?V1hDMzZsZFJlZTJFU0JhK2V5Wjc3SWh6aldxTm1RWkxXYm0vNkpKTTV4U1lR?= =?utf-8?B?Y3REWHBxeDNHZHJXQlVWd1cvVUxKR1B4L3YwU3ZwdlhiN1poNnRqcXhKb2Iv?= =?utf-8?B?SUIydnZBa3Q4ekp1d29NeC9GR3U2UnA3WDhXQ2YyWEtkTWludG1Eb2QvZlp4?= =?utf-8?B?d3NiazIrZTJqRHEzanhuaWFxRlEwb0djTHp3ZUxkbElta05PMnBMRGpyRDR6?= =?utf-8?B?NEJ1V25IaWcyMzZsR1c5TVNpRCs2dUtlMnVzV3paU1lkcndFbStEcXQvKzBK?= =?utf-8?B?ekFwWFAxRGpaa2NaV3VJNnNVSHFBc2M5V1ptR2w2eHNIUUY3Q0NpUW4xaHNI?= =?utf-8?B?UURWVmtacG96SW1sb0NOQkIwY0RyRmZQNkFRRTRtMDlYVmNNbGRCdnRBQlU2?= =?utf-8?B?UDhxd1JvNGFnaWE2QWtid3Vlckhub2ZNMlNVSlhqdzNLbWZqQUtZZGxMQ0xF?= =?utf-8?B?SXA5NGZEODVjbXYrbkJ5QWdOSFp6SHNHMFgrZGVUS0tUci9Uc0VTdktSOUx3?= =?utf-8?B?SCtjTmpRempldkkwMk03aXJFTVkyQysrM2M2bnd1elFmOHVxMmVsUm5Xem5V?= =?utf-8?B?a3NFWk1vNDRZTlRXeWIvZ0xQZEphWmIyWmFkVmpNbXRBbHRBQ1MzckV0NC9u?= =?utf-8?B?bGlsN1hvTndLcldOUDJ2Y2MwaEliSEZYd0tjYis3SjJ3SVpqTEQxTVJtZFpY?= =?utf-8?B?Snl2djVxUlJVa29YcTNLVVZYREhDZUsvS1Y2NDRNRmRlK0Njd3ZHK0ZCSEdV?= =?utf-8?B?elVKeWhULzVVRXlGL0RtcVJhcE1renM5Zmp4MmxqZDNDNEc2dE00N25uTmVq?= =?utf-8?B?SVJPVEFSQ3NlMy9YVVBiMCt6Vndsc3BmQTRUTlFESW1BRlUrNHIzaXB2MXNp?= =?utf-8?B?SVZsYyt2KzZLaTBaelBvR2NmNmhhWjlpV2VVQnliSXpxTGp2Qm5EbnNRZHBT?= =?utf-8?B?RGNEV050UmJ3aVJMbjlod00wLy8wSDB2R20rc3cxWDBzc1Z1K1ZIakc0ZFRV?= =?utf-8?B?Skx5QU9SVUE4MTZ2dVQrNW9zNlpjSm8rUXo2OVhqQmVVZitPRkZiNDVlVFJa?= =?utf-8?Q?V6uY7gEiEmU1X?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM4PR11MB6502.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(1800799024)(376014)(7416014)(366016)(7053199007); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Rk16MVpJQmIwL2dLOW5TRnJyVGtMbG9oZ2tCamNUNUJPbDFIaEx0OVVnenBS?= =?utf-8?B?Z2VEMEwwaDY3TE44MG00N0RGMDNwUXdablJaUlk0a1dzaWROYmpISi94aEpv?= =?utf-8?B?YWN1VU5jdGpvaDBnemNLSFA0TUdwdmRDZnUyallvcU9GYlRHMWJ4UTU5ZnJC?= =?utf-8?B?WXRlKzM2cXdKdytreWVVOWc3ZUY0eHMzYWJ5WDRUNDh6dWZMbjFCSHpSa1dv?= =?utf-8?B?VlFLcmRkcU1vTTE4TVQ2VExjb3d1NXpyakZuZmlNVnA4RjlHeDdxVDg1bHAv?= =?utf-8?B?QmZ3SzNvNG9sTzJlcDNNaHdmQWMyWGMyRG10U2RwRVNtRXFXSkgxVXRkaEVB?= =?utf-8?B?UElSdExaRWR1NUVYcWtFc3BwUlhIbmxyNnp4OXZ4bW1MRlNzcitRMkg3enhF?= =?utf-8?B?MWVCRDdyamVSMVNhaXZlMjdTU2w4enN2UEFnVkF6VzBPWTVkZGRDYmhUSlVz?= =?utf-8?B?V283UG1OYWhvMWFqU0JEc1UwMlVNMWtUTzZYUlFyamU2c1BWL2lGcThDdFY4?= =?utf-8?B?M25UeFc2Vy8yRjJ4Mzd0TlVUUDFhQjI1NVhPQnUwSFU2LzVDVUJYTEZxVVhE?= =?utf-8?B?M0ttSEZBOG1ZV2FrZHlvVEttdmI5NUMwZCtGWlFuSGNtK1NwdVRISzRRelFs?= =?utf-8?B?RGt4YlAwUGJBZ0o3VlgrTWV6YWRSUnpQbEJNeFRXcDdYRlFLTkZVZS8yMTMz?= =?utf-8?B?K0M0M2VlbHc0andYdkY4L3hMK0tNa29XbkpHMzhqdnd0Y0txRHd0OURCd3k1?= =?utf-8?B?WjhXYlZYTDJkU2xuMzNYaGxvaUg4ci9ORnY3ZDVLZktmOU5zOS9pdHN3RElk?= =?utf-8?B?VTZuLzRrOHpDWWdJS1dpSTl6ZmMwb0Nhc2g4dm1FeWl0NXhTMyt4YWd2OHgw?= =?utf-8?B?dy8rR3hxN1FkMVphRG0veW9UM1E2VWhYZWdkOVlSQXpOVzhzQTFWNVJ5dStN?= =?utf-8?B?TGRzRFA3b0tab3p2Z3Y1V0VTUnJGbVArK0ljTUZPWGM3S1J6Zi9FMjVqRWNW?= =?utf-8?B?MkxiTjdzUDUrZWZOYmtCdmM5VC9wR0hxR2pkb1ZoMHBuT1YxYVo5bW8vOUUw?= =?utf-8?B?am00TlpzcUV0TERMTmNYZ01hU05pMXRzNFhMOHI0ck1EOHlqWDNpZGJOSlNT?= =?utf-8?B?OU1GQm9kekRQOFMzZGYraFF3QktUSXFiSFJlNkRlL0RhR2l5czkybUdaTUwy?= =?utf-8?B?SmQweXdHeVFOOGswSHBUR1RqK2Z2OGpLTnB0MExnYzJMWDlXVFdEais3UmM1?= =?utf-8?B?c28xbHJueFpkNW42UVlQVXRsNkVnRnJjanVESUltclJnUmIvdm9wUEg4VWg3?= =?utf-8?B?Tm90NTJXWE5tQk9DS3FPNDZ0Y00ybXQ3VDVpSnZidnhQRUxzaVlhNXpoeUpq?= =?utf-8?B?eFA4NGZXZjRyN3VMODdsWkk3TDVyN1BFUFlOdGVpSzQyL0xlL1h1TjhIb0wv?= =?utf-8?B?TjRFY3hLaGg3TENmOUhJc2x6OEo1THZwaERSYUZRNlF2YVRuamtlek5Qem8v?= =?utf-8?B?NVpabmxLVUM2K3FoQ3BvQy84WG9NQ2E5Ny9NT3JaZENKMW1mMnYwYXBCQzN2?= =?utf-8?B?Qi9uclVkczJSWjJVMnJ1U25Ub1JtQUhVd2lJeUtBMWZZNC9HWjdhYjdObGNx?= =?utf-8?B?VGhXVFErRXRuazNBbG1MTlRXZlRqMlpGSTdmYzhJUEthVnA5Y1ljVTh0ckJm?= =?utf-8?B?eGsxbXF5RWxxa0U0cldqeFBHT1BaNEs4WkNtN2kxaUo3RUZHcmVsZWEwWkJV?= =?utf-8?B?TWg2UjdzN2dTR3NrV1VSTXl3cVZDVm91QXdNRVlySG96SzJiaXJyMTJiZnov?= =?utf-8?B?WWYxZVJZMlB4RmVqSGVQWXRIWjNsaUVGODFiQUpkc3hLY3NNVlJ4NDJFd3Fp?= =?utf-8?B?T1h1Q0lLeGR2cGdIc2F3RDlWNkZqTlhLNXhHZXk0UVl4VWVOTjB5Wkk2UlE5?= =?utf-8?B?MUZKY20raFFteDEzYXozNVcyTGU3ZGlOaFJrNk9wVUVWOVJDVjREOU1zREtL?= =?utf-8?B?YWZZUzhlb2ZpSmdXQU03bnFOODdFOFNWbzhIRjczdHVkTmJjVEtMN0JqZTNj?= =?utf-8?B?UE1hRkdFd21oWmJCRm96VDBNbGhLZ1lvQWIrd0tNZGREa3ZWbk51dnowUFo4?= =?utf-8?B?UUlHNFVuV25nWnUzR0IzbDdmc2JWSUVNNldodVY4VmRiS0tkaHF1QjAwNjlP?= =?utf-8?B?QlE9PQ==?= X-MS-Exchange-CrossTenant-Network-Message-Id: 10147d86-69c4-47b6-f2c7-08dd1f558a56 X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB6502.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Dec 2024 11:17:21.2547 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: XdNK3MmITD0CMDMWr5xyNciDAQYnRA+72jn9I+l3QhYGzTvzKcMb3r7GsMfj+1w6RsK8IKKaeEdrKkcFVpo/enk4FE3MHsMEzRY0UWhnoXU= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR11MB6915 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 12/17/2024 9:59 AM, David Marchand wrote: > Now that the per-lcore state was moved into a lcore variable, > there is no reason to align a per-lcore state on a cache line to avoid > false sharing. > Remove this alignment and save a few bytes. > > Fixes: 130643319579 ("power: keep per-lcore state in lcore variable") > > Signed-off-by: David Marchand > --- > lib/power/rte_power_pmd_mgmt.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/lib/power/rte_power_pmd_mgmt.c b/lib/power/rte_power_pmd_mgmt.c > index 369ce3c354..8ec925bd65 100644 > --- a/lib/power/rte_power_pmd_mgmt.c > +++ b/lib/power/rte_power_pmd_mgmt.c > @@ -56,7 +56,7 @@ struct queue_list_entry { > const struct rte_eth_rxtx_callback *cb; > }; > > -struct __rte_cache_aligned pmd_core_cfg { > +struct pmd_core_cfg { > TAILQ_HEAD(queue_list_head, queue_list_entry) head; > /**< List of queues associated with this lcore */ > size_t n_queues; Acked-by: Anatoly Burakov -- Thanks, Anatoly