Re: [PATCH v5] app/testpmd: add help messages for multi-process

["Min Hu (Connor)" <humin29@huawei.com>]

Hi, Thomas,
	v6 has been sent, thanks.

在 2022/3/7 6:52, Thomas Monjalon 写道:
> 04/03/2022 16:35, Ferruh Yigit:
>> On 3/4/2022 9:11 AM, Zhang, Yuying wrote:
>>> From: Min Hu (Connor) <humin29@huawei.com>
>>>> From: Huisong Li <lihuisong@huawei.com>
>>>>
>>>> This patch adds help messages for multi-process.
>>>> --num-procs <N>, where N is the total number of symmetric_mp instances
>>>> that will be run side-by-side to perform packet processing. This parameter is
>>>> used to configure the appropriate number of receive queues on each
>>>> network port.
>>>>
>>>> --proc-id <n>, where n is a numeric value in the range 0 <= n < N (number of
>>>> processes, specified above). This identifies which symmetric_mp instance is
>>>> being run, so that each process can read a unique receive queue on each
>>>> network port.
>>>>
>>>> Fixes: a550baf24af9 ("app/testpmd: support multi-process")
>>>> Cc: stable@dpdk.org
>>>>
>>>> Signed-off-by: Huisong Li <lihuisong@huawei.com>
>>>> Signed-off-by: Min Hu (Connor) <humin29@huawei.com>
>>>
>>> Acked-by: Yuying Zhang <yuying.zhang@intel.com>
>>>
>>
>> Updated 'symmetric_mp' -> 'multi-process', with this change
>> Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>
>>
>> Applied to dpdk-next-net/main, thanks.
> 
> Why not reusing these defines?
> 
> #define PARAM_PROC_ID "proc-id"
> #define PARAM_NUM_PROCS "num-procs"
> 
> Why not having "N" in the help messages like others?
> 
> I won't pull it in main.
> Please rework and try to improve the description to make it shorter
> and easier to understand.
> 
> 
> .
>