From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id C122FA2EFC for ; Wed, 18 Sep 2019 18:17:40 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 87CE81D41D; Wed, 18 Sep 2019 18:17:40 +0200 (CEST) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 4A7B51D41C; Wed, 18 Sep 2019 18:17:39 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 18 Sep 2019 09:17:38 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,521,1559545200"; d="scan'208";a="191757722" Received: from vmedvedk-mobl.ger.corp.intel.com (HELO [10.237.220.135]) ([10.237.220.135]) by orsmga006.jf.intel.com with ESMTP; 18 Sep 2019 09:17:35 -0700 To: Ruifeng Wang , bruce.richardson@intel.com, olivier.matz@6wind.com Cc: dev@dpdk.org, stephen@networkplumber.org, konstantin.ananyev@intel.com, gavin.hu@arm.com, honnappa.nagarahalli@arm.com, dharmik.thakkar@arm.com, nd@arm.com, stable@dpdk.org References: <20190822063457.41596-1-ruifeng.wang@arm.com> <20190906094534.36060-1-ruifeng.wang@arm.com> <20190906094534.36060-6-ruifeng.wang@arm.com> From: "Medvedkin, Vladimir" Message-ID: <69f7bd6d-cc41-a79a-c4e1-c8db784c9952@intel.com> Date: Wed, 18 Sep 2019 17:17:34 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <20190906094534.36060-6-ruifeng.wang@arm.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Subject: Re: [dpdk-dev] [PATCH v2 5/6] test/lpm: reset total time X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Ruifeng, Thanks for this bug fix. I think it should be sent separately from this RCU related patch series. On 06/09/2019 10:45, Ruifeng Wang wrote: > From: Honnappa Nagarahalli > > total_time needs to be reset to measure the cycles for delete API. > > Fixes: af75078fece3 ("first public release") > Cc: stable@dpdk.org > > Signed-off-by: Honnappa Nagarahalli > Reviewed-by: Gavin Hu > Reviewed-by: Ruifeng Wang > --- > app/test/test_lpm_perf.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/app/test/test_lpm_perf.c b/app/test/test_lpm_perf.c > index 77eea66ad..a2578fe90 100644 > --- a/app/test/test_lpm_perf.c > +++ b/app/test/test_lpm_perf.c > @@ -460,7 +460,7 @@ test_lpm_perf(void) > (double)total_time / ((double)ITERATIONS * BATCH_SIZE), > (count * 100.0) / (double)(ITERATIONS * BATCH_SIZE)); > > - /* Delete */ > + /* Measure Delete */ > status = 0; > begin = rte_rdtsc(); > > @@ -470,7 +470,7 @@ test_lpm_perf(void) > large_route_table[i].depth); > } > > - total_time += rte_rdtsc() - begin; > + total_time = rte_rdtsc() - begin; > > printf("Average LPM Delete: %g cycles\n", > (double)total_time / NUM_ROUTE_ENTRIES); -- Regards, Vladimir