From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B688B43A40; Wed, 7 Feb 2024 11:35:59 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4B3AD40279; Wed, 7 Feb 2024 11:35:59 +0100 (CET) Received: from NAM04-DM6-obe.outbound.protection.outlook.com (mail-dm6nam04on2078.outbound.protection.outlook.com [40.107.102.78]) by mails.dpdk.org (Postfix) with ESMTP id 7AFE74021D for ; Wed, 7 Feb 2024 11:35:57 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=m+kxJiTzlmxPd7jbyGBROxqbsHDl3KAVBslLF7vEhvVO7oZiruC31LGRPryBjCbVb2RaxR+zmZN+bsC3VgcqlZLA/i0ZAq+ViDiGft+rqpsONRRoirH7D4o86h2L4cZf8U0HAdaHeeAeG27/NisLrCTJf3Bj0n3UkmsRv/gS1NQP/yjgJVmr1cRlTcQUjm/4qYo22RDfMgGxijKZZjf0RbLYBaGL3QE4bKHM5RSNulJY2d0IlaZ3Rq6qEVBcKOt9B1+OX0ufaMejL+XafZlolR+fvUWhfWkMOzwvFlgRgVl9dTXW3ss32tOTIyc0maksk0IgohGzc8GW44mBbYYCRw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=3vcGMQy5NoeN2MaFOtht3wIA6jOF3Ftjn7NoMqoS0HE=; b=iYZHdKd3pvPb6obnY5XsTUfwgJ6Z8yHVcct3uF8SLDWO3T4n/t0y+vGjJzFd9PEsSQt7aLoeojWzsFpBTNzA6p1lWVcbGHGe4yZBgcsJ5CBBNgd4Hgl61EB9GgaOV5hUBuoUBvoWl2Z8sxR+2gRgyeOchHfULsTe5rgmSia8IZ6nvd0YdBdsUJ9mMyR63o5/9Jtee0cc5M5uxpzUAi9XaPn7GCgyrZdZXFTHOUt6JE+hNDnKhfD7UaX5YVUspLcRbC+ai3cbRDi/ot1wN7dOJW4Jod3ktGd7/Dmd15Ami03/+Eni3CqpMWnXygfEZgAFUdnQD37UVkqvCAXOT3ljPw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3vcGMQy5NoeN2MaFOtht3wIA6jOF3Ftjn7NoMqoS0HE=; b=V+llq3ByTcWTMzXAESboeTWkKLQBxQVFRZdowXJI7A7gu1aMu3LHiwy0ZKs8m5cIE44Sf0G5fRwqhEaUvJ8wfu2nCays/R7WjMShZ02Oi/K5zNYdHYy1j0X2SF2aV23PDt3aiFRVP9x/H4Jgk4tOMNACNMPsNzR7mYhJKZMk7Zc= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by MW4PR12MB7381.namprd12.prod.outlook.com (2603:10b6:303:219::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7270.16; Wed, 7 Feb 2024 10:35:54 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::815a:45e6:cf5e:479f]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::815a:45e6:cf5e:479f%4]) with mapi id 15.20.7270.016; Wed, 7 Feb 2024 10:35:54 +0000 Message-ID: <69f86bba-773d-4f7e-adb9-0a43273dc692@amd.com> Date: Wed, 7 Feb 2024 10:35:50 +0000 User-Agent: Mozilla Thunderbird Subject: Re: [EXT] Re: [PATCH] examples/ipsec-secgw: fix IPsec performance drop Content-Language: en-US To: Rahul Bhansali , "dev@dpdk.org" , Radu Nicolau , Akhil Goyal , Konstantin Ananyev , Anoob Joseph References: <20240206123811.3452587-1-rbhansali@marvell.com> From: Ferruh Yigit Autocrypt: addr=ferruh.yigit@amd.com; keydata= xsFNBGJDD3EBEAC/M7Tk/DfQSmP1K96vyzdhfSBzlCaGtcxNXorq4fALruqVsD3oi0yfyEz9 4YN8x7py0o9EL8ZdpOX0skc0AMCDAaw033uWhCn0GLMeGRKUbfOAPvL6ecSDvGD7CJIO9j0J eZUvasBgPdM/435PEr9DmC6Ggzdzt8IuG4PoLi5jpFSfcqxZFCCxLUDEo/w0nuguk2FTuYJg B2zEZ4JTBZrw7hIHiFh8D8hr6YA6a5uTofq1tr+l048lbtdFUl8TR0aIExVzE4Z8qKZlcE+9 RQaewjK5Al1jLE4sHdmd3GN+IvgDF3D/fLsi25SKJDeGSdeHkOmaX0qGeM4WKIfU6iARRCiQ N3AmBIxZ/A7UXBKLaOyZ+/i3sE6Wb53nrO4i8+0K2Qwyh6LjTeiJAIjYKN43ppxz3DaI+QwQ vI+uyHr4Gg0Da9EPPz/YyKauSeOZCfCB5gIfICO0j6x0SCl8uQ2nLpjxcZkf0gjcwUzP3h+S 3x6NfDji9YEij0zczW/dcSpGgZ6vsFpPrtnP9ZXy6J53yp0kJtOJoOlkEFFdU2yCZnCDseum CoudmGLZVvS0/DzHDJejq+3kK3FDGktZBOxZIIpal+nFqS7lVgOZc4+huVv3jyhzoAUOEyXA XK5j6o7g8STUY+z33QNnHpdLvecMwuzmvqy0jR54yAbZ64mB9QARAQABzSNGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBhbWQuY29tPsLBlwQTAQgAQQIbAwULCQgHAgYVCgkICwIEFgID AQIeAQIXgAIZARYhBEm7aYjps5XGsPHCElRTPtCKKm/6BQJkdyEEBQkE3meNAAoJEFRTPtCK Km/6UdcP/0/kEp49aIUhkRnQfmKmNVpcBEs4NqceNCWTQlaXdEwL1lxf1L49dsF5Jz1yvWi3 tMtq0Mk1o68mQ7q8iZAzIeLxGQAlievMNE0BzLWPFmuX+ac98ITBqKdnUAn6ig5ezR+jxrAU 58utUszDl16eMabtCu76sINL5izB8zCWcDEUB4UqM8iBSQZ7/a7TSBVS0jVBldAORg1qfFIs cGMPQn/skhy3QqbK3u3Rhc44zRxvzrQJmhY6T1rpeniHSyGOeIYqjpbpnMU5n1VWzQ4NXvAD VDkZ4NDw6CpvF4S2h2Ds7w7GKvT6RRTddrl672IaLcaWRiqBNCPm+eKh4q5/XkOXTgUqYBVg Ors8uS9EbQC/SAcp9VHF9fB+3nadxZm4CLPe5ZDJnSmgu/ea7xjWQYR8ouo2THxqNZtkercc GOxGFxIaLcJIR/XChh9d0LKgc1FfVARTMW8UrPgINVEmVSFmAVSgVfsWIV+NSpG9/e90E4SV gMLPABn1YpJ8ca/IwqovctqDDXfxZOvCPOVWTzQe/ut767W+ctGR1kRkxWcz470SycOcY+PW VRPJd91Af0GdLFkwzZgNzkd6Gyc9XXcv4lwwqBLhWrBhqPYB0aZXIG1E/cVTiRp4dWpFHAFD DcuLldjIw93lCDsIeEDM9rBizGVMWEoeFmqSe7pzGTPXzsFNBGJDD3EBEAC8fBFQHej8qgIG CBzoIEd1cZgPIARlIhRudODXoNDbwA+zJMKtOVwol3Hh1qJ2/yZP11nZsqrP4fyUvMxrwhDe WBWFVDbWHLnqXMnKuUU1vQMujbzgq/4Rb9wSMW5vBL6YxhZng+h71JgS/9nVtzyaTtsOTrJi 6nzFSDx6Wbza2jYvL9rlK0yxJcMEiKwZQ/if4KcOesD0rtxomU/iSEv6DATcJbGXP6T93nPl 90XksijRKAmOwvdu3A8IIlxiSSVRP0lxiHOeR35y6PjHY2usfEDZZOVOfDfhlCVAIBZUZALv VmFOVSTYXeKgYa6Ooaf72+cHM3SgJIbYnevJfFv8YQW0MEAJ/IXE7B1Lk+pHNxwU3VBCrKnA fd/PTvviesuYRkrRD6qqZnINeu3b2DouVGGt2fVcGA38BujCd3p8i7azoGc7A6cgF7z9ETnr ANrbg1/dJyDmkDxOxVrVquTBbxJbDy2HaIe9wyJTEK2Sznpy62DaHVY+gfDQzexBXM10geHC IIUhEnOUYVaq65X3ZDjyAQnNDBQ4uMqSHZk8DpJ22X+T+IMzWzWl+VyU4UZXjkLKPvlqPjJk 1RbKScek5L2GhxHQbPaD76Hx4Jiel0vm2G+4wei8Ay1+0YRFkhySxogU/uQVXHTv63KzQMak oIfnN/V2R0ucarsvMBW+gwARAQABwsF8BBgBCAAmAhsMFiEESbtpiOmzlcaw8cISVFM+0Ioq b/oFAmR3IPsFCQTeZ44ACgkQVFM+0Ioqb/qINhAAtcor9bevHy22HvJvXX17IOpPSklZJAeQ Az43ZEo5kRlJ8mElc2g3RzYCvL/V3fSiIATxIsLq/MDtYhO8AAvklxND/u2zeBd7BkRZTZZX W1V1cM3oTvfx3LOhDu4f2ExQzCGdkzbXTRswSJIe1W0qwsDp+YPekbrsKp1maZArGeu+6FuW honeosIrWS98QJmscEhP8ooyJkLDCCOgEk+mJ/JBjzcJGuYn6+Iy/ApMw/vqiLGL1UWekcTA g18mREHqIR+A3ZvypIufSFB52oIs1zD/uh/MgmL62bY/Cw6M2SxiVxLRsav9TNkF6ZaNQCgn GqifliCEMvEuLZRBOZSYH2A/PfwjYW0Ss0Gyfywmb2IA990gcQsXxuCLG7pAbWaeYazoYYEQ NYmWatZNMAs68ERI2zvrVxdJ/fBWAllIEd0uQ4P05GtAHPdTIDQYp545+TPV7oyF0LfXcsQs SFVZE6igdvkjfYmh+QOrHGZvpWXLTmffVf/AQ81wspzbfxJ7sYM4P8Mg5kKOsaoUdyA/2qVe cMh1CLUHXF1GlofpGbe1lj4KUJVse5g3qwV7i9VrseA8c4VIZewdIjkzAhmmbxl+8rM/LKBH dZUMTzME5PFCXJIZ83qkZQ795MTe2YScp9dIV7fsS5tpDwIs7BZNVM1l3NAdK+DLHqNxKuyO 8Zk= In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO0P123CA0004.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:354::9) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|MW4PR12MB7381:EE_ X-MS-Office365-Filtering-Correlation-Id: 018a3260-e9bc-4380-0ffd-08dc27c89014 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: qONYX0eFj/tKfN9yL7UEIpIuPuQ339vVo+XTseLPcvzv4RmqS/Rly3sARsAlPmwzYgzz94c0D5hCF0tyJ/wP5iw8baBqg5vfL0NR+4p5PPGMahrz1ULBvEvnuY48uxz3o6DTvyjVmKJugIYNE6RgNNoyMSc4AT1pKQuGLG4bWsAp0qBABpn5uCevlwIdQ9UvyKzokxtnE+Pm6qAqhOs/Kh4ZfOSckpkKQ+keU3Y+ywQ8lr2yzD6t9kUaDzfoJblXb7DLcMzwxctxgHcaqpgI0H0R1wGrVwzi0ax1q02Lb6EWgPv0G37Vqe1ESyq44ktrbo9U96u2pjkikVKyi8EXPTXUh5IgdvJuid1tC2JIrCkOK8Y+TnV2V30cwZ4VaYN5LsDgheHC4LRFWNnPXp2FN8b75z0R2sgE1qEeuu1N/cHF2rGZIv7Jv6k1utWMKNF9wODRpQC38vCCVKf2pDHrAxJ7uwJ9IUbpmr9zFIceR2uI3iB6ikuYIJ5F+UWldUWXEcCNih3sXXRJYAIu0mEJn2bpzv6ojrX4SIkMGizUkyc0NVqoEaDBwIoNUzUcRKwGHNLUZ5rd+/ZiFZ67dl1dX8wwkaxRZ8m7tu3mNFfVSMpZ3nemUlyKCRKliozg9RmsSkVNqgVWcz1nz02M7++QuQ== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(376002)(136003)(39860400002)(346002)(396003)(366004)(230273577357003)(230922051799003)(186009)(1800799012)(64100799003)(451199024)(26005)(41300700001)(31686004)(2616005)(6512007)(316002)(53546011)(83380400001)(6506007)(36756003)(6666004)(6486002)(38100700002)(478600001)(8936002)(66476007)(8676002)(31696002)(2906002)(5660300002)(66946007)(66556008)(86362001)(110136005)(44832011)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TGVCdkV1bzNvaU42VlRtS3kvM0tQVHJjOUI3cytmZVg2NkFiZVpXelEzWXRa?= =?utf-8?B?MjJmZ3Rod1lUUEQvVFhaajZaeXc0eFNZTkZvVXNtZlBYKzV1VmVhMEo3NnNv?= =?utf-8?B?UHFaQk9VWHBRMDdTeEJkT0R3eDVldXNTVVhlZFl2Um5LbXpON25qSmRtZmtu?= =?utf-8?B?eWd2TTVnVXI1VEJraWJKUnJXUHFVZytIcVB4U3grdFF0USsvdUgrang3bk16?= =?utf-8?B?MWJKdFJkWVZHVUIxSjVQcTRvRjZJV05SSngvQURvcU0zSFA1OEF2TG9IYW90?= =?utf-8?B?clNxT1hiblZUVXNSUXJOVXhabmFRd2JmRURoRlVOYjJkb21rS3BqMEtwQW5U?= =?utf-8?B?cU5DMlVoOWIrRkJKSk5EY0Zkd0phMFZYUnpSQjZEY1JjNWxCa2hMbGRod24x?= =?utf-8?B?L3ZFbmtma0JUWlQ5TkQ0aXFUeE5sbGs1NTd1ZXlBTkViVXRqWUJFTERGbEwv?= =?utf-8?B?MEd3U3h0S0dRNDZRMVpRWkl4NmN2bzBtUTlSRzg5aUdqUDhYRXV0RXBta2ZR?= =?utf-8?B?ckNZQTV5ZEhhMWZNdEtCWTRuM0tJNUZ6UzJSWkErQjFKUnFuNDJ3bnZtOXk5?= =?utf-8?B?MDNubnRVSXdtYW1SMFhCcE1VSUN5NGI0U3p1UXZrZGN4OXRXNWROOFpmU2dx?= =?utf-8?B?MFk2L29LWWQ2eSt3QUh3U1lWYWRNK3NQb2RkSXpHUHg5cTRBVUV4WWZYNjdD?= =?utf-8?B?ZmRCajFUM2E3UkloMEVvbEprWUdVN1dMVzBiYThSTkRKTWlEYU9sWEY3RThB?= =?utf-8?B?OHpGOEoyRDFDT3Bic1V4TFNIZWJES2QxNUdvWmRQQ0dsbHg0TkpGQ2dycVNG?= =?utf-8?B?TjF0c0lrUXVwTHFUKzR6S2ROWkNHMGJCcC9VdUhYbWxhQUJ2cFlFV05DQ21M?= =?utf-8?B?MFJ1bmEvT3h0SHQzMFRSaWR3QkUraGMybFd6V2lOVWQwemxZODA1emIrelJ3?= =?utf-8?B?bnZBWW5YMC85bkUzaGxQZkE4aFQ5OUwvVW5ucjRvM2toQXBxR2crVXl4MUlZ?= =?utf-8?B?SVlnK2FJOHdYMG5sSUFaTGxNMGZvUGxMU2FwcStkeExGRytNbFFwTlRlUWIw?= =?utf-8?B?Y0NtU2RIRDZJbUVzb3BoYWMvOUN2ZzkrTEhiY253Tm0yTTNHQlAwcHBBd1Rk?= =?utf-8?B?elpMRzRTK1pwR2o3WjdKS01BMzZNM3lrbW1rUU5SRGkxdUU4UUV5LzR1RW9y?= =?utf-8?B?QURIZnVBZ1hWZGxxTExmNGhkaTc1dUhrUFFTN3pOUWh6UU1pY1pkL3JLQmJF?= =?utf-8?B?ejdRaXVnZXB4WFlDU0RrNDhVWWJja0s4ZWJXazNic3N5aHBUTjhnOGQycFVn?= =?utf-8?B?TXc1aWpWcXc1VG1Qai9ZZTFvMlZzS0pIZkVmRDUwOHR0Si9ZL3NDQzYzS0ZD?= =?utf-8?B?bXFvR2RaakFEUEFtYTcrb0p6NlBITVZmTUxzdDJiUVo3RUc2VzdPMERjQXU4?= =?utf-8?B?QnBGRDBIYlF5dHBHd0cxM0k5RnU0UndnbmgzQWs1MjB4Y1VUY1pTdDNIKzhn?= =?utf-8?B?U1VKYUpIQ00wYmU1RmFDQkV1Yml1V0xWK0JFcmtSZFJpSlE1SW52SHZDb0VF?= =?utf-8?B?bUZKQXZOVGltcVdFcGlSbi8zMUpNRElURDVQZURZMEVWbG9UdXlWMndHeGlY?= =?utf-8?B?SHZxVVZ1bmlWL09LU2loU3duMVByeGdlRGh2THd0a1lrY3hpUDlJZll6Mi9m?= =?utf-8?B?Y2VrWTlPZWUzV3JWR1RsMHVQL3E0TzV2TE9hMk5XenpSd015c3RBSC9NT0lP?= =?utf-8?B?WmFxazIyQUl0SzJRK2xnYi9kOEhBTERRVEp0eUJKWGNTZUlKVER5ZnVLem16?= =?utf-8?B?SU5LcGNHWGxsZmdCV3ZlekRZWUlyblVSZUtGRFAzRFdGOWx3UFhJbEc4RFh2?= =?utf-8?B?Vkc0ZkxIUVhxOTlONEVSVFJuWllQTVpvcE94aVFkQkpPa1p0MGc2SXJWVVhP?= =?utf-8?B?UnA2ZWVEVCs4M2NtR213UHZIY1VMZWFHdnczU3ZTdDZJTUcvYTZMTXJwU0U1?= =?utf-8?B?dGtGMW41aVBmd05vWTNXcFY3VVhKeGoxd0dmblU1Q2lLZlR2bzFiK1UvK1BL?= =?utf-8?B?djVpMlJyc1J2RjFPdFVLRjVFV1Q4dDJwVllpVU42VHpLQzdKWVFHNjJ4K1Yv?= =?utf-8?Q?+I+ur7lhkinVkT9T4FnSFyWF3?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 018a3260-e9bc-4380-0ffd-08dc27c89014 X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Feb 2024 10:35:54.6194 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ay7Y042/czfTrprFPeZMmFVGoO2ijGjbQwF9p4e05tiHSDraBAE8P8rEifSYW/IU X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR12MB7381 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 2/7/2024 6:46 AM, Rahul Bhansali wrote: > > >> -----Original Message----- >> From: Ferruh Yigit >> Sent: Tuesday, February 6, 2024 11:55 PM >> To: Rahul Bhansali ; dev@dpdk.org; Radu Nicolau >> ; Akhil Goyal ; Konstantin >> Ananyev ; Anoob Joseph >> >> Subject: [EXT] Re: [PATCH] examples/ipsec-secgw: fix IPsec performance drop >> >> External Email >> >> ---------------------------------------------------------------------- >> On 2/6/2024 12:38 PM, Rahul Bhansali wrote: >>> Single packet free using rte_pktmbuf_free_bulk() is dropping the >>> performance. On cn10k, maximum of ~4% drop observed for IPsec event >>> mode single SA outbound case. >>> >>> To fix this issue, single packet free will use rte_pktmbuf_free API. >>> >>> Fixes: bd7c063561b3 ("examples/ipsec-secgw: use bulk free") >>> >>> Signed-off-by: Rahul Bhansali >>> --- >>> examples/ipsec-secgw/ipsec-secgw.h | 7 +++---- >>> 1 file changed, 3 insertions(+), 4 deletions(-) >>> >>> diff --git a/examples/ipsec-secgw/ipsec-secgw.h >>> b/examples/ipsec-secgw/ipsec-secgw.h >>> index 8baab44ee7..ec33a982df 100644 >>> --- a/examples/ipsec-secgw/ipsec-secgw.h >>> +++ b/examples/ipsec-secgw/ipsec-secgw.h >>> @@ -229,11 +229,10 @@ free_reassembly_fail_pkt(struct rte_mbuf *mb) } >>> >>> /* helper routine to free bulk of packets */ -static inline void >>> -free_pkts(struct rte_mbuf *mb[], uint32_t n) >>> +static __rte_always_inline void >>> +free_pkts(struct rte_mbuf *mb[], const uint32_t n) >>> { >>> - rte_pktmbuf_free_bulk(mb, n); >>> - >>> + n == 1 ? rte_pktmbuf_free(mb[0]) : rte_pktmbuf_free_bulk(mb, n); >>> core_stats_update_drop(n); >>> } >>> >> >> Hi Rahul, >> >> Do you think the 'rte_pktmbuf_free_bulk()' API performance can be improved by >> similar change? > > Hi Ferruh, > Currently 'rte_pktmbuf_free_bulk() is not inline. If we make that along with __rte_pktmbuf_free_seg_via_array() both inline then performance can be improved similar. > Ah, so performance improvement is coming from 'rte_pktmbuf_free()' being inline, OK. As you are doing performance testing in that area, can you please check if '__rte_pktmbuf_free_seg_via_array()' is inlined, as it is static function I expect it to be inlined. If not, can you please test with force inlining it (__rte_always_inline)? And I wonder if bulk() API may get single mbuf is a common theme, does it makes sense add a new inline wrapper to library to cover this case, if it is bringing ~4% improvement, like: ``` static inline void rte_pktmbuf_free_bulk_or_one(... **mb, unsigned int n) { if (n == 1) return rte_pktmbuf_free(mb[0]); return rte_pktmbuf_free_bulk(mb, n); } ```