From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 740D15A89 for ; Fri, 25 Sep 2015 10:14:59 +0200 (CEST) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga103.jf.intel.com with ESMTP; 25 Sep 2015 01:14:58 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.17,585,1437462000"; d="scan'208";a="776808218" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by orsmga001.jf.intel.com with ESMTP; 25 Sep 2015 01:14:57 -0700 Received: from fmsmsx120.amr.corp.intel.com (10.18.124.208) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.248.2; Fri, 25 Sep 2015 01:14:57 -0700 Received: from shsmsx104.ccr.corp.intel.com (10.239.4.70) by fmsmsx120.amr.corp.intel.com (10.18.124.208) with Microsoft SMTP Server (TLS) id 14.3.248.2; Fri, 25 Sep 2015 01:14:56 -0700 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.179]) by SHSMSX104.ccr.corp.intel.com ([169.254.5.210]) with mapi id 14.03.0248.002; Fri, 25 Sep 2015 16:14:55 +0800 From: "Lu, Wenzhuo" To: Thomas Monjalon Thread-Topic: [dpdk-dev] [PATCH 1/6] lib/librte_ether: modify the structures for fdir new modes Thread-Index: AQHQ91hHl2s5Zp1LBkiAnB1kqUohUJ5MSviAgACX+lA= Date: Fri, 25 Sep 2015 08:14:54 +0000 Message-ID: <6A0DE07E22DDAD4C9103DF62FEBC090902091223@shsmsx102.ccr.corp.intel.com> References: <1443161125-1035-1-git-send-email-wenzhuo.lu@intel.com> <1443161125-1035-2-git-send-email-wenzhuo.lu@intel.com> <2216065.qpkPQE5WLk@xps13> In-Reply-To: <2216065.qpkPQE5WLk@xps13> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH 1/6] lib/librte_ether: modify the structures for fdir new modes X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 25 Sep 2015 08:14:59 -0000 Hi Thomas, > -----Original Message----- > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > Sent: Friday, September 25, 2015 3:01 PM > To: Lu, Wenzhuo > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH 1/6] lib/librte_ether: modify the structur= es for > fdir new modes >=20 > 2015-09-25 14:05, Wenzhuo Lu: > > +enum rte_fdir_mode { > > + RTE_FDIR_MODE_NONE =3D 0, /**< Disable FDIR support. */ > > + RTE_FDIR_MODE_SIGNATURE, /**< Enable FDIR signature filter mode. > */ > > + RTE_FDIR_MODE_PERFECT, /**< Enable FDIR perfect filter mode for IP. > */ > > + RTE_FDIR_MODE_PERFECT_MAC_VLAN, /**< Enable FDIR filter mode - > MAC VLAN. */ > > + RTE_FDIR_MODE_PERFECT_CLOUD, /**< Enable FDIR filter mode - > cloud. */ > > +}; >=20 > I know that some Intel NICs use the terminology "cloud" in their datashee= t, but > it is meaningless. >=20 > [...] > > +/** > > + * A structure used to define the input for VxLAN NVGRE flow */ > > +struct rte_eth_cloud_flow { > > + enum rte_eth_fdir_tunnel_type tunnel_type; /**< Tunnel type to match. > */ > > + uint32_t tni_vni; /**< TNI or VNI to match. = */ >=20 > Isn't it Intel-specific? I think only the word "cloud" is specific. It's for VxLAN and NVGRE packets= . >=20 > > + struct ether_addr mac_addr; /**< Mac address to match.= */ > > +}; >=20 > So it is a tunnel, currently only VXLAN or NVGRE. > And this kind of tunnel can be used in a cloud datacenter, yes. Or elsewh= ere. >=20 > Please use the "tunnel" word. Thanks for the comments. I'll sent a V2 to avoid using "cloud".