From: "Lu, Wenzhuo" <wenzhuo.lu@intel.com>
To: "Van Haaren, Harry" <harry.van.haaren@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] ixgbe: fix 82599 / 82598 register differences
Date: Tue, 20 Oct 2015 01:29:59 +0000 [thread overview]
Message-ID: <6A0DE07E22DDAD4C9103DF62FEBC0909020A09C7@shsmsx102.ccr.corp.intel.com> (raw)
In-Reply-To: <1443701571-7000-1-git-send-email-harry.van.haaren@intel.com>
Hi,
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Harry van Haaren
> Sent: Thursday, October 1, 2015 8:13 PM
> To: dev@dpdk.org
> Subject: [dpdk-dev] [PATCH] ixgbe: fix 82599 / 82598 register differences
>
> Ixgbe based 82598 and 82599 have different priority recieve link-on register
> addresses. This is solved in base/ by providing in the PXONRXC and
> PXONXCNT as seperate macros. This patch ensures the correct address is
> read, avoiding reading garbage values.
>
> Also PXON2OFFCNT doesn't exist in 82598, so it is not read for that MAC.
>
> This issue has existed since the drivers were imported into DPDK, but was
> not easily discoverable as xstats were not available.
> Tested using testpmd> show port xstats all
>
> Fixes: af75078fece3 ("first public release")
>
> Signed-off-by: Harry van Haaren <harry.van.haaren@intel.com>
Acked-by: Wenzhuo Lu <wenzhuo.lu@intel.com>
next prev parent reply other threads:[~2015-10-20 1:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-01 12:12 Harry van Haaren
2015-10-20 1:29 ` Lu, Wenzhuo [this message]
2015-10-28 14:05 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6A0DE07E22DDAD4C9103DF62FEBC0909020A09C7@shsmsx102.ccr.corp.intel.com \
--to=wenzhuo.lu@intel.com \
--cc=dev@dpdk.org \
--cc=harry.van.haaren@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).