From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id BEDFAC3C4 for ; Fri, 23 Oct 2015 03:22:32 +0200 (CEST) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga103.jf.intel.com with ESMTP; 22 Oct 2015 18:22:31 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.20,185,1444719600"; d="scan'208";a="833477328" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by fmsmga002.fm.intel.com with ESMTP; 22 Oct 2015 18:22:31 -0700 Received: from fmsmsx114.amr.corp.intel.com (10.18.116.8) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.248.2; Thu, 22 Oct 2015 18:22:31 -0700 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by FMSMSX114.amr.corp.intel.com (10.18.116.8) with Microsoft SMTP Server (TLS) id 14.3.248.2; Thu, 22 Oct 2015 18:22:30 -0700 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.253]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.47]) with mapi id 14.03.0248.002; Fri, 23 Oct 2015 09:22:28 +0800 From: "Lu, Wenzhuo" To: "Richardson, Bruce" Thread-Topic: [dpdk-dev] [PATCH v3 1/7] lib/librte_ether: modify the structures for fdir new modes Thread-Index: AQHRDJj6rMkUnExxaECGcrnYz33abJ528w4AgAFTqhA= Date: Fri, 23 Oct 2015 01:22:28 +0000 Message-ID: <6A0DE07E22DDAD4C9103DF62FEBC0909020A1EE3@shsmsx102.ccr.corp.intel.com> References: <1443161125-1035-1-git-send-email-wenzhuo.lu@intel.com> <1445497902-16703-1-git-send-email-wenzhuo.lu@intel.com> <1445497902-16703-2-git-send-email-wenzhuo.lu@intel.com> <20151022125718.GB20740@bricha3-MOBL3> In-Reply-To: <20151022125718.GB20740@bricha3-MOBL3> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsIiwiaWQiOiI5MDg3MTNmNS1mMzM1LTQzMTctODg0Mi1jNDM4NDcwNWFjMjgiLCJwcm9wcyI6W3sibiI6IkludGVsRGF0YUNsYXNzaWZpY2F0aW9uIiwidmFscyI6W3sidmFsdWUiOiJDVFBfUFVCTElDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjQuMTAuMTkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiVHUzSmtiRkpJeWkyc09RbkpWNzRzd0Q5ckpHZE00VzVEQnc4Q3lYeCs2ND0ifQ== x-inteldataclassification: CTP_PUBLIC x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH v3 1/7] lib/librte_ether: modify the structures for fdir new modes X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 23 Oct 2015 01:22:33 -0000 Hi Bruce, > -----Original Message----- > From: Richardson, Bruce > Sent: Thursday, October 22, 2015 8:57 PM > To: Lu, Wenzhuo > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v3 1/7] lib/librte_ether: modify the struc= tures > for fdir new modes >=20 > On Thu, Oct 22, 2015 at 03:11:36PM +0800, Wenzhuo Lu wrote: > > Define the new modes and modify the filter and mask structures for the > > mac vlan and tunnel modes. > > > > Signed-off-by: Wenzhuo Lu >=20 > Hi Wenzhuo, >=20 > couple of stylistic comments below, which would help with patch review, > especially with regards to checking for ABI issues. >=20 > /Bruce >=20 > > --- > > lib/librte_ether/rte_eth_ctrl.h | 69 > > ++++++++++++++++++++++++++++++----------- > > 1 file changed, 51 insertions(+), 18 deletions(-) > > > > diff --git a/lib/librte_ether/rte_eth_ctrl.h > > b/lib/librte_ether/rte_eth_ctrl.h index 26b7b33..078faf9 100644 > > --- a/lib/librte_ether/rte_eth_ctrl.h > > +++ b/lib/librte_ether/rte_eth_ctrl.h > > @@ -248,6 +248,17 @@ enum rte_eth_tunnel_type { }; > > > > /** > > + * Flow Director setting modes: none, signature or perfect. > > + */ > > +enum rte_fdir_mode { > > + RTE_FDIR_MODE_NONE =3D 0, /**< Disable FDIR support. */ > > + RTE_FDIR_MODE_SIGNATURE, /**< Enable FDIR signature filter mode. > */ > > + RTE_FDIR_MODE_PERFECT, /**< Enable FDIR perfect filter mode for > IP. */ > > + RTE_FDIR_MODE_PERFECT_MAC_VLAN, /**< Enable FDIR filter mode > - MAC VLAN. */ > > + RTE_FDIR_MODE_PERFECT_TUNNEL, /**< Enable FDIR filter mode - > tunnel. */ > > +}; > > + >=20 > Why is this structure definition moved in the file, it makes seeing the d= iff vs > the old version difficult. I remember in the original version I move this enum to resolve a compile is= sue. But now after all the code changed, the issue is not here. So, I'll move it= back. >=20 > > +/** > > * filter type of tunneling packet > > */ > > #define ETH_TUNNEL_FILTER_OMAC 0x01 /**< filter by outer MAC addr > */ > > @@ -377,18 +388,46 @@ struct rte_eth_sctpv6_flow { }; > > > > /** > > + * A structure used to define the input for MAC VLAN flow */ struct > > +rte_eth_mac_vlan_flow { > > + struct ether_addr mac_addr; /**< Mac address to match. */ }; > > + > > +/** > > + * Tunnel type for flow director. > > + */ > > +enum rte_eth_fdir_tunnel_type { > > + RTE_FDIR_TUNNEL_TYPE_NVGRE =3D 0, > > + RTE_FDIR_TUNNEL_TYPE_VXLAN, > > + RTE_FDIR_TUNNEL_TYPE_UNKNOWN, > > +}; > > + > > +/** > > + * A structure used to define the input for tunnel flow, now it's > > +VxLAN or > > + * NVGRE > > + */ > > +struct rte_eth_tunnel_flow { > > + enum rte_eth_fdir_tunnel_type tunnel_type; /**< Tunnel type to > match. */ > > + uint32_t tunnel_id; /**< Tunnel ID to match. T= NI, VNI... > */ > > + struct ether_addr mac_addr; /**< Mac address to match.= */ > > +}; > > + > > +/** > > * An union contains the inputs for all types of flow > > */ > > union rte_eth_fdir_flow { > > - struct rte_eth_l2_flow l2_flow; > > - struct rte_eth_udpv4_flow udp4_flow; > > - struct rte_eth_tcpv4_flow tcp4_flow; > > - struct rte_eth_sctpv4_flow sctp4_flow; > > - struct rte_eth_ipv4_flow ip4_flow; > > - struct rte_eth_udpv6_flow udp6_flow; > > - struct rte_eth_tcpv6_flow tcp6_flow; > > - struct rte_eth_sctpv6_flow sctp6_flow; > > - struct rte_eth_ipv6_flow ipv6_flow; > > + struct rte_eth_l2_flow l2_flow; > > + struct rte_eth_udpv4_flow udp4_flow; > > + struct rte_eth_tcpv4_flow tcp4_flow; > > + struct rte_eth_sctpv4_flow sctp4_flow; > > + struct rte_eth_ipv4_flow ip4_flow; > > + struct rte_eth_udpv6_flow udp6_flow; > > + struct rte_eth_tcpv6_flow tcp6_flow; > > + struct rte_eth_sctpv6_flow sctp6_flow; > > + struct rte_eth_ipv6_flow ipv6_flow; > > + struct rte_eth_mac_vlan_flow mac_vlan_flow; > > + struct rte_eth_tunnel_flow tunnel_flow; >=20 > Can you please minimize the whitespace changes here. It looks in the diff > like you are replacing the entire set of entries, but on closer inspectio= n it > looks like you are just adding in two extra lines. Using vi or other editing tools, we can see all this fields are aligned. I = think it's worth to keep it.=20 >=20 > > }; > > > > /** > > @@ -465,6 +504,9 @@ struct rte_eth_fdir_masks { > > struct rte_eth_ipv6_flow ipv6_mask; > > uint16_t src_port_mask; > > uint16_t dst_port_mask; > > + uint8_t mac_addr_byte_mask; /** Per byte MAC address mask */ > > + uint32_t tunnel_id_mask; /** tunnel ID mask */ > > + uint8_t tunnel_type_mask; > > }; > > > > /** > > @@ -515,15 +557,6 @@ struct rte_eth_fdir_flex_conf { > > /**< Flex mask configuration for each flow type */ }; > > > > -/** > > - * Flow Director setting modes: none, signature or perfect. > > - */ > > -enum rte_fdir_mode { > > - RTE_FDIR_MODE_NONE =3D 0, /**< Disable FDIR support. */ > > - RTE_FDIR_MODE_SIGNATURE, /**< Enable FDIR signature filter > mode. */ > > - RTE_FDIR_MODE_PERFECT, /**< Enable FDIR perfect filter mode. > */ > > -}; > > - > > #define UINT32_BIT (CHAR_BIT * sizeof(uint32_t)) #define > > RTE_FLOW_MASK_ARRAY_SIZE \ > > (RTE_ALIGN(RTE_ETH_FLOW_MAX, UINT32_BIT)/UINT32_BIT) > > -- > > 1.9.3 > >