From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 583C7A6A for ; Fri, 23 Oct 2015 14:55:58 +0200 (CEST) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga102.jf.intel.com with ESMTP; 23 Oct 2015 05:55:57 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.20,186,1444719600"; d="scan'208";a="801109192" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by orsmga001.jf.intel.com with ESMTP; 23 Oct 2015 05:55:57 -0700 Received: from FMSMSX110.amr.corp.intel.com (10.18.116.10) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.248.2; Fri, 23 Oct 2015 05:55:56 -0700 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by fmsmsx110.amr.corp.intel.com (10.18.116.10) with Microsoft SMTP Server (TLS) id 14.3.248.2; Fri, 23 Oct 2015 05:55:56 -0700 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.253]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.47]) with mapi id 14.03.0248.002; Fri, 23 Oct 2015 20:55:54 +0800 From: "Lu, Wenzhuo" To: "Chilikin, Andrey" , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH v4 1/7] lib/librte_ether: modify the structures for fdir new modes Thread-Index: AQHRDX8UOBm5HuHvzUCbniRqIuNdR555B8Sw Date: Fri, 23 Oct 2015 12:55:53 +0000 Message-ID: <6A0DE07E22DDAD4C9103DF62FEBC0909020A2228@shsmsx102.ccr.corp.intel.com> References: <1443161125-1035-1-git-send-email-wenzhuo.lu@intel.com> <1445566690-15767-1-git-send-email-wenzhuo.lu@intel.com> <1445566690-15767-2-git-send-email-wenzhuo.lu@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsIiwiaWQiOiI0ODIwMjYyNS00OWM4LTRjZGItYjAyNC0wOGQ4YzBlMDVjYTYiLCJwcm9wcyI6W3sibiI6IkludGVsRGF0YUNsYXNzaWZpY2F0aW9uIiwidmFscyI6W3sidmFsdWUiOiJDVFBfUFVCTElDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjQuMTAuMTkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiRXFJOTB6bGRRNXplaXAxNlVLYnEzTU00Y2IwamNwSWh3MEc1VExidXhwZz0ifQ== x-inteldataclassification: CTP_PUBLIC x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v4 1/7] lib/librte_ether: modify the structures for fdir new modes X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 23 Oct 2015 12:55:59 -0000 Hi Andrey, > -----Original Message----- > From: Chilikin, Andrey > Sent: Friday, October 23, 2015 6:39 PM > To: Lu, Wenzhuo; dev@dpdk.org > Subject: RE: [dpdk-dev] [PATCH v4 1/7] lib/librte_ether: modify the struc= tures > for fdir new modes >=20 > I would suggest rearranging members of rte_eth_fdir_tunnel_type to set > RTE_FDIR_TUNNEL_TYPE_UNKNOWN=3D0 so any global/static variables or > variables after memset(0) would have unknown type. Sounds good. I follow the datasheet to set the tunnel type value, but your = idea looks better :) >=20 > Regards, > Andrey >=20 > > -----Original Message----- > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Wenzhuo Lu > > Sent: Friday, October 23, 2015 3:18 AM > > To: dev@dpdk.org > > Subject: [dpdk-dev] [PATCH v4 1/7] lib/librte_ether: modify the > > structures for fdir new modes > > > > Define the new modes and modify the filter and mask structures for the > > mac vlan and tunnel modes. > > > > Signed-off-by: Wenzhuo Lu > > --- > > lib/librte_ether/rte_eth_ctrl.h | 51 > > +++++++++++++++++++++++++++++++++---- > > ---- > > 1 file changed, 42 insertions(+), 9 deletions(-) > > > > diff --git a/lib/librte_ether/rte_eth_ctrl.h > > b/lib/librte_ether/rte_eth_ctrl.h index 26b7b33..cf32814 100644 > > --- a/lib/librte_ether/rte_eth_ctrl.h > > +++ b/lib/librte_ether/rte_eth_ctrl.h > > @@ -377,18 +377,46 @@ struct rte_eth_sctpv6_flow { }; > > > > /** > > + * A structure used to define the input for MAC VLAN flow */ struct > > +rte_eth_mac_vlan_flow { > > + struct ether_addr mac_addr; /**< Mac address to match. */ }; > > + > > +/** > > + * Tunnel type for flow director. > > + */ > > +enum rte_eth_fdir_tunnel_type { > > + RTE_FDIR_TUNNEL_TYPE_NVGRE =3D 0, > > + RTE_FDIR_TUNNEL_TYPE_VXLAN, > > + RTE_FDIR_TUNNEL_TYPE_UNKNOWN, > > +}; > > + > > +/** > > + * A structure used to define the input for tunnel flow, now it's > > +VxLAN or > > + * NVGRE > > + */ > > +struct rte_eth_tunnel_flow { > > + enum rte_eth_fdir_tunnel_type tunnel_type; /**< Tunnel type to > > match. */ > > + uint32_t tunnel_id; /**< Tunnel ID to match. T= NI, VNI... > > */ > > + struct ether_addr mac_addr; /**< Mac address to match.= */ > > +}; > > + > > +/** > > * An union contains the inputs for all types of flow > > */ > > union rte_eth_fdir_flow { > > - struct rte_eth_l2_flow l2_flow; > > - struct rte_eth_udpv4_flow udp4_flow; > > - struct rte_eth_tcpv4_flow tcp4_flow; > > - struct rte_eth_sctpv4_flow sctp4_flow; > > - struct rte_eth_ipv4_flow ip4_flow; > > - struct rte_eth_udpv6_flow udp6_flow; > > - struct rte_eth_tcpv6_flow tcp6_flow; > > - struct rte_eth_sctpv6_flow sctp6_flow; > > - struct rte_eth_ipv6_flow ipv6_flow; > > + struct rte_eth_l2_flow l2_flow; > > + struct rte_eth_udpv4_flow udp4_flow; > > + struct rte_eth_tcpv4_flow tcp4_flow; > > + struct rte_eth_sctpv4_flow sctp4_flow; > > + struct rte_eth_ipv4_flow ip4_flow; > > + struct rte_eth_udpv6_flow udp6_flow; > > + struct rte_eth_tcpv6_flow tcp6_flow; > > + struct rte_eth_sctpv6_flow sctp6_flow; > > + struct rte_eth_ipv6_flow ipv6_flow; > > + struct rte_eth_mac_vlan_flow mac_vlan_flow; > > + struct rte_eth_tunnel_flow tunnel_flow; > > }; > > > > /** > > @@ -465,6 +493,9 @@ struct rte_eth_fdir_masks { > > struct rte_eth_ipv6_flow ipv6_mask; > > uint16_t src_port_mask; > > uint16_t dst_port_mask; > > + uint8_t mac_addr_byte_mask; /** Per byte MAC address mask */ > > + uint32_t tunnel_id_mask; /** tunnel ID mask */ > > + uint8_t tunnel_type_mask; > > }; > > > > /** > > @@ -522,6 +553,8 @@ enum rte_fdir_mode { > > RTE_FDIR_MODE_NONE =3D 0, /**< Disable FDIR support. */ > > RTE_FDIR_MODE_SIGNATURE, /**< Enable FDIR signature filter > > mode. */ > > RTE_FDIR_MODE_PERFECT, /**< Enable FDIR perfect filter mode. > > */ > > + RTE_FDIR_MODE_PERFECT_MAC_VLAN, /**< Enable FDIR filter mode > > - MAC VLAN. */ > > + RTE_FDIR_MODE_PERFECT_TUNNEL, /**< Enable FDIR filter mode - > > tunnel. */ > > }; > > > > #define UINT32_BIT (CHAR_BIT * sizeof(uint32_t)) > > -- > > 1.9.3