From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 5C8D236E for ; Mon, 1 Feb 2016 03:59:17 +0100 (CET) Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga102.jf.intel.com with ESMTP; 31 Jan 2016 18:59:16 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.22,378,1449561600"; d="scan'208";a="738039850" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by orsmga003.jf.intel.com with ESMTP; 31 Jan 2016 18:59:18 -0800 Received: from fmsmsx112.amr.corp.intel.com (10.18.116.6) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.248.2; Sun, 31 Jan 2016 18:59:15 -0800 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by FMSMSX112.amr.corp.intel.com (10.18.116.6) with Microsoft SMTP Server (TLS) id 14.3.248.2; Sun, 31 Jan 2016 18:59:14 -0800 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.172]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.209]) with mapi id 14.03.0248.002; Mon, 1 Feb 2016 10:59:13 +0800 From: "Lu, Wenzhuo" To: Stephen Hemminger Thread-Topic: [PATCH] igb: set default thresholds correctly based on mac type Thread-Index: AQHRVLWes2FCsNtQ4UGZvrxwhISYgZ8WjqCw Date: Mon, 1 Feb 2016 02:59:13 +0000 Message-ID: <6A0DE07E22DDAD4C9103DF62FEBC09090342613B@shsmsx102.ccr.corp.intel.com> References: <1453426717-2522-1-git-send-email-stephen@networkplumber.org> In-Reply-To: <1453426717-2522-1-git-send-email-stephen@networkplumber.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH] igb: set default thresholds correctly based on mac type X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 01 Feb 2016 02:59:17 -0000 > -----Original Message----- > From: Stephen Hemminger [mailto:stephen@networkplumber.org] > Sent: Friday, January 22, 2016 9:39 AM > To: Lu, Wenzhuo > Cc: dev@dpdk.org; Stephen Hemminger > Subject: [PATCH] igb: set default thresholds correctly based on mac type >=20 > This brings the DPDK igb driver inline with the behavior used by the curr= ent Linux > driver. The IGB hardware has several different MAC types and the threshol= d > values that work vary based on the hardware. >=20 > Since DPDK 1.8 it has been up to devices to provide the correct default > configuration parameter. But the igb driver gives values that are broken = on > some devices, and always causes a warning message at startup. >=20 > Please test this on real hardware, I don't have the luxury of a hardware = lab full > of variations of this chip. >=20 > Signed-off-by: Stephen Hemminger Acked-by: Wenzhuo Lu