From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 2EEB3377E for ; Mon, 1 Feb 2016 04:01:09 +0100 (CET) Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga102.fm.intel.com with ESMTP; 31 Jan 2016 19:01:08 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.22,378,1449561600"; d="scan'208";a="893473298" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by fmsmga001.fm.intel.com with ESMTP; 31 Jan 2016 19:01:08 -0800 Received: from fmsmsx121.amr.corp.intel.com (10.18.125.36) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.248.2; Sun, 31 Jan 2016 19:01:08 -0800 Received: from shsmsx103.ccr.corp.intel.com (10.239.110.14) by fmsmsx121.amr.corp.intel.com (10.18.125.36) with Microsoft SMTP Server (TLS) id 14.3.248.2; Sun, 31 Jan 2016 19:01:07 -0800 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.172]) by SHSMSX103.ccr.corp.intel.com ([169.254.4.218]) with mapi id 14.03.0248.002; Mon, 1 Feb 2016 11:00:58 +0800 From: "Lu, Wenzhuo" To: Yuanhan Liu Thread-Topic: [dpdk-dev] [PATCH 0/8] support E-tag offloading and forwarding on Intel X550 NIC Thread-Index: AQHRWmNWWwijwDv6506hljYJ7HpcTJ8WY8FA//+EOgCAAIq3cP//fLgAgACVRrA= Date: Mon, 1 Feb 2016 03:00:58 +0000 Message-ID: <6A0DE07E22DDAD4C9103DF62FEBC090903426153@shsmsx102.ccr.corp.intel.com> References: <1454051035-25757-1-git-send-email-wenzhuo.lu@intel.com> <533710CFB86FA344BFBF2D6802E6028622F260A3@SHSMSX101.ccr.corp.intel.com> <6A0DE07E22DDAD4C9103DF62FEBC09090342601B@shsmsx102.ccr.corp.intel.com> <20160201013948.GZ4257@yliu-dev.sh.intel.com> <6A0DE07E22DDAD4C9103DF62FEBC09090342608B@shsmsx102.ccr.corp.intel.com> <20160201020624.GA4257@yliu-dev.sh.intel.com> In-Reply-To: <20160201020624.GA4257@yliu-dev.sh.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH 0/8] support E-tag offloading and forwarding on Intel X550 NIC X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 01 Feb 2016 03:01:09 -0000 Hi Yuanhan, > -----Original Message----- > From: Yuanhan Liu [mailto:yuanhan.liu@linux.intel.com] > Sent: Monday, February 1, 2016 10:06 AM > To: Lu, Wenzhuo > Cc: Qiu, Michael; dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH 0/8] support E-tag offloading and forwardi= ng on > Intel X550 NIC >=20 > On Mon, Feb 01, 2016 at 01:56:32AM +0000, Lu, Wenzhuo wrote: > > Hi Yuanhan, > > > > > -----Original Message----- > > > From: Yuanhan Liu [mailto:yuanhan.liu@linux.intel.com] > > > Sent: Monday, February 1, 2016 9:40 AM > > > To: Lu, Wenzhuo > > > Cc: Qiu, Michael; dev@dpdk.org > > > Subject: Re: [dpdk-dev] [PATCH 0/8] support E-tag offloading and > > > forwarding on Intel X550 NIC > > > > > > On Mon, Feb 01, 2016 at 01:04:52AM +0000, Lu, Wenzhuo wrote: > > > > Hi, > > > > > > > > > -----Original Message----- > > > > > From: Qiu, Michael > > > > > Sent: Friday, January 29, 2016 3:16 PM > > > > > To: Lu, Wenzhuo; dev@dpdk.org > > > > > Subject: Re: [dpdk-dev] [PATCH 0/8] support E-tag offloading and > > > > > forwarding on Intel X550 NIC > > > > > > > > > > Hi, Wenzhuo > > > > > > > > > > Better to explain what E-tag is, so that reviewers could known it= . > > > > Yes, it's better. But not sure where should I add this info. In > > > > release note or just > > > cover letter? Any suggestion? Thanks. > > > > > > It should be done in the first patch introduced E-tag, so that it > > > will be in the git log history. And of course, it does no harm at > > > all to mention (briefly) it again in cover letter, so that > > > reviewer/maintainer has a brief understanding of your whole patchset = first. > > > > > > --yliu > > Thanks for the suggestion! >=20 > Welcome! Another side note is that, as suggested (and asked) by Thomas, > release note should not be done in a standalone patch, but instead, in th= e patch > that enables it. Which is to say, you should squash patch 8 to patch 7 he= re. >=20 > --yliu Thanks for the reminder!