From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 16E058D8B for ; Wed, 3 Feb 2016 02:05:25 +0100 (CET) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga101.jf.intel.com with ESMTP; 02 Feb 2016 17:05:25 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.22,387,1449561600"; d="scan'208";a="646208978" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by FMSMGA003.fm.intel.com with ESMTP; 02 Feb 2016 17:05:24 -0800 Received: from fmsmsx157.amr.corp.intel.com (10.18.116.73) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.248.2; Tue, 2 Feb 2016 17:05:24 -0800 Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by FMSMSX157.amr.corp.intel.com (10.18.116.73) with Microsoft SMTP Server (TLS) id 14.3.248.2; Tue, 2 Feb 2016 17:05:23 -0800 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.172]) by SHSMSX101.ccr.corp.intel.com ([169.254.1.215]) with mapi id 14.03.0248.002; Wed, 3 Feb 2016 09:05:21 +0800 From: "Lu, Wenzhuo" To: "Richardson, Bruce" Thread-Topic: [dpdk-dev] [PATCH v2 2/7] lib/librte_ether: support l2 tunnel config Thread-Index: AQHRXYb23hDzdqk7eUS50cv0vAOTdp8YIkqAgAFd7kA= Date: Wed, 3 Feb 2016 01:05:21 +0000 Message-ID: <6A0DE07E22DDAD4C9103DF62FEBC090903427064@shsmsx102.ccr.corp.intel.com> References: <1454051035-25757-1-git-send-email-wenzhuo.lu@intel.com> <1454396225-11784-1-git-send-email-wenzhuo.lu@intel.com> <1454396225-11784-3-git-send-email-wenzhuo.lu@intel.com> <20160202120329.GA22024@bricha3-MOBL3> In-Reply-To: <20160202120329.GA22024@bricha3-MOBL3> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH v2 2/7] lib/librte_ether: support l2 tunnel config X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 03 Feb 2016 01:05:26 -0000 Hi Bruce, > -----Original Message----- > From: Richardson, Bruce > Sent: Tuesday, February 2, 2016 8:03 PM > To: Lu, Wenzhuo > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v2 2/7] lib/librte_ether: support l2 tunne= l config >=20 > On Tue, Feb 02, 2016 at 02:57:00PM +0800, Wenzhuo Lu wrote: > > Add functions to support l2 tunnel configuration. > > The support includes ether type modification and the tunnel support > > enabling/disabling. > > Ether type modification means modifying the ether type of a specific > > type of tunnel. So the packet with this ether type will be parsed as > > this type of tunnel. > > Enabling/disabling a tunnel support means enabling/disabling the > > ability of parsing the specific type of tunnel. This ability should be > > enabled before we enable filtering, forwarding, offloading for this > > specific type of tunnel. > > Only support e-tag tunnel now. > > > > E-tag introduction, > > E-tag means external tag which is defined in IEEEE 802.1BR > > specification. > > E-tag is a kind of l2 tunnel. It means a tag will be inserted in the > > l2 header. Like below, > > |31 24|23 16|15 8|7 0| > > 0| Destination MAC address | > > 4| Dest MAC address(cont.) | Src MAC address | > > 8| Source MAC address(cont.) | > > 12| E-tag Etherenet type (0x893f) | E-tag header | > > 16| E-tag header(cont.) | > > 20| VLAN Ethertype(optional) | VLAN header(optional) | > > 24| Original type | ...... | > > ...| ...... | > > The E-tag format is like below, > > |0 15|16 18|19 |20 31| > > | Ethertype - 0x893f | E-PCP |DEI| Ingress E-CID_base | > > > > |32 33|34 35|36 47|48 55 |56 63| > > | RSV | GRP |E-CID_base|Ingress_E-CID_ext| E-CID_ext | > > > > The Ingess_E-CID_ext and E-CID_ext are always zero for endpoints and > > are effectively reserved. > > > > The more details of E-tag is in IEEE 802.1BR. 802.1BR is used to > > replace 802.1Qbh. 802.1BR is a standard for Bridge Port Extension. > > It specifies the operation of Bridge Port Extenders, including > > management, protocols, and algorithms. Bridge Port Extenders operate > > in support of the MAC Service by Extended Bridges. > > The E-tag is added to l2 header to identify the VM channel and the > > virtual port. > > > > Signed-off-by: Wenzhuo Lu >=20 > Your introduction to e-tag needs to be in patch 1 rather than 2, and in t= he cover > letter, since both those earlier mails reference it. > Furthermore, it would be better if you could link to a web description of= the e- > tag rather than try and explain it all in a commit message. Diagrams also= work > better on a web-page. O, my bad. I thought the patch 1 doesn't have something to do with E-tag di= rectly. But I do mention E-tag in the patch V1. Thanks for the comments. I'll create a V3. >=20 > /Bruce