From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 2F8DC95DC for ; Sun, 14 Feb 2016 03:33:12 +0100 (CET) Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga102.jf.intel.com with ESMTP; 13 Feb 2016 18:33:11 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.22,443,1449561600"; d="scan'208";a="911621562" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by orsmga002.jf.intel.com with ESMTP; 13 Feb 2016 18:33:11 -0800 Received: from fmsmsx151.amr.corp.intel.com (10.18.125.4) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.248.2; Sat, 13 Feb 2016 18:33:10 -0800 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by FMSMSX151.amr.corp.intel.com (10.18.125.4) with Microsoft SMTP Server (TLS) id 14.3.248.2; Sat, 13 Feb 2016 18:33:04 -0800 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.172]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.209]) with mapi id 14.03.0248.002; Sun, 14 Feb 2016 10:33:02 +0800 From: "Lu, Wenzhuo" To: "Richardson, Bruce" Thread-Topic: [dpdk-dev] [PATCH 00/12] update ixgbe base driver Thread-Index: AQHRUmPlhynTimhK8UeyvvMju5j3NJ8nDjcAgAPs4qA= Date: Sun, 14 Feb 2016 02:33:02 +0000 Message-ID: <6A0DE07E22DDAD4C9103DF62FEBC09090342A3FE@shsmsx102.ccr.corp.intel.com> References: <1453171693-25571-1-git-send-email-wenzhuo.lu@intel.com> <20160211223548.GA19068@bricha3-MOBL3> In-Reply-To: <20160211223548.GA19068@bricha3-MOBL3> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH 00/12] update ixgbe base driver X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 14 Feb 2016 02:33:12 -0000 Hi Bruce,=20 > -----Original Message----- > From: Richardson, Bruce > Sent: Friday, February 12, 2016 6:36 AM > To: Lu, Wenzhuo > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH 00/12] update ixgbe base driver >=20 > On Tue, Jan 19, 2016 at 10:48:01AM +0800, Wenzhuo Lu wrote: > > *add new devices and mac type > > *use PHY token for X550EM_a > > *set VF mac address only when acked by PF *always turn PHY power on > > when requested *add definition of a register for mac SGMII busy > > *support fuse for both x550em_x V1 and V2 *remove duplicate setting > > for fdir no match drop *consolidate MDIO speed-setting *use link > > instead of I2C combined abstraction > > > > > > Wenzhuo Lu (12): > > ixgbe/base: update readme > > ixgbe/base: add new devices and mac type > > ixgeb/base: use PHY token for X550EM_a > > ixgbe/base: set VF mac address only when acked by PF > > ixgbe/base: always turn PHY power on when requested > > ixgbe/base: add definition of a register for mac SGMII busy > > ixgbe/base: support fuse for both x550em_x V1 and V2 > > ixgbe/base: remove duplicate setting for fdir no match drop > > ixgbe/base: consolidate MDIO speed-setting > > ixgbe/base: use link instead of I2C combined abstraction > > ixgbe: support new devices and mac types > > doc: update release note for ixgbe base code update > > > Hi Wenzhuo >=20 > Thanks for this patchset. Just some feedback on it. >=20 > * Can you please take the new features etc. called out in the doc patch a= nd just > add the RN update as part of the patch adding the feature itself. Those a= dditions > that were part of a previous base code update (presumably part of a previ= ous > release) shouldn't go in the latest release notes. There shouldn't need t= o be a > separate doc patch in this set. > * The order of the patches could do with being changed. I'd suggest havin= g the > readme updated as the last of the base code update series, right before t= he > ixgbe patch. > * The "new devices and mac types" patch, only seems to add one new device > type, so I'd call it out explicitly in the title. > * The X550em_x V1/V2 patch is similarly adding new device support so shou= ld go > alongside the other new device patch. I'd suggest titling both patches si= milarly > e.g. > ixgbe/base: add x550em_a device support > ixgbe/base: add x550em_x V2 device support >=20 > * Some of the titles are a bit long or are not a great summary of the pri= mary > purpose of the patch. For example: "always turn PHY power on when request= ed" > might be better titled: "ignore manageability for phy power on". >=20 > Can you maybe send out a V2 with the above changes taken into account - > especially the release note split? Sure, I'll send a V2. Thanks for the comments. >=20 > Thanks, > /Bruce