From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <wenzhuo.lu@intel.com>
Received: from mga03.intel.com (mga03.intel.com [134.134.136.65])
 by dpdk.org (Postfix) with ESMTP id C68C62C22
 for <dev@dpdk.org>; Mon,  7 Mar 2016 06:29:46 +0100 (CET)
Received: from fmsmga004.fm.intel.com ([10.253.24.48])
 by orsmga103.jf.intel.com with ESMTP; 06 Mar 2016 21:29:45 -0800
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.22,549,1449561600"; d="scan'208";a="61114050"
Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203])
 by fmsmga004.fm.intel.com with ESMTP; 06 Mar 2016 21:29:45 -0800
Received: from shsmsx103.ccr.corp.intel.com (10.239.4.69) by
 FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS)
 id 14.3.248.2; Sun, 6 Mar 2016 21:29:45 -0800
Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.232]) by
 SHSMSX103.ccr.corp.intel.com ([169.254.4.24]) with mapi id 14.03.0248.002;
 Mon, 7 Mar 2016 13:29:43 +0800
From: "Lu, Wenzhuo" <wenzhuo.lu@intel.com>
To: "Wu, Jingjing" <jingjing.wu@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Thread-Topic: [dpdk-dev] [PATCH v5 5/7] lib/librte_ether: support new l2
 tunnel	operation
Thread-Index: AQHReCGBjsJwrul9EE+XyWbIHM9sp59NdBSg
Date: Mon, 7 Mar 2016 05:29:43 +0000
Message-ID: <6A0DE07E22DDAD4C9103DF62FEBC0909034384B5@shsmsx102.ccr.corp.intel.com>
References: <1454051035-25757-1-git-send-email-wenzhuo.lu@intel.com>
 <1457318568-28797-1-git-send-email-wenzhuo.lu@intel.com>
 <1457318568-28797-6-git-send-email-wenzhuo.lu@intel.com>
 <9BB6961774997848B5B42BEC655768F8DCF2EC@SHSMSX104.ccr.corp.intel.com>
In-Reply-To: <9BB6961774997848B5B42BEC655768F8DCF2EC@SHSMSX104.ccr.corp.intel.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [10.239.127.40]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Subject: Re: [dpdk-dev] [PATCH v5 5/7] lib/librte_ether: support new l2
 tunnel	operation
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Mon, 07 Mar 2016 05:29:47 -0000

Hi Jingjing,
>=20
> How about to merge the above six APIs
> rte_eth_dev_l2_tunnel_XXX_enable/disable
> to one, may call rte_eth_dev_l2_tunnel_offload_set?
> Just like the rte_eth_dev_set_vlan_offload.
Good suggestion. I'll do it.

>=20
>=20
> Pool is used here, but vf_id is used above. Suggest to put such arguments=
 into
> structure, maybe in l2_tunnel.
Agree, seems better. I'll send a new version.

>=20
> Thanks
> Jingjing