From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <wenzhuo.lu@intel.com>
Received: from mga14.intel.com (mga14.intel.com [192.55.52.115])
 by dpdk.org (Postfix) with ESMTP id E5D762C5F
 for <dev@dpdk.org>; Wed,  9 Mar 2016 03:30:23 +0100 (CET)
Received: from fmsmga003.fm.intel.com ([10.253.24.29])
 by fmsmga103.fm.intel.com with ESMTP; 08 Mar 2016 18:30:23 -0800
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.22,559,1449561600"; d="scan'208";a="666191607"
Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205])
 by FMSMGA003.fm.intel.com with ESMTP; 08 Mar 2016 18:30:22 -0800
Received: from fmsmsx120.amr.corp.intel.com (10.18.124.208) by
 fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS)
 id 14.3.248.2; Tue, 8 Mar 2016 18:30:22 -0800
Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by
 fmsmsx120.amr.corp.intel.com (10.18.124.208) with Microsoft SMTP Server (TLS)
 id 14.3.248.2; Tue, 8 Mar 2016 18:30:22 -0800
Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.232]) by
 SHSMSX152.ccr.corp.intel.com ([169.254.6.42]) with mapi id 14.03.0248.002;
 Wed, 9 Mar 2016 10:30:20 +0800
From: "Lu, Wenzhuo" <wenzhuo.lu@intel.com>
To: "Lu, Wenzhuo" <wenzhuo.lu@intel.com>, Thomas Monjalon
 <thomas.monjalon@6wind.com>
Thread-Topic: [dpdk-dev] [PATCH v7 1/5] lib/librte_ether: change function
 name of tunnel port config
Thread-Index: AQHRdb6HSEZhGhtjgEeRWxn0VKdpBZ9PtLUAgACYBSD//4DagIAAidSAgAAT/8A=
Date: Wed, 9 Mar 2016 02:30:19 +0000
Message-ID: <6A0DE07E22DDAD4C9103DF62FEBC0909034391F3@shsmsx102.ccr.corp.intel.com>
References: <1452496044-17524-1-git-send-email-wenzhuo.lu@intel.com>
 <1916349.pcHeyTKjoM@xps13>
 <6A0DE07E22DDAD4C9103DF62FEBC090903439160@shsmsx102.ccr.corp.intel.com>
 <35564540.2poe2s7h25@xps13>
 <6A0DE07E22DDAD4C9103DF62FEBC0909034391B9@shsmsx102.ccr.corp.intel.com>
In-Reply-To: <6A0DE07E22DDAD4C9103DF62FEBC0909034391B9@shsmsx102.ccr.corp.intel.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [10.239.127.40]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v7 1/5] lib/librte_ether: change function
 name of tunnel port config
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 09 Mar 2016 02:30:24 -0000

Hi Thomas,

> > > >
> > > > You must move it below the doxygen comment.
> > > OK. Honestly, I'd like to act like that. But seems the style is to
> > > put the function above the comment.(Don't know the reason.)
> >
> > Do you mean the function below the comment?
> No, I really mean above. Like this,
> typedef int (*eth_get_reg_t)(struct rte_eth_dev *dev,
> 				struct rte_dev_reg_info *info);
> /**< @internal Retrieve registers  */
>=20
> typedef int (*eth_get_eeprom_length_t)(struct rte_eth_dev *dev); /**<
> @internal Retrieve eeprom size  */
>=20
> typedef int (*eth_get_eeprom_t)(struct rte_eth_dev *dev,
> 				struct rte_dev_eeprom_info *info);
> /**< @internal Retrieve eeprom data  */
>=20
> typedef int (*eth_set_eeprom_t)(struct rte_eth_dev *dev,
> 				struct rte_dev_eeprom_info *info);
> /**< @internal Program eeprom data  */
Sorry, I misunderstood you. I'll do what you suggested.