From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id D83C22BA2 for ; Thu, 10 Mar 2016 01:37:32 +0100 (CET) Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga102.jf.intel.com with ESMTP; 09 Mar 2016 16:37:07 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.24,313,1455004800"; d="scan'208";a="761301893" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by orsmga003.jf.intel.com with ESMTP; 09 Mar 2016 16:37:07 -0800 Received: from fmsmsx123.amr.corp.intel.com (10.18.125.38) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.248.2; Wed, 9 Mar 2016 16:37:06 -0800 Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by fmsmsx123.amr.corp.intel.com (10.18.125.38) with Microsoft SMTP Server (TLS) id 14.3.248.2; Wed, 9 Mar 2016 16:37:06 -0800 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.232]) by SHSMSX101.ccr.corp.intel.com ([169.254.1.136]) with mapi id 14.03.0248.002; Thu, 10 Mar 2016 08:37:04 +0800 From: "Lu, Wenzhuo" To: Thomas Monjalon Thread-Topic: [dpdk-dev] [PATCH v7 1/5] lib/librte_ether: change function name of tunnel port config Thread-Index: AQHRdb6HSEZhGhtjgEeRWxn0VKdpBZ9PtLUAgACYBSD//4DagIAAidSAgAAEGYCAAYLS8A== Date: Thu, 10 Mar 2016 00:37:04 +0000 Message-ID: <6A0DE07E22DDAD4C9103DF62FEBC0909034399CE@shsmsx102.ccr.corp.intel.com> References: <1452496044-17524-1-git-send-email-wenzhuo.lu@intel.com> <35564540.2poe2s7h25@xps13> <6A0DE07E22DDAD4C9103DF62FEBC0909034391B9@shsmsx102.ccr.corp.intel.com> <4446254.25Q6ds7RWu@xps13> In-Reply-To: <4446254.25Q6ds7RWu@xps13> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH v7 1/5] lib/librte_ether: change function name of tunnel port config X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 10 Mar 2016 00:37:33 -0000 Hi Thomas, > -----Original Message----- > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > Sent: Wednesday, March 9, 2016 5:32 PM > To: Lu, Wenzhuo > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v7 1/5] lib/librte_ether: change function = name > of tunnel port config >=20 > 2016-03-09 01:25, Lu, Wenzhuo: > > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > > > 2016-03-09 00:53, Lu, Wenzhuo: > > > > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > > > > > 2016-03-04 10:35, Wenzhuo Lu: > > > > > > The names of function for tunnel port configuration are not acc= urate. > > > > > > They're tunnel_add/del, better change them to tunnel_port_add/d= el. > > > > > > > > > > As a lot of ethdev API, it is really badly documented. > > > > > > > > > > Please explain why this renaming and let's try to reword the > > > > > doxygen: > > > > > * Add UDP tunneling port of an Ethernet device for filtering a > > > > > specific > > > > > * tunneling packet by UDP port number. > > > > > > > > As we discussed before, these APIs only change the UDP port value > > > > of the > > > tunnel. > > > > But according to their names, seems like they're trying to > > > > add/delete a whole > > > tunnel. > > > > The names don't tell us what the functions really do, so we want > > > > to change the > > > names. > > > > > > Neither the comment nor the name explain what means filtering here. > > > I think we should explain more. > > > We add a port number and a protocol type. What is it made for? > > > > Prot_type means the tunnel type, VxLAN, GENEVE.., actually it's > rte_eth_tunnel_type. > > Udp_port means the UDP port value used for the specific type of tunnel. > > I'll add some comments in the structure. >=20 > OK but we really need you explain in the doxygen what the NIC is expected= to do > with these informations. I think it's so clear in your head that you don'= t think the > users don't understand what the tunnel offloading means. I'll add more info here. Thanks.