From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id CCA702BA2 for ; Thu, 10 Mar 2016 01:41:07 +0100 (CET) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga103.fm.intel.com with ESMTP; 09 Mar 2016 16:41:06 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.24,313,1455004800"; d="scan'208";a="906524132" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by orsmga001.jf.intel.com with ESMTP; 09 Mar 2016 16:41:06 -0800 Received: from fmsmsx124.amr.corp.intel.com (10.18.125.39) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.248.2; Wed, 9 Mar 2016 16:41:06 -0800 Received: from shsmsx104.ccr.corp.intel.com (10.239.110.15) by fmsmsx124.amr.corp.intel.com (10.18.125.39) with Microsoft SMTP Server (TLS) id 14.3.248.2; Wed, 9 Mar 2016 16:41:06 -0800 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.232]) by SHSMSX104.ccr.corp.intel.com ([169.254.5.132]) with mapi id 14.03.0248.002; Thu, 10 Mar 2016 08:40:58 +0800 From: "Lu, Wenzhuo" To: Thomas Monjalon Thread-Topic: [dpdk-dev] [PATCH v8 1/5] lib/librte_ether: change function name of tunnel port config Thread-Index: AQHRebS6nKHnunhDp0Ci+vRmTp1j3Z9QWESAgAF+SkA= Date: Thu, 10 Mar 2016 00:40:57 +0000 Message-ID: <6A0DE07E22DDAD4C9103DF62FEBC0909034399DE@shsmsx102.ccr.corp.intel.com> References: <1452496044-17524-1-git-send-email-wenzhuo.lu@intel.com> <1457494514-5862-1-git-send-email-wenzhuo.lu@intel.com> <1457494514-5862-2-git-send-email-wenzhuo.lu@intel.com> <1593514.bEiGrs9mO2@xps13> In-Reply-To: <1593514.bEiGrs9mO2@xps13> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH v8 1/5] lib/librte_ether: change function name of tunnel port config X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 10 Mar 2016 00:41:08 -0000 Hi Thomas, > -----Original Message----- > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > Sent: Wednesday, March 9, 2016 5:49 PM > To: Lu, Wenzhuo > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v8 1/5] lib/librte_ether: change function = name > of tunnel port config >=20 > 2016-03-09 11:35, Wenzhuo Lu: > > + uint16_t udp_port; /**< UDP port used for the tunnel. */ > > + uint8_t prot_type; /**< Tunnel type. */ >=20 > Is 42 a valid tunnel type? > Please reference where to find the constants. > Think as a user who won't read your datasheet. OK. Let me add more. Honestly, I want to change " uint8_t prot_type " to " = enum rte_eth_tunnel_type prot_type". But seems it's a ABI change, so I don= 't do that.=20 >=20 > [...] > > /** > > - * Add UDP tunneling port of an Ethernet device for filtering a > > specific > > - * tunneling packet by UDP port number. > > + * Add UDP tunneling port for a specific type of tunnel. > > + * The packets with this UDP port will be parsed as this type of tunne= l. >=20 > We progress. > What will be parsed? What will be the action? checksum? decapsulation? Let me explain more. >=20 > [...] > > int > > +rte_eth_dev_udp_tunnel_port_add(uint8_t port_id, > > + struct rte_eth_udp_tunnel > > +*tunnel_udp); > > +/* Below is deprecated. Replaced by rte_eth_dev_udp_tunnel_port_add. > > +*/ int > > rte_eth_dev_udp_tunnel_add(uint8_t port_id, > > struct rte_eth_udp_tunnel *tunnel_udp); >=20 > Better. Please make a doxygen comment with @see. > We still need a __rte_deprecated attribute on the function. Let me try to find some reference. >=20 > > --- a/lib/librte_ether/rte_ether_version.map > > +++ b/lib/librte_ether/rte_ether_version.map > > @@ -117,3 +117,10 @@ DPDK_2.2 { > > > > local: *; > > }; > > + > > +DPDK_2.3 { > > + global: > > + > > + rte_eth_dev_udp_tunnel_port_add; > > + rte_eth_dev_udp_tunnel_port_delete; > > +}DPDK_2.2; >=20 > Please rename 2.3 to 16.04. Will correct it. Thanks. >=20