From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 990F72E8E for ; Wed, 6 Apr 2016 03:41:54 +0200 (CEST) Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga102.fm.intel.com with ESMTP; 05 Apr 2016 18:41:53 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.24,445,1455004800"; d="scan'208";a="939136251" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by fmsmga001.fm.intel.com with ESMTP; 05 Apr 2016 18:41:53 -0700 Received: from fmsmsx124.amr.corp.intel.com (10.18.125.39) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.248.2; Tue, 5 Apr 2016 18:41:53 -0700 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by fmsmsx124.amr.corp.intel.com (10.18.125.39) with Microsoft SMTP Server (TLS) id 14.3.248.2; Tue, 5 Apr 2016 18:41:52 -0700 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.232]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.42]) with mapi id 14.03.0248.002; Wed, 6 Apr 2016 09:41:30 +0800 From: "Lu, Wenzhuo" To: Stephen Hemminger CC: "Zhang, Helin" , "Ananyev, Konstantin" , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH] ixgbe: cleanup whitespace and formatting issues Thread-Index: AQHRjo0VhLgKEgiuv0qx3K9BPNUAWp96jiDA//+LYwCAAhOkgA== Date: Wed, 6 Apr 2016 01:41:29 +0000 Message-ID: <6A0DE07E22DDAD4C9103DF62FEBC090903441F60@shsmsx102.ccr.corp.intel.com> References: <1459786443-27501-1-git-send-email-stephen@networkplumber.org> <6A0DE07E22DDAD4C9103DF62FEBC09090344188F@shsmsx102.ccr.corp.intel.com> <20160404185626.26c4b1fe@xeon-e3> In-Reply-To: <20160404185626.26c4b1fe@xeon-e3> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] ixgbe: cleanup whitespace and formatting issues X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 06 Apr 2016 01:41:55 -0000 Hi Stephen, > -----Original Message----- > From: Stephen Hemminger [mailto:stephen@networkplumber.org] > Sent: Tuesday, April 5, 2016 9:56 AM > To: Lu, Wenzhuo > Cc: Zhang, Helin; Ananyev, Konstantin; dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] ixgbe: cleanup whitespace and formatting > issues >=20 > On Tue, 5 Apr 2016 00:57:16 +0000 > "Lu, Wenzhuo" wrote: >=20 > > Hi Stephen, > > > > > -----Original Message----- > > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Stephen > > > Hemminger > > > Sent: Tuesday, April 5, 2016 12:14 AM > > > To: Zhang, Helin; Ananyev, Konstantin > > > Cc: dev@dpdk.org; Stephen Hemminger > > > Subject: [dpdk-dev] [PATCH] ixgbe: cleanup whitespace and formatting > > > issues > > > > > > This driver was one of the originals and has lots of little whitespac= e issues. > > > > > > PS: I know Intel doesn't like whitespace changes, there is never a > > > good time to do this, but no resuliting binary changes and it is > > > unlikely that more changes to this driver will occur this late in rel= ease cycle. > > > > > > Signed-off-by: Stephen Hemminger > > Thanks for this patch. I think it's good to make the format better :) > > But there's some checkpatch error and warnings, like this, > > ERROR: "foo* bar" should be "foo *bar" > > #508: FILE: drivers/net/ixgbe/ixgbe_ethdev.c:4256: > > +ixgbe_uc_hash_table_set(struct rte_eth_dev *dev, struct ether_addr* > > +mac_addr, > > >=20 > I didn't fix all the checkpatch errors, just the easy ones. So, If you don't object, I can try to make a new version with the checkpatc= h error/warning fixed.