From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <wenzhuo.lu@intel.com>
Received: from mga11.intel.com (mga11.intel.com [192.55.52.93])
 by dpdk.org (Postfix) with ESMTP id 2E0ED256
 for <dev@dpdk.org>; Fri, 15 Apr 2016 03:31:06 +0200 (CEST)
Received: from fmsmga001.fm.intel.com ([10.253.24.23])
 by fmsmga102.fm.intel.com with ESMTP; 14 Apr 2016 18:31:06 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.24,485,1455004800"; d="scan'208";a="945548247"
Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201])
 by fmsmga001.fm.intel.com with ESMTP; 14 Apr 2016 18:31:05 -0700
Received: from fmsmsx112.amr.corp.intel.com (10.18.116.6) by
 FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS)
 id 14.3.248.2; Thu, 14 Apr 2016 18:31:04 -0700
Received: from shsmsx103.ccr.corp.intel.com (10.239.4.69) by
 FMSMSX112.amr.corp.intel.com (10.18.116.6) with Microsoft SMTP Server (TLS)
 id 14.3.248.2; Thu, 14 Apr 2016 18:31:04 -0700
Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.232]) by
 SHSMSX103.ccr.corp.intel.com ([169.254.4.82]) with mapi id 14.03.0248.002;
 Fri, 15 Apr 2016 09:31:03 +0800
From: "Lu, Wenzhuo" <wenzhuo.lu@intel.com>
To: "Azarewicz, PiotrX T" <piotrx.t.azarewicz@intel.com>, "Zhang, Helin"
 <helin.zhang@intel.com>, "Ananyev, Konstantin" <konstantin.ananyev@intel.com>
CC: "dev@dpdk.org" <dev@dpdk.org>, "Azarewicz, PiotrX T"
 <piotrx.t.azarewicz@intel.com>
Thread-Topic: [dpdk-dev] [PATCH v1 1/1] ixgbe: fix queue stop
Thread-Index: AQHRljQ0morSdJnMikmQAfgfov729J+KP38g
Date: Fri, 15 Apr 2016 01:31:03 +0000
Message-ID: <6A0DE07E22DDAD4C9103DF62FEBC090903455895@shsmsx102.ccr.corp.intel.com>
References: <1460627970-20864-1-git-send-email-piotrx.t.azarewicz@intel.com>
In-Reply-To: <1460627970-20864-1-git-send-email-piotrx.t.azarewicz@intel.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [10.239.127.40]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Subject: Re: [dpdk-dev] [PATCH v1 1/1] ixgbe: fix queue stop
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 15 Apr 2016 01:31:06 -0000

Hi,

> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Piotr Azarewicz
> Sent: Thursday, April 14, 2016 6:00 PM
> To: Zhang, Helin; Ananyev, Konstantin
> Cc: dev@dpdk.org; Azarewicz, PiotrX T
> Subject: [dpdk-dev] [PATCH v1 1/1] ixgbe: fix queue stop
>=20
> It should be checked if queue enable bit is clear.
>=20
> CID 13215 : Wrong operator used (CONSTANT_EXPRESSION_RESULT)
> operator_confusion: txdctl | 33554432 is always 1/true regardless of the =
values
> of its operand. This occurs as the logical second operand of '&&'.
>=20
> CID 13216 : Wrong operator used (CONSTANT_EXPRESSION_RESULT)
> operator_confusion: rxdctl | 33554432 is always 1/true regardless of the =
values
> of its operand. This occurs as the logical second operand of '&&'.
>=20
> Coverity issue: 13215
> Coverity issue: 13216
> Fixes: 029fd06d40fa ("ixgbe: queue start and stop")
>=20
> Signed-off-by: Piotr Azarewicz <piotrx.t.azarewicz@intel.com>
Acked-by: Wenzhuo Lu <wenzhuo.lu@intel.com>
Sometimes machine is smarter than human :)  Thanks Piotr for handling this.