From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <wenzhuo.lu@intel.com>
Received: from mga01.intel.com (mga01.intel.com [192.55.52.88])
 by dpdk.org (Postfix) with ESMTP id 8BAA62E8E
 for <dev@dpdk.org>; Mon, 18 Apr 2016 03:57:30 +0200 (CEST)
Received: from orsmga002.jf.intel.com ([10.7.209.21])
 by fmsmga101.fm.intel.com with ESMTP; 17 Apr 2016 18:57:29 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.24,500,1455004800"; d="scan'208";a="956985779"
Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206])
 by orsmga002.jf.intel.com with ESMTP; 17 Apr 2016 18:57:29 -0700
Received: from fmsmsx157.amr.corp.intel.com (10.18.116.73) by
 FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS)
 id 14.3.248.2; Sun, 17 Apr 2016 18:57:29 -0700
Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by
 FMSMSX157.amr.corp.intel.com (10.18.116.73) with Microsoft SMTP Server (TLS)
 id 14.3.248.2; Sun, 17 Apr 2016 18:57:28 -0700
Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.232]) by
 SHSMSX101.ccr.corp.intel.com ([169.254.1.136]) with mapi id 14.03.0248.002;
 Mon, 18 Apr 2016 09:57:27 +0800
From: "Lu, Wenzhuo" <wenzhuo.lu@intel.com>
To: "Kulasek, TomaszX" <tomaszx.kulasek@intel.com>, "dev@dpdk.org"
 <dev@dpdk.org>
CC: "Zhang, Helin" <helin.zhang@intel.com>, "Ananyev, Konstantin"
 <konstantin.ananyev@intel.com>
Thread-Topic: [dpdk-dev] [PATCH] ixgbe: fix bad shift operation in
 ixgbe_set_pool_rx
Thread-Index: AQHRlxxRRsNYwUfqL0aLpQVuRTsZRp+O/ByA
Date: Mon, 18 Apr 2016 01:57:26 +0000
Message-ID: <6A0DE07E22DDAD4C9103DF62FEBC090903455FAE@shsmsx102.ccr.corp.intel.com>
References: <1460727549-4380-1-git-send-email-tomaszx.kulasek@intel.com>
In-Reply-To: <1460727549-4380-1-git-send-email-tomaszx.kulasek@intel.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [10.239.127.40]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Subject: Re: [dpdk-dev] [PATCH] ixgbe: fix bad shift operation
	in	ixgbe_set_pool_rx
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Mon, 18 Apr 2016 01:57:31 -0000

Hi Tomasz,


> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Tomasz Kulasek
> Sent: Friday, April 15, 2016 9:39 PM
> To: dev@dpdk.org
> Cc: Zhang, Helin; Ananyev, Konstantin
> Subject: [dpdk-dev] [PATCH] ixgbe: fix bad shift operation in ixgbe_set_p=
ool_rx
>=20
> CID 13193 (#1 of 1): Bad bit shift operation (BAD_SHIFT)
> large_shift: In expression 1 << pool, left shifting by more than 31 bits =
has
> undefined behavior. The shift amount, pool, is at least 32.
>=20
> This patch limits mask shift to be in range of 32 bit PFVFRE[1] register,=
 for pool >
> 31.
>=20
> Fixes: fe3a45fd4104 ("ixgbe: add VMDq support")
>=20
> Signed-off-by: Tomasz Kulasek <tomaszx.kulasek@intel.com>
Acked-by: Wenzhuo Lu <wenzhuo.lu@intel.com>