From: "Lu, Wenzhuo" <wenzhuo.lu@intel.com>
To: "Xing, Beilei" <beilei.xing@intel.com>,
"Wu, Jingjing" <jingjing.wu@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, "Xing, Beilei" <beilei.xing@intel.com>
Subject: Re: [dpdk-dev] [PATCH] ethdev: change comments of VLAN type
Date: Fri, 3 Jun 2016 02:52:42 +0000 [thread overview]
Message-ID: <6A0DE07E22DDAD4C9103DF62FEBC090903478B0A@shsmsx102.ccr.corp.intel.com> (raw)
In-Reply-To: <1464247695-4694-1-git-send-email-beilei.xing@intel.com>
Hi Beilei,
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Beilei Xing
> Sent: Thursday, May 26, 2016 3:28 PM
> To: Wu, Jingjing
> Cc: dev@dpdk.org; Xing, Beilei
> Subject: [dpdk-dev] [PATCH] ethdev: change comments of VLAN type
>
> If the packet carries a single VLAN header, it is treated as the outer header.
> So change the comments of inner VLAN and outer VLAN.
>
> Signed-off-by: Beilei Xing <beilei.xing@intel.com>
> ---
> doc/guides/rel_notes/release_16_07.rst | 3 +++
> lib/librte_ether/rte_ethdev.h | 4 ++--
> 2 files changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/doc/guides/rel_notes/release_16_07.rst
> b/doc/guides/rel_notes/release_16_07.rst
> index 30e78d4..29db86c 100644
> --- a/doc/guides/rel_notes/release_16_07.rst
> +++ b/doc/guides/rel_notes/release_16_07.rst
> @@ -116,6 +116,9 @@ API Changes
> ibadcrc, ibadlen, imcasts, fdirmatch, fdirmiss,
> tx_pause_xon, rx_pause_xon, tx_pause_xoff, rx_pause_xoff.
>
> +* The comments of ``ETH_VLAN_TYPE_INNER`` and
> ``ETH_VLAN_TYPE_OUTER``
> +in
> + ``rte_vlan_type`` are changed.
I think we need more explanation here. At least the info in the commit log.
next prev parent reply other threads:[~2016-06-03 2:52 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-26 7:28 Beilei Xing
2016-06-03 2:52 ` Lu, Wenzhuo [this message]
2016-06-03 3:13 ` Xing, Beilei
2016-06-13 8:03 ` [dpdk-dev] [PATCH v2] i40e: modify the meaning of single " Beilei Xing
2016-06-14 3:33 ` Wu, Jingjing
2016-06-21 10:29 ` Bruce Richardson
2016-06-21 11:06 ` Panu Matilainen
2016-06-21 11:28 ` Bruce Richardson
2016-06-21 11:30 ` Bruce Richardson
2016-06-22 2:53 ` [dpdk-dev] [PATCH v3] i40e: fix the type issue of a " Beilei Xing
2016-06-24 12:09 ` Bruce Richardson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6A0DE07E22DDAD4C9103DF62FEBC090903478B0A@shsmsx102.ccr.corp.intel.com \
--to=wenzhuo.lu@intel.com \
--cc=beilei.xing@intel.com \
--cc=dev@dpdk.org \
--cc=jingjing.wu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).