From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 57378A6A for ; Sun, 12 Jun 2016 02:56:16 +0200 (CEST) Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga103.jf.intel.com with ESMTP; 11 Jun 2016 17:56:15 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.26,459,1459839600"; d="scan'208";a="995818593" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by orsmga002.jf.intel.com with ESMTP; 11 Jun 2016 17:56:15 -0700 Received: from fmsmsx158.amr.corp.intel.com (10.18.116.75) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.248.2; Sat, 11 Jun 2016 17:56:14 -0700 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by fmsmsx158.amr.corp.intel.com (10.18.116.75) with Microsoft SMTP Server (TLS) id 14.3.248.2; Sat, 11 Jun 2016 17:56:14 -0700 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.147]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.107]) with mapi id 14.03.0248.002; Sun, 12 Jun 2016 08:56:13 +0800 From: "Lu, Wenzhuo" To: Thomas Monjalon , "Ananyev, Konstantin" CC: "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH] examples: add a new example for link reset Thread-Index: AQHRv7cTHuOir60kT06vHozqWycsfZ/eMuEAgACSFqD///eTAIAABjKAgAZHsXA= Date: Sun, 12 Jun 2016 00:56:12 +0000 Message-ID: <6A0DE07E22DDAD4C9103DF62FEBC0909034848F7@shsmsx102.ccr.corp.intel.com> References: <1465192093-28651-1-git-send-email-wenzhuo.lu@intel.com> <6A0DE07E22DDAD4C9103DF62FEBC090903483A48@shsmsx102.ccr.corp.intel.com> <2601191342CEEE43887BDE71AB97725836B6CC85@irsmsx105.ger.corp.intel.com> <1759174.lsNpYsad2D@xps13> In-Reply-To: <1759174.lsNpYsad2D@xps13> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] examples: add a new example for link reset X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 12 Jun 2016 00:56:16 -0000 Hi Konstantin, Thomas, > -----Original Message----- > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > Sent: Wednesday, June 8, 2016 5:00 PM > To: Ananyev, Konstantin; Lu, Wenzhuo > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] examples: add a new example for link rese= t >=20 > 2016-06-08 08:37, Ananyev, Konstantin: > > > From: Ananyev, Konstantin > > > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Wenzhuo Lu > > > > > Add a new example to show when the PF is down and up, VF port > > > > > can be reset and recover. > > > > > > > > Do we really need a totally new example for it? > > > > Can't we put it in one of already existing ones? > > > > Let say we have l3fwd-vf... wouldn't that suit your needs? > > > > Konstantin > > > I thought about just modifying an existing example. But I choose to > > > add a new one at last. The benefit of a totally new example is we can= make it > simple enough and focus on the reset function. > > > So it's easier for the users to find what we want to show. And it's > > > also easier for us as we don't need to care about if our > > > modification will break some function of the original example :) > > > > I still think that adding a new example for esch new feature/function i= n > rte_ethdev API iw way too expensive. > > If your change is not good enough and will break original example, > > then you probably re-work your feature patch to make it stable enough. > > After all people will use it in their existing apps, not write the new = ones right? > > BTW, why not make it work with testpmd? > > After all it is a new PMD api, an that's for we have our testpmd here? >=20 > +1 for testpmd I may not make myself clear. I said "function" but actually I mainly mean t= he performance impact but not the functionality. As we know l2fwd and l3fwd= can be used to show the performance of DPDK, adding lock will break this f= unction, showing the performance data. That's why I don't want to touch l2f= wd and l3fwd. Agree that testpmd can be a choice. I'll try to modify testpmd, maybe add a= parameter, like "testpmd --lock". So by default we will not use lock mode.