From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id C3128B460 for ; Wed, 22 Jun 2016 10:25:48 +0200 (CEST) Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga101.fm.intel.com with ESMTP; 22 Jun 2016 01:25:47 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.26,509,1459839600"; d="scan'208";a="126503456" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by fmsmga004.fm.intel.com with ESMTP; 22 Jun 2016 01:25:47 -0700 Received: from fmsmsx121.amr.corp.intel.com (10.18.125.36) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.248.2; Wed, 22 Jun 2016 01:25:47 -0700 Received: from shsmsx103.ccr.corp.intel.com (10.239.4.69) by fmsmsx121.amr.corp.intel.com (10.18.125.36) with Microsoft SMTP Server (TLS) id 14.3.248.2; Wed, 22 Jun 2016 01:25:47 -0700 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.147]) by SHSMSX103.ccr.corp.intel.com ([169.254.4.181]) with mapi id 14.03.0248.002; Wed, 22 Jun 2016 16:25:45 +0800 From: "Lu, Wenzhuo" To: Thomas Monjalon , Jerin Jacob CC: "Ananyev, Konstantin" , Stephen Hemminger , "dev@dpdk.org" , "Richardson, Bruce" , "Chen, Jing D" , "Liang, Cunming" , "Wu, Jingjing" , "Zhang, Helin" Thread-Topic: [dpdk-dev] [PATCH v6 1/4] lib/librte_ether: support device reset Thread-Index: AQHRyrx6NqZsK6LoQ0Kr0EDRoXtySZ/xjKGAgAB2MwCAAMH0gIAAqwkw//+UC4CAAIsykP//irIAgAAIkQCAABmdAIAAJRoAgAAFmQCAAAkYgIAAB1CAgAE5dBD//5INgAASMuVg//+JcoD//22SwIAAsrIA//9zMjCAAKtmAIAABPIA//942+A= Date: Wed, 22 Jun 2016 08:25:45 +0000 Message-ID: <6A0DE07E22DDAD4C9103DF62FEBC09090348995A@shsmsx102.ccr.corp.intel.com> References: <20160621133041.GA7509@localhost.localdomain> <6A0DE07E22DDAD4C9103DF62FEBC09090348987B@shsmsx102.ccr.corp.intel.com> <20160622075930.GA2577@localhost.localdomain> <6749084.arHGZf8DkE@xps13> In-Reply-To: <6749084.arHGZf8DkE@xps13> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v6 1/4] lib/librte_ether: support device reset X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 22 Jun 2016 08:25:49 -0000 Hi Thomas, > -----Original Message----- > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > Sent: Wednesday, June 22, 2016 4:17 PM > To: Jerin Jacob > Cc: Lu, Wenzhuo; Ananyev, Konstantin; Stephen Hemminger; dev@dpdk.org; > Richardson, Bruce; Chen, Jing D; Liang, Cunming; Wu, Jingjing; Zhang, Hel= in > Subject: Re: [dpdk-dev] [PATCH v6 1/4] lib/librte_ether: support device r= eset >=20 > 2016-06-22 13:29, Jerin Jacob: > > Thomas, > > As a librte_ether maintainer any comments on this? >=20 > +1 for adding details and make sure naming is good. > I don't really need to comment here because I have already done this comm= ent > earlier: > http://dpdk.org/ml/archives/dev/2016-June/041845.html > Thank you for insisting. I've add some details in this patch set. If it's not enough, please let me = know. And I think this discussion is about what the API name should be like. Actu= ally I think all the existing name is describing what is done by the API no= t when and where it should be used, like dev_start/stop. But anyway I'm open for changing the name. Is the name process_reset_intr y= ou prefer? Thanks.