From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <wenzhuo.lu@intel.com>
Received: from mga02.intel.com (mga02.intel.com [134.134.136.20])
 by dpdk.org (Postfix) with ESMTP id C8D40C67E
 for <dev@dpdk.org>; Fri, 24 Jun 2016 10:32:00 +0200 (CEST)
Received: from fmsmga001.fm.intel.com ([10.253.24.23])
 by orsmga101.jf.intel.com with ESMTP; 24 Jun 2016 01:31:51 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.26,518,1459839600"; d="scan'208";a="994213522"
Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205])
 by fmsmga001.fm.intel.com with ESMTP; 24 Jun 2016 01:31:09 -0700
Received: from fmsmsx111.amr.corp.intel.com (10.18.116.5) by
 fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS)
 id 14.3.248.2; Fri, 24 Jun 2016 01:31:08 -0700
Received: from shsmsx104.ccr.corp.intel.com (10.239.4.70) by
 fmsmsx111.amr.corp.intel.com (10.18.116.5) with Microsoft SMTP Server (TLS)
 id 14.3.248.2; Fri, 24 Jun 2016 01:31:08 -0700
Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.147]) by
 SHSMSX104.ccr.corp.intel.com ([169.254.5.116]) with mapi id 14.03.0248.002;
 Fri, 24 Jun 2016 16:31:06 +0800
From: "Lu, Wenzhuo" <wenzhuo.lu@intel.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
CC: "dev@dpdk.org" <dev@dpdk.org>, Markos Chandras <mchandras@suse.de>
Thread-Topic: [dpdk-dev] [PATCH] e1000/base: Add missing braces to the 'if'
 statements
Thread-Index: AQHRzTFccdXF/BzwqEurm4yxaP9Qe5/3x5bw///njoCAAJugwA==
Date: Fri, 24 Jun 2016 08:31:05 +0000
Message-ID: <6A0DE07E22DDAD4C9103DF62FEBC09090348A53B@shsmsx102.ccr.corp.intel.com>
References: <20160623092552.30932-1-mchandras@suse.de>
 <6A0DE07E22DDAD4C9103DF62FEBC09090348A2A5@shsmsx102.ccr.corp.intel.com>
 <2260730.VRpmIevhvb@xps13>
In-Reply-To: <2260730.VRpmIevhvb@xps13>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [10.239.127.40]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Subject: Re: [dpdk-dev] [PATCH] e1000/base: Add missing braces to the
	'if'	statements
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 24 Jun 2016 08:32:01 -0000

Hi Thomas, Markos,


> -----Original Message-----
> From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]
> Sent: Friday, June 24, 2016 3:13 PM
> To: Lu, Wenzhuo
> Cc: dev@dpdk.org; Markos Chandras
> Subject: Re: [dpdk-dev] [PATCH] e1000/base: Add missing braces to the 'if=
'
> statements
>=20
> 2016-06-24 00:43, Lu, Wenzhuo:
> > Thanks for this patch. But normally the code in the base directory is s=
ynced
> from the kernel driver. So we don't change it if there's no critical issu=
e. It's easy
> for us to maintain it. Thanks.
>=20
> I think a build error is critical enough.
OK. The change itself looks fine to me.