From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <wenzhuo.lu@intel.com> Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id C05A12BAC for <dev@dpdk.org>; Thu, 30 Jun 2016 03:40:22 +0200 (CEST) Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga103.fm.intel.com with ESMTP; 29 Jun 2016 18:40:13 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.26,549,1459839600"; d="scan'208";a="130949274" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by fmsmga004.fm.intel.com with ESMTP; 29 Jun 2016 18:40:12 -0700 Received: from fmsmsx117.amr.corp.intel.com (10.18.116.17) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.248.2; Wed, 29 Jun 2016 18:40:12 -0700 Received: from shsmsx103.ccr.corp.intel.com (10.239.4.69) by fmsmsx117.amr.corp.intel.com (10.18.116.17) with Microsoft SMTP Server (TLS) id 14.3.248.2; Wed, 29 Jun 2016 18:40:11 -0700 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.147]) by SHSMSX103.ccr.corp.intel.com ([169.254.4.181]) with mapi id 14.03.0248.002; Thu, 30 Jun 2016 09:40:10 +0800 From: "Lu, Wenzhuo" <wenzhuo.lu@intel.com> To: "Lu, Wenzhuo" <wenzhuo.lu@intel.com>, Thomas Monjalon <thomas.monjalon@6wind.com> CC: "dev@dpdk.org" <dev@dpdk.org> Thread-Topic: [dpdk-dev] [PATCH v3] ethdev: fix DCB config issue on ixgbe Thread-Index: AQHRpxXhFJOQv8PwVUaxzSEU0YQK9J/1ey4AgAEJLrCAADr8AIABVXLggAl7p2A= Date: Thu, 30 Jun 2016 01:40:09 +0000 Message-ID: <6A0DE07E22DDAD4C9103DF62FEBC09090348C059@shsmsx102.ccr.corp.intel.com> References: <1460363050-27962-1-git-send-email-wenzhuo.lu@intel.com> <1871393.ccgjmFpxqt@xps13> <6A0DE07E22DDAD4C9103DF62FEBC090903489DBD@shsmsx102.ccr.corp.intel.com> <3037324.FL8zRspYFl@xps13> <6A0DE07E22DDAD4C9103DF62FEBC09090348A2BD@shsmsx102.ccr.corp.intel.com> In-Reply-To: <6A0DE07E22DDAD4C9103DF62FEBC09090348A2BD@shsmsx102.ccr.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v3] ethdev: fix DCB config issue on ixgbe X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK <dev.dpdk.org> List-Unsubscribe: <http://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <http://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Thu, 30 Jun 2016 01:40:23 -0000 Hi Thomas, > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Lu, Wenzhuo > Sent: Friday, June 24, 2016 8:46 AM > To: Thomas Monjalon > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v3] ethdev: fix DCB config issue on ixgbe >=20 > Hi Thomas, >=20 >=20 > > -----Original Message----- > > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > > Sent: Thursday, June 23, 2016 8:22 PM > > To: Lu, Wenzhuo > > Cc: dev@dpdk.org > > Subject: Re: [dpdk-dev] [PATCH v3] ethdev: fix DCB config issue on > > ixgbe > > > > 2016-06-23 01:04, Lu, Wenzhuo: > > > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > > > > 2016-05-06 05:33, Wenzhuo Lu: > > > > > +int > > > > > +rte_eth_dev_mq_mode_set(uint8_t port_id, > > > > > + enum rte_eth_rx_mq_mode rx_mq_mode, > > > > > + enum rte_eth_tx_mq_mode tx_mq_mode); > > > > > > > > I've really tried to think about it and I think it is more or less = a hack. > > > > First, it is not explained in the doc when we should use > > > > rte_eth_dev_mq_mode_set() instead of a simple call to > > rte_eth_dev_configure(). > > > > Second, I don't understand why having a function which configures > > > > the "multiqueue modes" without configuring properly RSS/VMDq/DCB. > > > > Last, it is said that rte_eth_dev_configure() "must be invoked > > > > first before any other function in the Ethernet API". After checking the code, Honestly I'm confused. I don't find this descripti= on. And on the contrary, I find rte_eth_dev_info_get is always called befor= e rte_eth_dev_configure. I believe it's the problem. As rte_eth_dev_configu= re is not run, rte_eth_dev_info_get cannot get the right info. That why I h= ave to add a API to set the mq_mode before rte_eth_dev_info_get. Does that mean all the related examples are wrong? Any opinion? Thanks.