From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 729572BFA for ; Thu, 30 Jun 2016 10:47:33 +0200 (CEST) Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga103.jf.intel.com with ESMTP; 30 Jun 2016 01:47:31 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.26,551,1459839600"; d="scan'208";a="837883731" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by orsmga003.jf.intel.com with ESMTP; 30 Jun 2016 01:47:31 -0700 Received: from fmsmsx124.amr.corp.intel.com (10.18.125.39) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.248.2; Thu, 30 Jun 2016 01:47:31 -0700 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by fmsmsx124.amr.corp.intel.com (10.18.125.39) with Microsoft SMTP Server (TLS) id 14.3.248.2; Thu, 30 Jun 2016 01:47:30 -0700 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.147]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.230]) with mapi id 14.03.0248.002; Thu, 30 Jun 2016 16:47:29 +0800 From: "Lu, Wenzhuo" To: Thomas Monjalon CC: "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH v3] ethdev: fix DCB config issue on ixgbe Thread-Index: AQHRpxXhFJOQv8PwVUaxzSEU0YQK9J/1ey4AgAEJLrCAADr8AIABVXLggAl7p2D//+EIgIAAiSKggAAOmjA= Date: Thu, 30 Jun 2016 08:47:28 +0000 Message-ID: <6A0DE07E22DDAD4C9103DF62FEBC09090348C3AF@shsmsx102.ccr.corp.intel.com> References: <1460363050-27962-1-git-send-email-wenzhuo.lu@intel.com> <6A0DE07E22DDAD4C9103DF62FEBC09090348A2BD@shsmsx102.ccr.corp.intel.com> <6A0DE07E22DDAD4C9103DF62FEBC09090348C059@shsmsx102.ccr.corp.intel.com> <1501713.7uhgKcRiBR@xps13> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v3] ethdev: fix DCB config issue on ixgbe X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 30 Jun 2016 08:47:34 -0000 Hi Thomas, > -----Original Message----- > From: Lu, Wenzhuo > Sent: Thursday, June 30, 2016 4:23 PM > To: 'Thomas Monjalon' > Cc: dev@dpdk.org > Subject: RE: [dpdk-dev] [PATCH v3] ethdev: fix DCB config issue on ixgbe >=20 > Hi Thomas, >=20 > > -----Original Message----- > > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > > Sent: Thursday, June 30, 2016 3:42 PM > > To: Lu, Wenzhuo > > Cc: dev@dpdk.org > > Subject: Re: [dpdk-dev] [PATCH v3] ethdev: fix DCB config issue on > > ixgbe > > > > 2016-06-30 01:40, Lu, Wenzhuo: > > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Lu, Wenzhuo > > > > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > > > > > 2016-06-23 01:04, Lu, Wenzhuo: > > > > > > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > > > > > > > 2016-05-06 05:33, Wenzhuo Lu: > > > > > > > > +int > > > > > > > > +rte_eth_dev_mq_mode_set(uint8_t port_id, > > > > > > > > + enum rte_eth_rx_mq_mode rx_mq_mode, > > > > > > > > + enum rte_eth_tx_mq_mode tx_mq_mode); > > > > > > > > > > > > > > I've really tried to think about it and I think it is more or= less a hack. > > > > > > > First, it is not explained in the doc when we should use > > > > > > > rte_eth_dev_mq_mode_set() instead of a simple call to > > > > > rte_eth_dev_configure(). > > > > > > > Second, I don't understand why having a function which > > > > > > > configures the "multiqueue modes" without configuring > > > > > > > properly > > RSS/VMDq/DCB. > > > > > > > Last, it is said that rte_eth_dev_configure() "must be > > > > > > > invoked first before any other function in the Ethernet API". > > > After checking the code, Honestly I'm confused. I don't find this des= cription. > > > > It's in the description of rte_eth_dev_configure(): > > http://dpdk.org/browse/dpdk/tree/lib/librte_ether/rte_ethdev.h#n1904 > The bad news is this rule is not followed. I think the reason is somethin= g has to > be done before configure. >=20 > > > > > And on the contrary, I find rte_eth_dev_info_get is always called > > > before rte_eth_dev_configure. I believe it's the problem. > > > As rte_eth_dev_configure is not run, rte_eth_dev_info_get cannot get > > > the > > right info. > > > That why I have to add a API to set the mq_mode before > > rte_eth_dev_info_get. > > > Does that mean all the related examples are wrong? Any opinion? Thank= s. > > > > My opinion is that this area needs a good cleanup and easy API :) > OK. My solution is > 1, Remove the description " rte_eth_dev_configure() must be invoked first > before any other function in the Ethernet API ". I think it's reasonable = to execute > the rte_eth_dev_info_get before rte_eth_dev_configure, because we need to > get some NIC specific limitation to check if the configuration is right. > 2, Add one more argument, " const struct rte_eth_conf *eth_conf ", for > rte_eth_dev_info_get, like this, void rte_eth_dev_info_get(uint8_t port_i= d, > struct rte_eth_dev_info *dev_info, const struct rte_eth_conf *eth_conf); > because getting the right info depends on the configuration. And I'm a little lost, my patch has nothing to do with rte_eth_dev_configur= e. I just try to fix the issue that rte_eth_dev_info_get has dependency wit= h configuration. If the configure is not right, we cannot get the right inf= o.