From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <wenzhuo.lu@intel.com>
Received: from mga09.intel.com (mga09.intel.com [134.134.136.24])
 by dpdk.org (Postfix) with ESMTP id 59A242BBD
 for <dev@dpdk.org>; Mon, 11 Jul 2016 10:09:33 +0200 (CEST)
Received: from fmsmga004.fm.intel.com ([10.253.24.48])
 by orsmga102.jf.intel.com with ESMTP; 11 Jul 2016 01:09:32 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.28,345,1464678000"; d="scan'208";a="137053458"
Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205])
 by fmsmga004.fm.intel.com with ESMTP; 11 Jul 2016 01:09:32 -0700
Received: from fmsmsx121.amr.corp.intel.com (10.18.125.36) by
 fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS)
 id 14.3.248.2; Mon, 11 Jul 2016 01:09:31 -0700
Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by
 fmsmsx121.amr.corp.intel.com (10.18.125.36) with Microsoft SMTP Server (TLS)
 id 14.3.248.2; Mon, 11 Jul 2016 01:09:31 -0700
Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.147]) by
 SHSMSX151.ccr.corp.intel.com ([169.254.3.150]) with mapi id 14.03.0248.002;
 Mon, 11 Jul 2016 16:09:29 +0800
From: "Lu, Wenzhuo" <wenzhuo.lu@intel.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
CC: "dev@dpdk.org" <dev@dpdk.org>
Thread-Topic: [PATCH] lib/librte_ether: bypass code cleanup
Thread-Index: AQHR2zymtBgCFeOiAEKUxDw0xsTS1aASSj2AgACVTVA=
Date: Mon, 11 Jul 2016 08:09:28 +0000
Message-ID: <6A0DE07E22DDAD4C9103DF62FEBC09090348F369@shsmsx102.ccr.corp.intel.com>
References: <1468218079-8064-1-git-send-email-wenzhuo.lu@intel.com>
 <2092181.9Q4Kasxdod@xps13>
In-Reply-To: <2092181.9Q4Kasxdod@xps13>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [10.239.127.40]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Subject: Re: [dpdk-dev] [PATCH] lib/librte_ether: bypass code cleanup
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Mon, 11 Jul 2016 08:09:33 -0000

> -----Original Message-----
> From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]
> Sent: Monday, July 11, 2016 3:11 PM
> To: Lu, Wenzhuo
> Cc: dev@dpdk.org
> Subject: Re: [PATCH] lib/librte_ether: bypass code cleanup
>=20
> 2016-07-11 14:21, Wenzhuo Lu:
> > In testpmd code, device id is used directly to check if bypass is
> > supported. But APP should not know the details of HW, the NIC specific
> > info should not be exposed here.
>=20
> Right
>=20
> > This patch adds a new rte API to check if bypass is supported.
>=20
> Hmmm. It's true it is cleaner. But I am not sure having a generic API for=
 bypass is
> a good idea at all.
> I was thinking to totally remove it.
> Maybe we can try to have a specific API by including ixgbe_bypass.h in th=
e
> application.
According to Jingjing's comments, I think we need not check if bypass is su=
pported. Every API will return fail if it's not supported. I'll send a V2 t=
o remove the bypass_is_supported.