From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <wenzhuo.lu@intel.com>
Received: from mga05.intel.com (mga05.intel.com [192.55.52.43])
 by dpdk.org (Postfix) with ESMTP id 98F262A07
 for <dev@dpdk.org>; Thu, 20 Oct 2016 03:40:01 +0200 (CEST)
Received: from fmsmga006.fm.intel.com ([10.253.24.20])
 by fmsmga105.fm.intel.com with ESMTP; 19 Oct 2016 18:40:00 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.31,516,1473145200"; d="scan'208";a="21471498"
Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201])
 by fmsmga006.fm.intel.com with ESMTP; 19 Oct 2016 18:40:00 -0700
Received: from fmsmsx125.amr.corp.intel.com (10.18.125.40) by
 FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS)
 id 14.3.248.2; Wed, 19 Oct 2016 18:40:00 -0700
Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by
 FMSMSX125.amr.corp.intel.com (10.18.125.40) with Microsoft SMTP Server (TLS)
 id 14.3.248.2; Wed, 19 Oct 2016 18:40:00 -0700
Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.206]) by
 SHSMSX152.ccr.corp.intel.com ([169.254.6.2]) with mapi id 14.03.0248.002;
 Thu, 20 Oct 2016 09:39:59 +0800
From: "Lu, Wenzhuo" <wenzhuo.lu@intel.com>
To: "E. Scott Daniels" <daniels@research.att.com>, "Zhang, Helin"
 <helin.zhang@intel.com>, "Iremonger, Bernard" <bernard.iremonger@intel.com>
CC: "dev@dpdk.org" <dev@dpdk.org>, "az5157@att.com" <az5157@att.com>
Thread-Topic: [dpdk-dev] [PATCH] net/ixgbe: prevent duplicate callback on list
Thread-Index: AQHSKld42zdzHoqt2EuGanzL/cu6dqCwj21w
Date: Thu, 20 Oct 2016 01:39:59 +0000
Message-ID: <6A0DE07E22DDAD4C9103DF62FEBC09093933D40B@shsmsx102.ccr.corp.intel.com>
References: <1476915787-28205-1-git-send-email-daniels@research.att.com>
 <1476915787-28205-2-git-send-email-daniels@research.att.com>
In-Reply-To: <1476915787-28205-2-git-send-email-daniels@research.att.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [10.239.127.40]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Subject: Re: [dpdk-dev] [PATCH] net/ixgbe: prevent duplicate callback on list
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 20 Oct 2016 01:40:02 -0000

Hi Scott,

> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of E. Scott Daniels
> Sent: Thursday, October 20, 2016 6:23 AM
> To: Zhang, Helin; Iremonger, Bernard
> Cc: dev@dpdk.org; az5157@att.com; E. Scott Daniels
> Subject: [dpdk-dev] [PATCH] net/ixgbe: prevent duplicate callback on list
>=20
> This change prevents the attempt to add a structure which is already on t=
he
> callback list. If a struct with matching parameters is found on the list,=
 then no
> action is taken. If a struct with matching parameters is found on the lis=
t, then no
> action is taken.
>=20
> Signed-off-by: E. Scott Daniels <daniels@research.att.com>
I think the fix itself is good.  But 2 things,
1, normally we don't create a cover letter for a patch set which only has o=
ne patch. Just sending the patch itself is enough.
2, ' net/ixgbe: ' in the title is used to describe the component. So the ti=
tle should be ' lib/ether: prevent duplicate callback on list'.
Thanks.