From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 566AA2A66 for ; Thu, 3 Nov 2016 01:35:36 +0100 (CET) Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga101.jf.intel.com with ESMTP; 02 Nov 2016 17:35:34 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.31,436,1473145200"; d="scan'208";a="26754943" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by fmsmga006.fm.intel.com with ESMTP; 02 Nov 2016 17:35:34 -0700 Received: from fmsmsx152.amr.corp.intel.com (10.18.125.5) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.248.2; Wed, 2 Nov 2016 17:35:34 -0700 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by FMSMSX152.amr.corp.intel.com (10.18.125.5) with Microsoft SMTP Server (TLS) id 14.3.248.2; Wed, 2 Nov 2016 17:35:34 -0700 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.206]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.96]) with mapi id 14.03.0248.002; Thu, 3 Nov 2016 08:35:31 +0800 From: "Lu, Wenzhuo" To: Ananda Sathyanarayana Thread-Topic: [PATCH v2] E1000: fix for forced speed/duplex config Thread-Index: AQHSNWi0RIgFcwgFe0SZGaXlGlzeDaDGaU/Q Date: Thu, 3 Nov 2016 00:35:30 +0000 Message-ID: <6A0DE07E22DDAD4C9103DF62FEBC090939340B93@shsmsx102.ccr.corp.intel.com> References: <1478129815-241504-1-git-send-email-ananda@versa-networks.com> In-Reply-To: <1478129815-241504-1-git-send-email-ananda@versa-networks.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH v2] E1000: fix for forced speed/duplex config X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 03 Nov 2016 00:35:36 -0000 Hi, > -----Original Message----- > From: Ananda Sathyanarayana [mailto:ananda@versa-networks.com] > Sent: Thursday, November 3, 2016 7:37 AM > To: Lu, Wenzhuo > Cc: dev@dpdk.org; Ananda Sathyanarayana > Subject: [PATCH v2] E1000: fix for forced speed/duplex config >=20 > Fixed the formating/syntax issues reported >=20 > From the code, it looks like, hw->mac.autoneg, variable is used to switch > between calling either autoneg function or forcing speed/duplex function.= But > this variable is not modified in eth_em_start/eth_igb_start routines (it = is always > set to 1) even while forcing the link speed. >=20 > Following discussion thread has some more information on this >=20 > http://dpdk.org/ml/archives/dev/2016-October/049272.html >=20 > Signed-off-by: Ananda Sathyanarayana Acked-by: Wenzhuo Lu