From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 5D7C21E33 for ; Tue, 8 Nov 2016 01:55:34 +0100 (CET) Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga103.fm.intel.com with ESMTP; 07 Nov 2016 16:55:33 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.31,459,1473145200"; d="scan'208";a="188791349" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by fmsmga004.fm.intel.com with ESMTP; 07 Nov 2016 16:55:32 -0800 Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.248.2; Mon, 7 Nov 2016 16:55:31 -0800 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.206]) by SHSMSX101.ccr.corp.intel.com ([169.254.1.104]) with mapi id 14.03.0248.002; Tue, 8 Nov 2016 08:55:28 +0800 From: "Lu, Wenzhuo" To: Thomas Monjalon CC: "dev@dpdk.org" , "adrien.mazarguil@6wind.com" , "Ananyev, Konstantin" Thread-Topic: [dpdk-dev] [PATCH] lib/ip_frag: fix IP reassembly not working issue Thread-Index: AQHSOJXTDjyP1/d5DUGtF8epS3mJYKDNc4GAgADPcBA= Date: Tue, 8 Nov 2016 00:55:28 +0000 Message-ID: <6A0DE07E22DDAD4C9103DF62FEBC090939341C21@shsmsx102.ccr.corp.intel.com> References: <1478452574-127074-1-git-send-email-wenzhuo.lu@intel.com> <67229791.hG439HiJFh@xps13> In-Reply-To: <67229791.hG439HiJFh@xps13> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] lib/ip_frag: fix IP reassembly not working issue X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 08 Nov 2016 00:55:34 -0000 Hi Thomas, > -----Original Message----- > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > Sent: Tuesday, November 8, 2016 4:28 AM > To: Lu, Wenzhuo > Cc: dev@dpdk.org; adrien.mazarguil@6wind.com; Ananyev, Konstantin > Subject: Re: [dpdk-dev] [PATCH] lib/ip_frag: fix IP reassembly not workin= g issue >=20 > 2016-11-06 12:16, Wenzhuo Lu: > > After changing pkt[0] to pkt[], the example IP reassembly is not > > working. > > It's weird because this change is fine. There should be no difference > > between them. > > As a workaround, revert this change. > > > > Fixes: 347a1e037fd3 (lib: use C99 syntax for zero-size arrays) > > > > Reported-by: Huilong Xu > > Signed-off-by: Wenzhuo Lu >=20 > Applied, thanks >=20 > Please keep us informed if you understand the issue. Just FYI, It's so weird, I have to work around it first. 1, I don't think there's any wrong with the code. 2, I cannot reproduce this issue on my machine, but Huilong can reproduce i= t on different machines. As Adrien said, it may be a compile issue. I guess= it's a compiler issue. Maybe gcc 4.8.5 has its own problem. (I'm using gcc= 4.8.3 which is fine.)