From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id 553B42BAC for ; Thu, 8 Dec 2016 01:49:48 +0100 (CET) Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga104.fm.intel.com with ESMTP; 07 Dec 2016 16:49:47 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,316,1477983600"; d="scan'208";a="40011011" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by orsmga005.jf.intel.com with ESMTP; 07 Dec 2016 16:49:47 -0800 Received: from fmsmsx157.amr.corp.intel.com (10.18.116.73) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.248.2; Wed, 7 Dec 2016 16:49:47 -0800 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by FMSMSX157.amr.corp.intel.com (10.18.116.73) with Microsoft SMTP Server (TLS) id 14.3.248.2; Wed, 7 Dec 2016 16:49:47 -0800 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.37]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.116]) with mapi id 14.03.0248.002; Thu, 8 Dec 2016 08:49:43 +0800 From: "Lu, Wenzhuo" To: "Yigit, Ferruh" , "dev@dpdk.org" CC: "Chen, Jing D" Thread-Topic: [dpdk-dev] [PATCH v2 32/32] app/testpmd: fix invalid port ID Thread-Index: AQHSUDqkwcPcsVwwxkOYyTBUc4PQeaD8HD0AgAEctKA= Date: Thu, 8 Dec 2016 00:49:43 +0000 Message-ID: <6A0DE07E22DDAD4C9103DF62FEBC090939361475@shsmsx102.ccr.corp.intel.com> References: <1480637533-37425-1-git-send-email-wenzhuo.lu@intel.com> <1481081535-37448-1-git-send-email-wenzhuo.lu@intel.com> <1481081535-37448-33-git-send-email-wenzhuo.lu@intel.com> <49f75886-8149-4900-c948-ea75be694b11@intel.com> In-Reply-To: <49f75886-8149-4900-c948-ea75be694b11@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2 32/32] app/testpmd: fix invalid port ID X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 08 Dec 2016 00:49:49 -0000 Hi Ferruh, > -----Original Message----- > From: Yigit, Ferruh > Sent: Wednesday, December 7, 2016 11:49 PM > To: Lu, Wenzhuo; dev@dpdk.org > Cc: Chen, Jing D > Subject: Re: [dpdk-dev] [PATCH v2 32/32] app/testpmd: fix invalid port ID >=20 > On 12/7/2016 3:32 AM, Wenzhuo Lu wrote: > > Some CLIs don't check the input port ID, it may cause segmentation > > fault (core dumped). >=20 > Are these functions (that we are adding extra check) added with this patc= hset? If > so why not add these checks where function implemented. >=20 > If these functions are already implemented before this patchset, this pat= ch can > be standalone patch, instead of being part of this patchset, and can be b= efore > this patchset so that it can be easily backported to stable trees. This patch is for the existing code. I think you're right. I'll remove it f= rom this patch set and send an isolate patch for it. >=20 > > > > Fixes: 425781ff5afe ("app/testpmd: add ixgbe VF management") > > > > Signed-off-by: Wenzhuo Lu > > Signed-off-by: Chen Jing D(Mark) > > --- >=20 > <...>