From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <wenzhuo.lu@intel.com>
Received: from mga07.intel.com (mga07.intel.com [134.134.136.100])
 by dpdk.org (Postfix) with ESMTP id AD0472B8E
 for <dev@dpdk.org>; Thu,  8 Dec 2016 02:01:15 +0100 (CET)
Received: from orsmga002.jf.intel.com ([10.7.209.21])
 by orsmga105.jf.intel.com with ESMTP; 07 Dec 2016 17:01:05 -0800
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.33,316,1477983600"; d="scan'208";a="15165686"
Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205])
 by orsmga002.jf.intel.com with ESMTP; 07 Dec 2016 17:01:05 -0800
Received: from fmsmsx125.amr.corp.intel.com (10.18.125.40) by
 fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS)
 id 14.3.248.2; Wed, 7 Dec 2016 17:01:04 -0800
Received: from shsmsx103.ccr.corp.intel.com (10.239.4.69) by
 FMSMSX125.amr.corp.intel.com (10.18.125.40) with Microsoft SMTP Server (TLS)
 id 14.3.248.2; Wed, 7 Dec 2016 17:01:04 -0800
Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.37]) by
 SHSMSX103.ccr.corp.intel.com ([169.254.4.17]) with mapi id 14.03.0248.002;
 Thu, 8 Dec 2016 09:01:02 +0800
From: "Lu, Wenzhuo" <wenzhuo.lu@intel.com>
To: "Yigit, Ferruh" <ferruh.yigit@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Thread-Topic: [PATCH v2 12/32] net/i40e: set VF MAC from PF support
Thread-Index: AQHSUJZkAMnOBOWMkEihAlTXPrUD8qD9O8qQ
Date: Thu, 8 Dec 2016 01:01:01 +0000
Message-ID: <6A0DE07E22DDAD4C9103DF62FEBC0909393614CD@shsmsx102.ccr.corp.intel.com>
References: <1480637533-37425-1-git-send-email-wenzhuo.lu@intel.com>
 <1481081535-37448-1-git-send-email-wenzhuo.lu@intel.com>
 <1481081535-37448-13-git-send-email-wenzhuo.lu@intel.com>
 <ade05c4f-1e55-f276-81ff-952ae768cc15@intel.com>
In-Reply-To: <ade05c4f-1e55-f276-81ff-952ae768cc15@intel.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [10.239.127.40]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Subject: Re: [dpdk-dev] [PATCH v2 12/32] net/i40e: set VF MAC from PF support
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 08 Dec 2016 01:01:16 -0000

Hi Ferruh,

> -----Original Message-----
> From: Yigit, Ferruh
> Sent: Wednesday, December 7, 2016 10:30 PM
> To: Lu, Wenzhuo; dev@dpdk.org
> Subject: Re: [PATCH v2 12/32] net/i40e: set VF MAC from PF support
>=20
> On 12/7/2016 3:31 AM, Wenzhuo Lu wrote:
> > Support setting VF MAC address from PF.
> > User can call the API on PF to set a specific VF's MAC address.
> >
> > This will reset the VF.
> >
> > Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
> > ---
>=20
> <...>
>=20
> >
> > +/**
> > + * Set the VF MAC address.
> > + *
> > + * This will reset the vf.
>=20
> It may be good if I add a comment that this also will remove all existing=
 mac
> filters. Same to commit log perhaps.
Agree. Please:)