From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id F2E18475D for ; Tue, 13 Dec 2016 02:45:12 +0100 (CET) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga102.fm.intel.com with ESMTP; 12 Dec 2016 17:45:11 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,339,1477983600"; d="scan'208";a="797295295" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by FMSMGA003.fm.intel.com with ESMTP; 12 Dec 2016 17:45:11 -0800 Received: from fmsmsx115.amr.corp.intel.com (10.18.116.19) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.248.2; Mon, 12 Dec 2016 17:45:11 -0800 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by fmsmsx115.amr.corp.intel.com (10.18.116.19) with Microsoft SMTP Server (TLS) id 14.3.248.2; Mon, 12 Dec 2016 17:45:11 -0800 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.11]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.235]) with mapi id 14.03.0248.002; Tue, 13 Dec 2016 09:45:09 +0800 From: "Lu, Wenzhuo" To: "Yigit, Ferruh" , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH v2 22/32] app/testpmd: use multicast promiscuous mode on i40e Thread-Index: AQHSUDqYSIB1B61QPkySiuaFWYO/ZKD8DxWAgAkVNZA= Date: Tue, 13 Dec 2016 01:45:09 +0000 Message-ID: <6A0DE07E22DDAD4C9103DF62FEBC09093B531E7E@SHSMSX103.ccr.corp.intel.com> References: <1480637533-37425-1-git-send-email-wenzhuo.lu@intel.com> <1481081535-37448-1-git-send-email-wenzhuo.lu@intel.com> <1481081535-37448-23-git-send-email-wenzhuo.lu@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2 22/32] app/testpmd: use multicast promiscuous mode on i40e X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 13 Dec 2016 01:45:13 -0000 Hi Ferruh, > -----Original Message----- > From: Yigit, Ferruh > Sent: Wednesday, December 7, 2016 11:02 PM > To: Lu, Wenzhuo; dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v2 22/32] app/testpmd: use multicast > promiscuous mode on i40e >=20 > On 12/7/2016 3:32 AM, Wenzhuo Lu wrote: > > Add testpmd CLI to set VF multicast promiscuous mode on i40e. > > > > Signed-off-by: Wenzhuo Lu > > --- > > app/test-pmd/cmdline.c | 86 +++++++++++++++++++++= ++++++++ > > doc/guides/testpmd_app_ug/testpmd_funcs.rst | 8 +++ > > 2 files changed, 94 insertions(+) > > > > diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c index > > d39712e..7e7a016 100644 > > --- a/app/test-pmd/cmdline.c > > +++ b/app/test-pmd/cmdline.c > > @@ -407,6 +407,9 @@ static void cmd_help_long_parsed(void > > *parsed_result, #ifdef RTE_LIBRTE_I40E_PMD > > "set vf unicast-promisc (port_id) (vf_id) (on|off)\n" > > " Set unicast promiscuous mode for a VF from the > PF.\n\n" > > + > > + "set vf multicast-promisc (port_id) (vf_id) (on|off)\n" > > + " Set multicast promiscuous mode for a VF from the > PF.\n\n" >=20 > Why not "allmulti" instead of multicast-promisc? >=20 > Also same comments as previous patch for help_str and documentation. Sorry for the late. You're right, I should not change the word. Will send a= V3. >=20 > <...>