From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <wenzhuo.lu@intel.com>
Received: from mga06.intel.com (mga06.intel.com [134.134.136.31])
 by dpdk.org (Postfix) with ESMTP id 03028475D
 for <dev@dpdk.org>; Tue, 13 Dec 2016 02:49:43 +0100 (CET)
Received: from fmsmga003.fm.intel.com ([10.253.24.29])
 by orsmga104.jf.intel.com with ESMTP; 12 Dec 2016 17:49:42 -0800
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.33,339,1477983600"; d="scan'208";a="797296624"
Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206])
 by FMSMGA003.fm.intel.com with ESMTP; 12 Dec 2016 17:49:42 -0800
Received: from fmsmsx121.amr.corp.intel.com (10.18.125.36) by
 FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS)
 id 14.3.248.2; Mon, 12 Dec 2016 17:49:42 -0800
Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by
 fmsmsx121.amr.corp.intel.com (10.18.125.36) with Microsoft SMTP Server (TLS)
 id 14.3.248.2; Mon, 12 Dec 2016 17:49:42 -0800
Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.11]) by
 SHSMSX101.ccr.corp.intel.com ([169.254.1.97]) with mapi id 14.03.0248.002;
 Tue, 13 Dec 2016 09:49:40 +0800
From: "Lu, Wenzhuo" <wenzhuo.lu@intel.com>
To: "Yigit, Ferruh" <ferruh.yigit@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Thread-Topic: [dpdk-dev] [PATCH v2 21/32] app/testpmd: use unicast
 promiscuous mode on i40e
Thread-Index: AQHSUDqYdPw4rV0B20qT/qpQXDjUbaD8DpeAgAkWEIA=
Date: Tue, 13 Dec 2016 01:49:39 +0000
Message-ID: <6A0DE07E22DDAD4C9103DF62FEBC09093B531E97@SHSMSX103.ccr.corp.intel.com>
References: <1480637533-37425-1-git-send-email-wenzhuo.lu@intel.com>
 <1481081535-37448-1-git-send-email-wenzhuo.lu@intel.com>
 <1481081535-37448-22-git-send-email-wenzhuo.lu@intel.com>
 <1466fda4-2097-b825-9e11-dc1aae63d803@intel.com>
In-Reply-To: <1466fda4-2097-b825-9e11-dc1aae63d803@intel.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [10.239.127.40]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Subject: Re: [dpdk-dev] [PATCH v2 21/32] app/testpmd: use unicast
 promiscuous mode on i40e
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 13 Dec 2016 01:49:44 -0000

Hi Ferruh,


> -----Original Message-----
> From: Yigit, Ferruh
> Sent: Wednesday, December 7, 2016 11:00 PM
> To: Lu, Wenzhuo; dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH v2 21/32] app/testpmd: use unicast promisc=
uous
> mode on i40e
>=20
> On 12/7/2016 3:32 AM, Wenzhuo Lu wrote:
> > Add testpmd CLI to set VF unicast promiscuous mode on i40e.
> >
> > Signed-off-by: Wenzhuo Lu <wenzhuo.lu@intel.com>
> > ---
> >  app/test-pmd/cmdline.c                      | 92 +++++++++++++++++++++=
++++++++
> >  doc/guides/testpmd_app_ug/testpmd_funcs.rst |  8 +++
> >  2 files changed, 100 insertions(+)
> >
> > diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c index
> > 12126ce..d39712e 100644
> > --- a/app/test-pmd/cmdline.c
> > +++ b/app/test-pmd/cmdline.c
> > @@ -404,6 +404,11 @@ static void cmd_help_long_parsed(void
> *parsed_result,
> >  			"set allmulti (port_id|all) (on|off)\n"
> >  			"    Set the allmulti mode on port_id, or all.\n\n"
> >
> > +#ifdef RTE_LIBRTE_I40E_PMD
> > +			"set vf unicast-promisc (port_id) (vf_id) (on|off)\n"
>=20
> Previous usages are all "promisc" instead of "unicals-promisc". Is this t=
o promisc
> mode for multicast packets? If so testpmd calls them "allmulti" I guess, =
so they
> won't cause trouble.
>=20
> Can we keep using command: "promisc"?
Yes, I'll change it.

>=20
> <...>
>=20
> > +
> > +cmdline_parse_inst_t cmd_set_vf_unicast_promisc =3D {
> > +	.f =3D cmd_set_vf_unicast_promisc_parsed,
> > +	.data =3D NULL,
> > +	.help_str =3D "set vf unicast promiscuous port_id vf_id on|off",
>=20
> Can you please differentiate the keyword and variable by wrapping variabl=
es
> with <>? Like:
> "set vf unicast-promiscuous <port_id> <vf_id> on|off"
The existing style is not adding the '<>'. But this help string is not good=
, it looks like CLI but not help. I'll change it.

>=20
> <...>
>=20
> >
> > diff --git a/doc/guides/testpmd_app_ug/testpmd_funcs.rst
> > b/doc/guides/testpmd_app_ug/testpmd_funcs.rst
> > index f1c269a..e17e3d5 100644
> > --- a/doc/guides/testpmd_app_ug/testpmd_funcs.rst
> > +++ b/doc/guides/testpmd_app_ug/testpmd_funcs.rst
> > @@ -820,6 +820,14 @@ Set the allmulti mode for a port or for all ports:=
:
> >
> >  Same as the ifconfig (8) option. Controls how multicast packets are ha=
ndled.
> >
> > +set unicast promisc (for VF)
> > +~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>=20
> Should we mention this is PMD specific feature and only enabled with some
> PMDs?
Yes. Will add more explanation.

>=20
> > +
> > +Set the unicast promiscuous mode for a VF from PF.
> > +In promiscuous mode packets are not dropped if they aren't for the spe=
cified
> MAC address::
> > +
> > +   testpmd> set vf unicast-promisc (port_id) (vf_id) (on|off)
> > +
> >  set flow_ctrl rx
> >  ~~~~~~~~~~~~~~~~
> >
> >