From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id 7DC22FAD1 for ; Tue, 20 Dec 2016 02:05:58 +0100 (CET) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga105.fm.intel.com with ESMTP; 19 Dec 2016 17:05:57 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,376,1477983600"; d="scan'208";a="800257336" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by FMSMGA003.fm.intel.com with ESMTP; 19 Dec 2016 17:05:57 -0800 Received: from fmsmsx156.amr.corp.intel.com (10.18.116.74) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.248.2; Mon, 19 Dec 2016 17:05:57 -0800 Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by fmsmsx156.amr.corp.intel.com (10.18.116.74) with Microsoft SMTP Server (TLS) id 14.3.248.2; Mon, 19 Dec 2016 17:05:57 -0800 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.54]) by SHSMSX101.ccr.corp.intel.com ([169.254.1.97]) with mapi id 14.03.0248.002; Tue, 20 Dec 2016 09:05:55 +0800 From: "Lu, Wenzhuo" To: "Yigit, Ferruh" , "dev@dpdk.org" CC: "Wu, Jingjing" , "Zhang, Helin" , "Chen, Jing D" , "Iremonger, Bernard" Thread-Topic: [PATCH v5 18/29] app/testpmd: use VFD APIs on i40e Thread-Index: AQHSV89oFCiFnlFGFEmic5JaZ5D006EO/6uAgAEK77A= Date: Tue, 20 Dec 2016 01:05:55 +0000 Message-ID: <6A0DE07E22DDAD4C9103DF62FEBC09093B5435FC@shsmsx102.ccr.corp.intel.com> References: <20161216143919.4909-1-ferruh.yigit@intel.com> <20161216190257.6921-1-ferruh.yigit@intel.com> <20161216190257.6921-19-ferruh.yigit@intel.com> <0b0af0c3-3b09-e44c-e489-d9a5313c4596@intel.com> In-Reply-To: <0b0af0c3-3b09-e44c-e489-d9a5313c4596@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v5 18/29] app/testpmd: use VFD APIs on i40e X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 20 Dec 2016 01:05:58 -0000 Hi Ferruh, > -----Original Message----- > From: Yigit, Ferruh > Sent: Tuesday, December 20, 2016 1:10 AM > To: dev@dpdk.org > Cc: Wu, Jingjing; Zhang, Helin; Lu, Wenzhuo; Chen, Jing D; Iremonger, Ber= nard > Subject: Re: [PATCH v5 18/29] app/testpmd: use VFD APIs on i40e >=20 > On 12/16/2016 7:02 PM, Ferruh Yigit wrote: > > From: Wenzhuo Lu > > > > The new VF Daemon (VFD) APIs is implemented on i40e. Change testpmd > > code to use them, including VF MAC anti-spoofing, VF VLAN > > anti-spoofing, TX loopback, VF VLAN strip, VF VLAN insert. > > > > Signed-off-by: Wenzhuo Lu > > Signed-off-by: Chen Jing D(Mark) > > Signed-off-by: Bernard Iremonger > > --- > > app/test-pmd/Makefile | 2 + > > app/test-pmd/cmdline.c | 150 > > +++++++++++++++++++++++++++++++++++++++---------- > > 2 files changed, 121 insertions(+), 31 deletions(-) > > > > diff --git a/app/test-pmd/Makefile b/app/test-pmd/Makefile index > > 891b85a..a0c3366 100644 > > --- a/app/test-pmd/Makefile > > +++ b/app/test-pmd/Makefile > > @@ -58,7 +58,9 @@ SRCS-y +=3D csumonly.c SRCS-y +=3D icmpecho.c > > SRCS-$(CONFIG_RTE_LIBRTE_IEEE1588) +=3D ieee1588fwd.c > > > > +_LDLIBS-y +=3D --whole-archive >=20 > Hi Wenzhuo, >=20 > Following lines are required for shared library, but I guess above line r= equired > because they cause problem with static library. > So, instead of adding above line, what do you think wrapping below lines = with > ifeq ($(CONFIG_RTE_BUILD_SHARED_LIB),y) ? Thanks for your suggestion. It's also a choice. I'll change it. >=20 > > _LDLIBS-$(CONFIG_RTE_LIBRTE_IXGBE_PMD) +=3D -lrte_pmd_ixgbe > > +_LDLIBS-$(CONFIG_RTE_LIBRTE_I40E_PMD) +=3D -lrte_pmd_i40e > > > > CFLAGS_cmdline.o :=3D -D_GNU_SOURCE > > > <...>