From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 6ABDF29CF for ; Thu, 5 Jan 2017 07:46:18 +0100 (CET) Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga103.fm.intel.com with ESMTP; 04 Jan 2017 22:46:17 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,319,1477983600"; d="scan'208";a="26394618" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by orsmga002.jf.intel.com with ESMTP; 04 Jan 2017 22:46:17 -0800 Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.248.2; Wed, 4 Jan 2017 22:46:17 -0800 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.88]) by SHSMSX101.ccr.corp.intel.com ([169.254.1.177]) with mapi id 14.03.0248.002; Thu, 5 Jan 2017 14:46:15 +0800 From: "Lu, Wenzhuo" To: "Wu, Jingjing" , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH v7 03/27] net/i40e: set VF MAC anti-spoofing from PF Thread-Index: AQHSZx7YzMhTddW0Y02+OR7PFzRcSqEpcEqA Date: Thu, 5 Jan 2017 06:46:14 +0000 Message-ID: <6A0DE07E22DDAD4C9103DF62FEBC09093B555EC5@shsmsx102.ccr.corp.intel.com> References: <1480637533-37425-1-git-send-email-wenzhuo.lu@intel.com> <1483426488-117332-1-git-send-email-wenzhuo.lu@intel.com> <1483426488-117332-4-git-send-email-wenzhuo.lu@intel.com> <9BB6961774997848B5B42BEC655768F810CC3562@SHSMSX103.ccr.corp.intel.com> In-Reply-To: <9BB6961774997848B5B42BEC655768F810CC3562@SHSMSX103.ccr.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v7 03/27] net/i40e: set VF MAC anti-spoofing from PF X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 05 Jan 2017 06:46:18 -0000 Hi Jingjing, > -----Original Message----- > From: Wu, Jingjing > Sent: Thursday, January 5, 2017 2:42 PM > To: Lu, Wenzhuo; dev@dpdk.org > Cc: Lu, Wenzhuo > Subject: RE: [dpdk-dev] [PATCH v7 03/27] net/i40e: set VF MAC anti-spoofi= ng > from PF >=20 >=20 >=20 > > -----Original Message----- > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Wenzhuo Lu > > Sent: Tuesday, January 3, 2017 2:54 PM > > To: dev@dpdk.org > > Cc: Lu, Wenzhuo > > Subject: [dpdk-dev] [PATCH v7 03/27] net/i40e: set VF MAC > > anti-spoofing from PF > > > > Support enabling/disabling VF MAC anti-spoofing from PF. > > User can call the API on PF to enable/disable a specific VF's MAC anti- > spoofing. > > > > Signed-off-by: Wenzhuo Lu > > --- > > drivers/net/i40e/i40e_ethdev.c | 63 > > +++++++++++++++++++++++++++++++ > > drivers/net/i40e/rte_pmd_i40e.h | 19 ++++++++++ > > drivers/net/i40e/rte_pmd_i40e_version.map | 1 + > > 3 files changed, 83 insertions(+) > > > > diff --git a/drivers/net/i40e/i40e_ethdev.c > > b/drivers/net/i40e/i40e_ethdev.c index fc7e987..68c07de 100644 > > --- a/drivers/net/i40e/i40e_ethdev.c > > +++ b/drivers/net/i40e/i40e_ethdev.c > > @@ -9723,3 +9723,66 @@ static void i40e_set_default_mac_addr(struct > > rte_eth_dev *dev, > > > > return 0; > > } > > + > > +int > > +rte_pmd_i40e_set_vf_mac_anti_spoof(uint8_t port, uint16_t vf_id, > > +uint8_t on) { > > + struct rte_eth_dev *dev; > > + struct rte_eth_dev_info dev_info; > > + struct i40e_pf *pf; > > + struct i40e_vsi *vsi; > > + struct i40e_hw *hw; > > + struct i40e_vsi_context ctxt; > > + int ret; > > + > > + RTE_ETH_VALID_PORTID_OR_ERR_RET(port, -ENODEV); > > + > > + dev =3D &rte_eth_devices[port]; > > + rte_eth_dev_info_get(port, &dev_info); > > + > Why need to call rte_eth_dev_info_get in driver? >=20 > > + if (vf_id >=3D dev_info.max_vfs) > > + return -EINVAL; > > + >=20 > Vf_id is already be checked by below, even I prefer : > if (vf_id > pf->vf_num - 1 || !pf->vfs) > to be > if (!pf->vfs || vf_id > pf->vf_num - 1) or if (!pf->vfs || vf_id >=3D p= f->vf_num) Agree, I'll remove the max_vfs check. >=20 > > + pf =3D I40E_DEV_PRIVATE_TO_PF(dev->data->dev_private); > > +